fix: heap-use-after-free in tray.popUpContextMenu #22842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
approved these changes
Mar 26, 2020
zcbenz
approved these changes
Mar 26, 2020
ckerr
approved these changes
Mar 26, 2020
|
Release Notes Persisted
|
|
I was unable to backport this PR to "8-x-y" cleanly; |
|
I was unable to backport this PR to "7-2-x" cleanly; |
|
I was unable to backport this PR to "6-1-x" cleanly; |
|
I have automatically backported this PR to "9-x-y", please check out #22855 |
sentialx
pushed a commit
to sentialx/electron
that referenced
this pull request
Apr 7, 2020
nornagon
added a commit
that referenced
this pull request
Apr 20, 2020
|
The backport to 6.1 wasn't clean and I don't think this is a serious enough issue to warrant the effort required to do the backport. |
nornagon
added a commit
that referenced
this pull request
Apr 21, 2020
nornagon
added a commit
that referenced
this pull request
Apr 21, 2020
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #22837.
Checklist
npm testpassesRelease Notes
Notes: Fixed a use-after-free error that could happen if a Tray was destroyed while showing a custom context menu.