Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: SimpleURLLoaderWrapper redirects (#21566) #21645

Merged
merged 1 commit into from
Jan 1, 2020
Merged

fix: SimpleURLLoaderWrapper redirects (#21566) #21645

merged 1 commit into from
Jan 1, 2020

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Dec 30, 2019

Backport of #21630

See that PR for details.

Notes: Fixed an issue in the net module where aborting a request during a redirect could cause an error to be thrown.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Dec 30, 2019
@trop trop bot mentioned this pull request Dec 30, 2019
Merged
2 tasks
@trop trop bot added 7-1-x backport This is a backport PR labels Dec 30, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Dec 30, 2019
@zcbenz zcbenz merged commit a889ec7 into 7-1-x Jan 1, 2020
@release-clerk
Copy link

release-clerk bot commented Jan 1, 2020

Release Notes Persisted

Fixed an issue in the net module where aborting a request during a redirect could cause an error to be thrown.

@zcbenz zcbenz deleted the trop/7-1-x-bp-fix-simpleurlloaderwrapper-redirects-21566--1577749641770 branch January 1, 2020 00:32
@lutzroeder
Copy link
Contributor

lutzroeder commented Jan 4, 2020 •
edited

@nornagon @zcbenz @codebytere @MarshallOfSound What would be needed to drop a 7.1.x release including this change? I haven't had much luck building the 7-1-x branch locally and master is not supported by electron-builder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nornagon nornagon nornagon approved these changes

@zcbenz zcbenz zcbenz approved these changes

Assignees
No one assigned
Labels
7-1-x backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lutzroeder @nornagon @zcbenz