Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: restore --ignore-connections-limit functionality #21286

Merged
merged 1 commit into from
Nov 26, 2019

Conversation

nornagon
Copy link
Member

Description of Change

This restores the inadvertently removed --ignore-connections-limit functionality.

Fixes #21255.

Checklist

Release Notes

Notes: Fixed --ignore-connections-limit, ironically, being ignored.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Nov 25, 2019
@nornagon
Copy link
Member Author

This is a little tricky to write a test for because it's read at app start time, so the only way to test it would be to spin up a whole new app with the flag applied. I'd like to refactor to make this testable (and make the set of ignore-connections-limit sites modifiable at run-time, too), but I thought I'd throw this up first.

@nornagon
Copy link
Member Author

win and arm failures are unrelated.

@deepak1556 deepak1556 merged commit 4149d76 into master Nov 26, 2019
@release-clerk
Copy link

release-clerk bot commented Nov 26, 2019

Release Notes Persisted

Fixed --ignore-connections-limit, ironically, being ignored.

@deepak1556 deepak1556 deleted the ignore-connections-limit branch November 26, 2019 21:27
@trop
Copy link
Contributor

trop bot commented Nov 26, 2019

I was unable to backport this PR to "8-x-y" cleanly;
you will need to perform this backport manually.

@trop trop bot removed the target/8-x-y label Nov 26, 2019
@trop
Copy link
Contributor

trop bot commented Nov 26, 2019

I was unable to backport this PR to "7-1-x" cleanly;
you will need to perform this backport manually.

@deepak1556
Copy link
Member

@nornagon the release note 😆 💯

@trop
Copy link
Contributor

trop bot commented Nov 26, 2019

@nornagon has manually backported this PR to "8-x-y", please check out #21298

@trop
Copy link
Contributor

trop bot commented Nov 26, 2019

@nornagon has manually backported this PR to "7-1-x", please check out #21299

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Nov 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"--ignore-connections-limit" commandLine switch stopped working in Electron@7
2 participants