-
Notifications
You must be signed in to change notification settings - Fork 15k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: restore --ignore-connections-limit functionality #21286
Conversation
This is a little tricky to write a test for because it's read at app start time, so the only way to test it would be to spin up a whole new app with the flag applied. I'd like to refactor to make this testable (and make the set of ignore-connections-limit sites modifiable at run-time, too), but I thought I'd throw this up first. |
win and arm failures are unrelated. |
Release Notes Persisted
|
I was unable to backport this PR to "8-x-y" cleanly; |
I was unable to backport this PR to "7-1-x" cleanly; |
@nornagon the release note 😆 💯 |
Description of Change
This restores the inadvertently removed
--ignore-connections-limit
functionality.Fixes #21255.
Checklist
npm test
passesRelease Notes
Notes: Fixed
--ignore-connections-limit
, ironically, being ignored.