Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: reloadIgnoringCache() should ignore the cache #21284

Merged
merged 1 commit into from
Nov 25, 2019
Merged

fix: reloadIgnoringCache() should ignore the cache #21284

merged 1 commit into from
Nov 25, 2019

Conversation

MarshallOfSound
Copy link
Member

Backport of #21263

See that PR for details.

Notes: webContents.reloadIgnoringCache() will now forcefully ignore all caches, including service workers

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Nov 25, 2019
@trop trop bot mentioned this pull request Nov 25, 2019
Merged
@trop trop bot added 7-1-x backport This is a backport PR labels Nov 25, 2019
@MarshallOfSound MarshallOfSound changed the title fix: reloadIgnoringCache() should ignore the cache (#21263) fix: reloadIgnoringCache() should ignore the cache Nov 25, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Nov 25, 2019
jkleinsc
jkleinsc approved these changes Nov 25, 2019
View reviewed changes
Copy link
Contributor

@jkleinsc jkleinsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming CI passes

@MarshallOfSound MarshallOfSound merged commit 67bcc2a into 7-1-x Nov 25, 2019
@release-clerk
Copy link

release-clerk bot commented Nov 25, 2019 •
edited by MarshallOfSound

Release Notes Persisted

webContents.reloadIgnoringCache() was not ignoring cache, now it does

@MarshallOfSound MarshallOfSound deleted the reload-ignoring-cache-should-ignore-cache-7 branch November 25, 2019 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkleinsc jkleinsc jkleinsc approved these changes

Assignees
No one assigned
Labels
7-1-x backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MarshallOfSound @jkleinsc