Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: capture the promise global to avoid userland mutation #20947

Merged
merged 2 commits into from Nov 4, 2019
Merged

fix: capture the promise global to avoid userland mutation #20947

merged 2 commits into from Nov 4, 2019

Conversation

MarshallOfSound
Copy link
Member

Backport of #20925 see that PR for details.

Notes: Fixed issue where proxied remote promises might not resolve if Bluebird was installed in the renderer

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Nov 4, 2019
@trop trop bot mentioned this pull request Nov 4, 2019
Merged
@trop trop bot added 7-0-x backport This is a backport PR labels Nov 4, 2019
@MarshallOfSound MarshallOfSound changed the title fix: capture the promise global to avoid userland mutation (#20925) fix: capture the promise global to avoid userland mutation Nov 4, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Nov 4, 2019
@MarshallOfSound MarshallOfSound changed the base branch from 7-0-x to 7-1-x November 4, 2019 22:54
@trop trop bot added the 7-1-x label Nov 4, 2019
@MarshallOfSound MarshallOfSound merged commit 4900923 into 7-1-x Nov 4, 2019
@MarshallOfSound MarshallOfSound deleted the capture-the-promise-global-7 branch November 4, 2019 23:58
@release-clerk
Copy link

release-clerk bot commented Nov 4, 2019

Release Notes Persisted

Fixed issue where proxied remote promises might not resolve if Bluebird was installed in the renderer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nornagon nornagon nornagon approved these changes

Assignees
No one assigned
Labels
7-1-x backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MarshallOfSound @nornagon