Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: cannot access nativeTheme via electron.remote #20938

Merged
merged 1 commit into from Nov 4, 2019
Merged

fix: cannot access nativeTheme via electron.remote #20938

merged 1 commit into from Nov 4, 2019

Conversation

miniak
Copy link
Contributor

@miniak miniak commented Nov 3, 2019 •
edited

Description of Change

Fixes #20900

Checklist

Release Notes

Notes: Fixed nativeTheme not accessible via the remote module.

@miniak miniak self-assigned this Nov 3, 2019
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Nov 3, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Nov 4, 2019
@miniak
Copy link
Contributor Author

miniak commented Nov 4, 2019

@MarshallOfSound can you please review?

@MarshallOfSound MarshallOfSound merged commit 01e18c2 into master Nov 4, 2019
@release-clerk
Copy link

release-clerk bot commented Nov 4, 2019

Release Notes Persisted

Fixed nativeTheme not accessible via the remote module.

@MarshallOfSound MarshallOfSound deleted the miniak/remote-native-theme branch November 4, 2019 22:17
@trop
Copy link
Contributor

trop bot commented Nov 4, 2019

I was unable to backport this PR to "7-0-x" cleanly;
you will need to perform this backport manually.

@trop trop bot mentioned this pull request Nov 4, 2019
Merged
@trop
Copy link
Contributor

trop bot commented Nov 4, 2019

I have automatically backported this PR to "8-x-y", please check out #20953

miniak added a commit that referenced this pull request Nov 4, 2019
@miniak
fix: cannot access nativeTheme via electron.remote (#20938)
f5dc940
@miniak miniak mentioned this pull request Nov 4, 2019
Merged
@trop
Copy link
Contributor

trop bot commented Nov 4, 2019

@miniak has manually backported this PR to "7-1-x", please check out #20961

@trop trop bot added the in-flight/7-1-x label Nov 4, 2019
MarshallOfSound pushed a commit that referenced this pull request Nov 5, 2019
@miniak @MarshallOfSound
fix: cannot access nativeTheme via electron.remote (#20938) (#20961)
317f0ce
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexeykuzmin alexeykuzmin alexeykuzmin approved these changes

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

@codebytere codebytere Awaiting requested review from codebytere

Assignees

@miniak miniak

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot access nativeTheme via electron.remote
3 participants
@miniak @alexeykuzmin @MarshallOfSound