Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use Unicode version of ShellExecute() in OpenExternalOnWorkerThread() #20905

Merged
merged 1 commit into from Nov 1, 2019
Merged

fix: use Unicode version of ShellExecute() in OpenExternalOnWorkerThread() #20905

merged 1 commit into from Nov 1, 2019

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Nov 1, 2019

Backport of #20879

See that PR for details.

Notes: Fixed shell.openExternal() option workingDirectory not working with Unicode characters.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Nov 1, 2019
@trop trop bot mentioned this pull request Nov 1, 2019
Merged
4 tasks
@trop trop bot added 7-0-x backport This is a backport PR labels Nov 1, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Nov 1, 2019
@jkleinsc jkleinsc merged commit e2c7e4b into 7-0-x Nov 1, 2019
@release-clerk
Copy link

release-clerk bot commented Nov 1, 2019

Release Notes Persisted

Fixed shell.openExternal() option workingDirectory not working with Unicode characters.

@jkleinsc jkleinsc deleted the trop/7-0-x-bp-fix-use-unicode-version-of-shellexecute-in-openexternalonworkerthread--1572586748198 branch November 1, 2019 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkleinsc jkleinsc jkleinsc approved these changes

Assignees
No one assigned
Labels
7-0-x backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jkleinsc @miniak