Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: devtools extensions not loading #20844

Merged
merged 1 commit into from Oct 30, 2019

Conversation

miniak
Copy link
Contributor

@miniak miniak commented Oct 30, 2019

Description of Change

Backport of #20791

Checklist

Release Notes

Notes: Fixed devtools extensions not loading due to "Connect to unknown extension [object Object]" errors.

@miniak miniak added backport This is a backport PR 7-0-x labels Oct 30, 2019
@miniak miniak self-assigned this Oct 30, 2019
@trop trop bot mentioned this pull request Oct 30, 2019
5 tasks
Copy link
Contributor

@jkleinsc jkleinsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if the extra console.log is removed

spec/fixtures/extensions/chrome-api/main.js Show resolved Hide resolved
@jkleinsc jkleinsc merged commit 771d4dc into 7-0-x Oct 30, 2019
@release-clerk
Copy link

release-clerk bot commented Oct 30, 2019

Release Notes Persisted

Fixed devtools extensions not loading due to "Connect to unknown extension [object Object]" errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
7-0-x backport This is a backport PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants