Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: pass frameId to v8Util.setRemoteCallbackFreer() #20814

Merged
merged 1 commit into from Oct 30, 2019
Merged

fix: pass frameId to v8Util.setRemoteCallbackFreer() #20814

merged 1 commit into from Oct 30, 2019

Conversation

miniak
Copy link
Contributor

@miniak miniak commented Oct 29, 2019

Description of Change

Backport of #20732

Checklist

Release Notes

Notes: Fixed memory leaks caused by callbacks not being released when the remote module is used in sub-frames (<iframe> or scriptable popup).

@miniak miniak added backport This is a backport PR 7-0-x labels Oct 29, 2019
@miniak miniak self-assigned this Oct 29, 2019
@trop trop bot mentioned this pull request Oct 29, 2019
Merged
5 tasks
@zcbenz zcbenz merged commit 725dac3 into 7-0-x Oct 30, 2019
@release-clerk
Copy link

release-clerk bot commented Oct 30, 2019

Release Notes Persisted

Fixed memory leaks caused by callbacks not being released when the remote module is used in sub-frames (<iframe> or scriptable popup).

@zcbenz zcbenz deleted the miniak/remote-callback-freer-7-0-x branch October 30, 2019 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nornagon nornagon nornagon approved these changes

@zcbenz zcbenz zcbenz approved these changes

Assignees

@miniak miniak

Labels
7-0-x backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@miniak @nornagon @zcbenz