Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use xib file to construct macOS Menu #20670

Merged
merged 3 commits into from Oct 22, 2019
Merged

fix: use xib file to construct macOS Menu #20670

merged 3 commits into from Oct 22, 2019

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Oct 21, 2019

Backport of #20615

See that PR for details.

Notes: Fixed a regression in the recentDocuments role on macOS.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Oct 21, 2019
@trop trop bot mentioned this pull request Oct 21, 2019
Merged
4 tasks
@trop trop bot added 7-0-x backport This is a backport PR labels Oct 21, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Oct 21, 2019
@zcbenz zcbenz merged commit d417bbd into 7-0-x Oct 22, 2019
@release-clerk
Copy link

release-clerk bot commented Oct 22, 2019

Release Notes Persisted

Fixed a regression in the recentDocuments role on macOS.

@zcbenz zcbenz deleted the trop/7-0-x-bp-fix-use-xib-file-to-construct-macos-menu-1571692312643 branch October 22, 2019 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zcbenz zcbenz zcbenz approved these changes

@codebytere codebytere codebytere approved these changes

Assignees
No one assigned
Labels
7-0-x backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zcbenz @codebytere