Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: backport libuv patch for fs.mkdir/mkdirSync on invalid names #20629

Merged
merged 1 commit into from Oct 21, 2019
Merged

fix: backport libuv patch for fs.mkdir/mkdirSync on invalid names #20629

merged 1 commit into from Oct 21, 2019

Conversation

deepak1556
Copy link
Member

@deepak1556 deepak1556 commented Oct 18, 2019 •
edited

Description of Change

Fixes #20588

Backports libuv/libuv#2375

This should be fixed in master with #20584 , hence only targeting release branches.

Checklist

Release Notes

Notes: fix fs.mkdir/mkdirSync hang with {recursive: true} for invalid names with node 12 on windows

@deepak1556 deepak1556 requested review from a team October 18, 2019 03:17
@trop trop bot mentioned this pull request Oct 18, 2019
Merged
@trop trop bot added 7-0-x backport This is a backport PR labels Oct 18, 2019
@deepak1556 deepak1556 removed the backport This is a backport PR label Oct 18, 2019
codebytere
codebytere previously approved these changes Oct 18, 2019
View reviewed changes
@codebytere codebytere dismissed their stale review October 18, 2019 05:19

meant just to comment, whoops

@codebytere
Copy link
Member

The newly-added spec seems to be failing

@deepak1556
Copy link
Member Author

It should be a windows only spec, will fix it tomorrow. Thanks!

@miniak miniak changed the title fix: backport libuv patch for fs.mkdir/mkdirSync on invlaid names fix: backport libuv patch for fs.mkdir/mkdirSync on invalid names Oct 21, 2019
@trop trop bot added the backport This is a backport PR label Oct 21, 2019
@deepak1556 deepak1556 requested a review from a team October 21, 2019 19:22
@jkleinsc jkleinsc merged commit 3b59f12 into 7-0-x Oct 21, 2019
@release-clerk
Copy link

release-clerk bot commented Oct 21, 2019

Release Notes Persisted

fix fs.mkdir/mkdirSync hang with {recursive: true} for invalid names with node 12 on windows

@jkleinsc jkleinsc deleted the robo/fix_uv_mkdir_7_x branch October 21, 2019 19:43
This was referenced Oct 21, 2019
Merged
Merged
@trop
Copy link
Contributor

trop bot commented Oct 21, 2019

I have automatically backported this PR to "5-0-x", please check out #20664

@trop trop bot removed the target/5-0-x label Oct 21, 2019
@trop
Copy link
Contributor

trop bot commented Oct 21, 2019

I have automatically backported this PR to "6-0-x", please check out #20665

@deepak1556 deepak1556 mentioned this pull request Oct 25, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkleinsc jkleinsc jkleinsc approved these changes

@zcbenz zcbenz zcbenz approved these changes

@codebytere codebytere codebytere approved these changes

Assignees
No one assigned
Labels
7-0-x backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@deepak1556 @codebytere @jkleinsc @zcbenz