Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update hasShadow to show it works on win and linux #19675

Merged
merged 1 commit into from
Aug 8, 2019
Merged

docs: update hasShadow to show it works on win and linux #19675

merged 1 commit into from
Aug 8, 2019

Conversation

codebytere
Copy link
Member

@codebytere codebytere commented Aug 7, 2019 •
edited

Description of Change

Turns out this has been implemented for quite some time. I've updated the docs for it and removed some gating on the tests so it's tested cross-platform.

cc @zcbenz @ckerr @MarshallOfSound

Checklist

Release Notes

Notes: none

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Aug 7, 2019
@codebytere codebytere changed the title docs: update hasShadow for win and linux docs: update hasShadow to show it works on win and linux Aug 7, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Aug 8, 2019
@codebytere codebytere merged commit ed3b69f into master Aug 8, 2019
@release-clerk
Copy link

release-clerk bot commented Aug 8, 2019

No Release Notes

@trop
Copy link
Contributor

trop bot commented Aug 8, 2019

I was unable to backport this PR to "5-0-x" cleanly;
you will need to perform this backport manually.

@trop
Copy link
Contributor

trop bot commented Aug 8, 2019

I was unable to backport this PR to "6-0-x" cleanly;
you will need to perform this backport manually.

@trop trop bot removed the target/5-0-x label Aug 8, 2019
@trop trop bot mentioned this pull request Aug 8, 2019
Merged
@trop
Copy link
Contributor

trop bot commented Aug 8, 2019

I have automatically backported this PR to "7-0-x", please check out #19691

@codebytere codebytere deleted the has-shadow-correction branch August 8, 2019 22:51
codebytere added a commit that referenced this pull request Aug 9, 2019
@codebytere
docs: update hasShadow for win and linux (#19675)
fcca3df
@codebytere codebytere mentioned this pull request Aug 9, 2019
Merged
@trop
Copy link
Contributor

trop bot commented Aug 9, 2019

A maintainer has manually backported this PR to "6-0-x", please check out #19692

codebytere added a commit that referenced this pull request Aug 12, 2019
@codebytere
docs: update hasShadow for win and linux (#19675) (#19692)
a8e70a8
trop bot pushed a commit that referenced this pull request Aug 12, 2019
@codebytere @electron-bot
docs: update hasShadow for win and linux (#19675)
92110d6
codebytere pushed a commit that referenced this pull request Aug 13, 2019
@trop @codebytere
docs: update hasShadow for win and linux (#19675) (#19721)
1103723
@trop trop bot mentioned this pull request Aug 19, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckerr ckerr ckerr approved these changes

@zcbenz zcbenz zcbenz approved these changes

@MarshallOfSound MarshallOfSound Awaiting requested review from MarshallOfSound

Assignees
No one assigned
Labels
documentation 📓
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@codebytere @ckerr @zcbenz