Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow multiple webRequest handlers #18301

Open
3 tasks done
sentialx opened this issue May 14, 2019 · 3 comments
Open
3 tasks done

Allow multiple webRequest handlers #18301

sentialx opened this issue May 14, 2019 · 3 comments

Comments

@sentialx
Copy link
Contributor

sentialx commented May 14, 2019

Preflight Checklist

  • I have read the Contributing Guidelines for this project.
  • I agree to follow the Code of Conduct that this project adheres to.
  • I have searched the issue tracker for a feature request that matches the one I want to file, without success.

Problem Description

There's no way to register multiple webRequest events such as onBeforeRequest

Proposed Solution

It would be great if Electron could provide normal EventEmitter object. For example:

session.webRequest.on('before-request', ...)
@eatmyvenom
Copy link

Really this would take a while for it to become a thing, you could probably just create a new event emitter object that calls all of the web request methods you want. That is until this gets added.

@sentialx
Copy link
Contributor Author

This issue may be resolved for me by #19447 when chrome.webRequest will be implemented

@jordansissel
Copy link

I ran into this tonight. It would be lovely to have this behavior documented. Today's my first day with electron and I'm not sure yet where the docs live, so this seemed a good place to mention docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants