Hard crash when using webRequest handlers in 1.8.1

[Thomas101]

• Electron version: 1.8.1. Not present 1.7.x
• Operating system: macOS 10.12.6

This may be related to #10651, the final error looks similar but the reproduction method is completely different

Expected behavior

Electron should not crash after adding a webRequest handler such as...

mainWindow.webContents.session.webRequest.onCompleted((evt) => console.log('complete', evt.url))

Actual behavior

On certain urls (https://mail.google.com as an example), adding an onCompleted, onBeforeRequest, etc handler, and then reloading or navigating away from the page causes a hard crash producing an EXC_BAD_ACCESS error

Full crash log

How to reproduce

1. Install quick-start

git clone https://github.com/wavebox/electron-quick-start.git
cd electron-quick-start
git checkout 1_8_1_crash
npm install
npm start

2. Login to a google account
3. Reload with cmd+R

Removing the onCompleted handler in main.js stops the crash

[qazbnm456]

Hi @Thomas101 , fyi, this problem has been addressed and resolved in #10676, and I believe this situation will be remediated when the next version of electron comes out.

By the way, I think the root cause is not the same as #10651 actually.

[Thomas101]

@qazbnm456 thanks for the update! If it's fixed, I'll close this off and look forward to 1.8.2 :)

[qazbnm456]

@Thomas101 FYI, the version 1.8.2-beta.1 just released. You may try it and see if it works well. 😄