From f8ef3707dffc938fd81d0c5ad216420a45c03e08 Mon Sep 17 00:00:00 2001 From: Pedro Pontes Date: Wed, 21 Jul 2021 17:39:14 +0200 Subject: [PATCH] chore: cherry-pick 3feda0244490 from chromium --- patches/chromium/.patches | 1 + .../chromium/cherry-pick-3feda0244490.patch | 36 +++++++++++++++++++ 2 files changed, 37 insertions(+) create mode 100644 patches/chromium/cherry-pick-3feda0244490.patch diff --git a/patches/chromium/.patches b/patches/chromium/.patches index 3cfee904e625e..357c88b43e403 100644 --- a/patches/chromium/.patches +++ b/patches/chromium/.patches @@ -175,3 +175,4 @@ cherry-pick-b77b38a3380c.patch cherry-pick-d9556a80a790.patch cherry-pick-910e9e40d376.patch cherry-pick-ff0d013f60fa.patch +cherry-pick-3feda0244490.patch diff --git a/patches/chromium/cherry-pick-3feda0244490.patch b/patches/chromium/cherry-pick-3feda0244490.patch new file mode 100644 index 0000000000000..619fe129e0fb4 --- /dev/null +++ b/patches/chromium/cherry-pick-3feda0244490.patch @@ -0,0 +1,36 @@ +From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001 +From: Reilly Grant +Date: Mon, 28 Jun 2021 21:55:24 +0000 +Subject: serial: Fix parent class tracing for SerialPort + +When SerialPort was updated to be ActiveScriptWrappable and an +EventTarget the Trace method was not updated to call the parent class +trace methods. + +(cherry picked from commit 4059ecc3a5352601a4d79196f90c8ca19262afe1) + +Bug: 1220078 +Change-Id: If6967a913268bce86d4488359a9418a814530f84 +Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2965255 +Auto-Submit: Reilly Grant +Commit-Queue: Tom Sepez +Reviewed-by: Tom Sepez +Cr-Original-Commit-Position: refs/heads/master@{#893039} +Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2992740 +Bot-Commit: Rubber Stamper +Commit-Queue: Reilly Grant +Cr-Commit-Position: refs/branch-heads/4472@{#1531} +Cr-Branched-From: 3d60439cfb36485e76a1c5bb7f513d3721b20da1-refs/heads/master@{#870763} + +diff --git a/third_party/blink/renderer/modules/serial/serial_port.cc b/third_party/blink/renderer/modules/serial/serial_port.cc +index 989104ef12774896c254812fff804eaafc5b2e6c..ee3c26a0a711751de93e3bc2ed457b54a84d430d 100644 +--- a/third_party/blink/renderer/modules/serial/serial_port.cc ++++ b/third_party/blink/renderer/modules/serial/serial_port.cc +@@ -492,6 +492,7 @@ void SerialPort::Trace(Visitor* visitor) const { + visitor->Trace(signal_resolvers_); + visitor->Trace(close_resolver_); + ScriptWrappable::Trace(visitor); ++ ActiveScriptWrappable::Trace(visitor); + } + + ExecutionContext* SerialPort::GetExecutionContext() const {