From e9427e7b9204342945cbdccd0fb7b589b7e170a2 Mon Sep 17 00:00:00 2001 From: "trop[bot]" <37223003+trop[bot]@users.noreply.github.com> Date: Mon, 8 Jun 2020 10:55:39 -0500 Subject: [PATCH] fix: add missing isComposing KeyboardEvent property (#23996) Co-authored-by: Shelley Vohr --- docs/api/web-contents.md | 1 + shell/common/gin_converters/content_converter.cc | 1 + 2 files changed, 2 insertions(+) diff --git a/docs/api/web-contents.md b/docs/api/web-contents.md index b4f8fe66e214b..9662d75d13c91 100644 --- a/docs/api/web-contents.md +++ b/docs/api/web-contents.md @@ -366,6 +366,7 @@ Returns: * `key` String - Equivalent to [KeyboardEvent.key][keyboardevent]. * `code` String - Equivalent to [KeyboardEvent.code][keyboardevent]. * `isAutoRepeat` Boolean - Equivalent to [KeyboardEvent.repeat][keyboardevent]. + * `isComposing` Boolean - Equivalent to [KeyboardEvent.isComposing][keyboardevent]. * `shift` Boolean - Equivalent to [KeyboardEvent.shiftKey][keyboardevent]. * `control` Boolean - Equivalent to [KeyboardEvent.controlKey][keyboardevent]. * `alt` Boolean - Equivalent to [KeyboardEvent.altKey][keyboardevent]. diff --git a/shell/common/gin_converters/content_converter.cc b/shell/common/gin_converters/content_converter.cc index 3d3cc0489f643..489ad9ad8295f 100644 --- a/shell/common/gin_converters/content_converter.cc +++ b/shell/common/gin_converters/content_converter.cc @@ -302,6 +302,7 @@ v8::Local Converter::ToV8( using Modifiers = blink::WebInputEvent::Modifiers; dict.Set("isAutoRepeat", (in.GetModifiers() & Modifiers::kIsAutoRepeat) != 0); + dict.Set("isComposing", (in.GetModifiers() & Modifiers::kIsComposing) != 0); dict.Set("shift", (in.GetModifiers() & Modifiers::kShiftKey) != 0); dict.Set("control", (in.GetModifiers() & Modifiers::kControlKey) != 0); dict.Set("alt", (in.GetModifiers() & Modifiers::kAltKey) != 0);