From b9ac334efc410d11fe57ef5ab6e511f194115e3a Mon Sep 17 00:00:00 2001 From: Shelley Vohr Date: Fri, 12 Jun 2020 22:18:09 -0700 Subject: [PATCH] fix: showing certificate dialog with no window (#24091) --- lib/browser/api/dialog.js | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/lib/browser/api/dialog.js b/lib/browser/api/dialog.js index 24285704843af..5d5b96979874c 100644 --- a/lib/browser/api/dialog.js +++ b/lib/browser/api/dialog.js @@ -249,7 +249,11 @@ module.exports = { }, showCertificateTrustDialog: function (window, options) { - if (window && window.constructor !== BrowserWindow) options = window; + if (window && window.constructor !== BrowserWindow) { + options = window; + window = null; + } + if (options == null || typeof options !== 'object') { throw new TypeError('options must be an object'); }