From 7761ea67135754e8c9edceff45f2dffb03c729ef Mon Sep 17 00:00:00 2001 From: "trop[bot]" <37223003+trop[bot]@users.noreply.github.com> Date: Tue, 29 Mar 2022 11:40:05 -0400 Subject: [PATCH] fix: crash when WindowButtonsProxy references cleared NSWindow (#33489) * resets WindowButtonsProxy on window delete on macOS * fixes reset Co-authored-by: Gellert Hegyi --- shell/browser/native_window_mac.mm | 2 ++ 1 file changed, 2 insertions(+) diff --git a/shell/browser/native_window_mac.mm b/shell/browser/native_window_mac.mm index 7574bb6cb52a6..97dc4a7e3433e 100644 --- a/shell/browser/native_window_mac.mm +++ b/shell/browser/native_window_mac.mm @@ -328,6 +328,8 @@ void ViewDidMoveToSuperview(NSView* self, SEL _cmd) { [](NativeWindowMac* window) { if (window->window_) window->window_ = nil; + if (window->buttons_proxy_) + window->buttons_proxy_.reset(); }, this));