From 49e62f1261d289500e5e85973fb4962fea3f7cab Mon Sep 17 00:00:00 2001 From: "electron-roller[bot]" <84116207+electron-roller[bot]@users.noreply.github.com> Date: Wed, 1 Sep 2021 15:55:07 -0400 Subject: [PATCH] chore: bump chromium to 95.0.4629.0 (main) (#30676) * chore: bump chromium in DEPS to 95.0.4620.0 * chore: update patches * 3076261: Move args_ to private in ExtensionFunction https://chromium-review.googlesource.com/c/chromium/src/+/3076261 * [GURL -> SiteForCookies] content/public/browser/content_browser_client.h https://chromium-review.googlesource.com/c/chromium/src/+/3107759 * chore: fix -Wunreachable-code-return in node * Tracing to diagnose ContentScriptTracker-related bad message reports https://chromium-review.googlesource.com/c/chromium/src/+/3057922 * chore: bump chromium in DEPS to 95.0.4621.0 * chore: update patches * Remove title from the URL format on Windows. https://chromium-review.googlesource.com/c/chromium/src/+/3108445 * chore: bump chromium in DEPS to 95.0.4623.0 * Revert "chore: disable v8 oilpan" This reverts commit 5d255cf1d8e8efbb906047937a713279e5f800d0. (cherry picked from commit ba5cde4da2428020d99b7fb603c702878f95da78) * Change file paths in network context params to be relative. https://chromium-review.googlesource.com/c/chromium/src/+/3092927 * Code Health: Rename/replace content::WebUI::RegisterMessageCallback(). https://chromium-review.googlesource.com/c/chromium/src/+/3104691 * Migrate CanExecuteContentScriptSync to Mojo https://chromium-review.googlesource.com/c/chromium/src/+/3108452 * chore: update patches * remove unreachable code * Revert "Revert "chore: disable v8 oilpan"" This reverts commit fef495c0294e21760df51bddb5f7bf1ec9ed5f1e. * fixup mas patch * Reland "[include] Split out v8.h" https://chromium-review.googlesource.com/c/v8/v8/+/3113629 * chore: bump chromium in DEPS to 95.0.4624.0 * chore: bump chromium in DEPS to 95.0.4625.0 * chore: bump chromium in DEPS to 95.0.4626.0 * 3033504: Pass NavigationDownloadPolicy in CreateNewWindowParams https://chromium-review.googlesource.com/c/chromium/src/+/3033504 * 3058038: Introduce TestPrintingContext & test UpdatePrintSettings https://chromium-review.googlesource.com/c/chromium/src/+/3058038 * 3114943: [Conditional Focus][#4] Add tests and remove flag gating https://chromium-review.googlesource.com/c/chromium/src/+/3114943 * chore: update patch indices * chore: bump chromium in DEPS to 95.0.4627.0 * chore: update patches * 3093591: ozone: webpagepopups: calculate anchor for menu bounds. 4/* https://chromium-review.googlesource.com/c/chromium/src/+/3093591 * 3110414: [PA] Remove the leading cookie https://chromium-review.googlesource.com/c/chromium/src/+/3110414 * chore: update patches * 3076261: Move args_ to private in ExtensionFunction https://chromium-review.googlesource.com/c/chromium/src/+/3076261 * 3113629: Reland "[include] Split out v8.h" https://chromium-review.googlesource.com/c/v8/v8/+/3113629 * chore: bump chromium in DEPS to 95.0.4628.0 * chore: update patches * chore: bump chromium in DEPS to 95.0.4629.0 * chore: update patches * Fix chrome root store codegen for cross-compile builds. https://chromium-review.googlesource.com/c/chromium/src/+/3133701 Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: John Kleinschmidt Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com> Co-authored-by: deepak1556 Co-authored-by: Shelley Vohr --- DEPS | 2 +- docs/api/clipboard.md | 6 +- patches/chromium/.patches | 3 +- .../add_didinstallconditionalfeatures.patch | 26 +- ..._scheduler_throttling_per_renderview.patch | 6 +- patches/chromium/blink_local_frame.patch | 2 +- .../build_add_electron_tracing_category.patch | 2 +- ..._depend_on_packed_resource_integrity.patch | 20 +- patches/chromium/can_create_window.patch | 42 +- ...screationoverridden_with_full_params.patch | 22 +- ...esources_not_chrome_for_spellchecker.patch | 4 +- patches/chromium/dcheck.patch | 4 +- ...ay_lock_the_protocol_scheme_registry.patch | 2 +- patches/chromium/disable-redraw-lock.patch | 2 +- .../disable_color_correct_rendering.patch | 20 +- .../disable_compositor_recycling.patch | 4 +- patches/chromium/disable_hidden.patch | 10 +- patches/chromium/disable_unload_metrics.patch | 6 +- .../chromium/disable_use_lld_for_macos.patch | 21 - ...ll_getwebframe_-_view_when_get_blink.patch | 4 +- patches/chromium/dump_syms.patch | 4 +- .../chromium/enable_reset_aspect_ratio.patch | 4 +- ...locator_for_usage_outside_of_the_gin.patch | 4 +- ...xpose_setuseragent_on_networkcontext.patch | 16 +- ...screen_rendering_with_viz_compositor.patch | 2 +- ..._raw_response_headers_from_urlloader.patch | 2 +- ...ore_codegen_for_cross-compile_builds.patch | 101 +++ ...ntcapturercount_in_web_contents_impl.patch | 4 +- ...out_profile_refs_in_accessibility_ui.patch | 2 +- ..._properly_honor_printing_page_ranges.patch | 6 +- ...fix_use_electron_generated_resources.patch | 16 +- patches/chromium/frame_host_manager.patch | 8 +- .../gin_enable_disable_v8_platform.patch | 18 +- .../chromium/gritsettings_resource_ids.patch | 4 +- ...sync_with_host_os_mac_on_linux_in_ci.patch | 2 +- patches/chromium/isolate_holder.patch | 10 +- .../mas_disable_remote_accessibility.patch | 34 +- .../chromium/mas_disable_remote_layer.patch | 6 +- patches/chromium/mas_no_private_api.patch | 124 ++-- ...emote_certificate_verification_logic.patch | 26 +- .../chromium/notification_provenance.patch | 4 +- patches/chromium/pepper_plugin_support.patch | 2 +- patches/chromium/printing.patch | 28 +- ...r_changes_to_the_webcontentsobserver.patch | 12 +- .../render_widget_host_view_base.patch | 10 +- patches/chromium/resource_file_conflict.patch | 6 +- ...ang_llvmorg-14-init-1002-gb5e470aa-1.patch | 21 - patches/chromium/scroll_bounce_flag.patch | 2 +- .../support_mixed_sandbox_with_zygote.patch | 10 +- patches/chromium/web_contents.patch | 6 +- patches/chromium/webview_fullscreen.patch | 6 +- .../worker_context_will_destroy.patch | 16 +- ...feat_add_hook_to_notify_script_ready.patch | 20 +- patches/node/build_add_gn_build_files.patch | 120 ++- .../node/fix_-wunreachable-code-return.patch | 12 + patches/v8/.patches | 1 - patches/v8/build_gn.patch | 8 +- patches/v8/dcheck.patch | 8 +- ...export_private_v8_symbols_on_windows.patch | 4 +- ...ort_symbols_needed_for_windows_build.patch | 8 +- patches/v8/expose_mksnapshot.patch | 4 +- ...ssive_warnings_in_arm_and_arm64_code.patch | 700 ------------------ shell/browser/electron_browser_client.cc | 2 +- shell/browser/electron_browser_client.h | 2 +- .../cryptotoken_private_api.cc | 10 +- .../resources_private_api.cc | 2 +- shell/browser/javascript_environment.cc | 2 +- shell/browser/javascript_environment.h | 1 + shell/browser/net/network_context_service.cc | 14 +- .../osr/osr_render_widget_host_view.cc | 3 +- .../browser/osr/osr_render_widget_host_view.h | 3 +- shell/browser/ui/gtk/status_icon.cc | 1 - shell/browser/ui/webui/accessibility_ui.cc | 10 +- shell/common/gin_converters/time_converter.cc | 1 + shell/common/gin_helper/arguments.cc | 1 + shell/renderer/renderer_client_base.cc | 1 - spec/api-clipboard-spec.js | 16 +- 77 files changed, 588 insertions(+), 1090 deletions(-) delete mode 100644 patches/chromium/disable_use_lld_for_macos.patch create mode 100644 patches/chromium/fix_chrome_root_store_codegen_for_cross-compile_builds.patch delete mode 100644 patches/chromium/revert_roll_clang_llvmorg-14-init-1002-gb5e470aa-1.patch delete mode 100644 patches/v8/fix_-wunreachable-code-aggressive_warnings_in_arm_and_arm64_code.patch diff --git a/DEPS b/DEPS index fb693b6529f0b..5e50580754bac 100644 --- a/DEPS +++ b/DEPS @@ -15,7 +15,7 @@ gclient_gn_args = [ vars = { 'chromium_version': - '95.0.4612.5', + '95.0.4629.0', 'node_version': 'v16.8.0', 'nan_version': diff --git a/docs/api/clipboard.md b/docs/api/clipboard.md index 5bde8df21bf00..6b742d59db21b 100644 --- a/docs/api/clipboard.md +++ b/docs/api/clipboard.md @@ -131,15 +131,15 @@ Returns `Object`: Returns an Object containing `title` and `url` keys representing the bookmark in the clipboard. The `title` and `url` values will be empty strings when the -bookmark is unavailable. +bookmark is unavailable. The `title` value will always be empty on Windows. ### `clipboard.writeBookmark(title, url[, type])` _macOS_ _Windows_ -* `title` String +* `title` String - Unused on Windows * `url` String * `type` String (optional) - Can be `selection` or `clipboard`; default is 'clipboard'. `selection` is only available on Linux. -Writes the `title` and `url` into the clipboard as a bookmark. +Writes the `title` (macOS only) and `url` into the clipboard as a bookmark. **Note:** Most apps on Windows don't support pasting bookmarks into them so you can use `clipboard.write` to write both a bookmark and fallback text to the diff --git a/patches/chromium/.patches b/patches/chromium/.patches index d7134ea4fac8c..016b1facbd89e 100644 --- a/patches/chromium/.patches +++ b/patches/chromium/.patches @@ -103,8 +103,7 @@ hack_to_allow_gclient_sync_with_host_os_mac_on_linux_in_ci.patch don_t_run_pcscan_notifythreadcreated_if_pcscan_is_disabled.patch add_gin_wrappable_crash_key.patch logging_win32_only_create_a_console_if_logging_to_stderr.patch -disable_use_lld_for_macos.patch fix_media_key_usage_with_globalshortcuts.patch feat_expose_raw_response_headers_from_urlloader.patch -revert_roll_clang_llvmorg-14-init-1002-gb5e470aa-1.patch chore_do_not_use_chrome_windows_in_cryptotoken_webrequestsender.patch +fix_chrome_root_store_codegen_for_cross-compile_builds.patch diff --git a/patches/chromium/add_didinstallconditionalfeatures.patch b/patches/chromium/add_didinstallconditionalfeatures.patch index 9f549bbd08491..8a6debd1add1e 100644 --- a/patches/chromium/add_didinstallconditionalfeatures.patch +++ b/patches/chromium/add_didinstallconditionalfeatures.patch @@ -10,7 +10,7 @@ DidCreateScriptContext is called, not all JS APIs are available in the context, which can cause some preload scripts to trip. diff --git a/content/public/renderer/render_frame_observer.h b/content/public/renderer/render_frame_observer.h -index e24c169444c699f295de2c1f1f42683eeca73436..4675cdccb1876a318a9a0253cdf552bb65516310 100644 +index 794a89ded73c415403d0d590780869c8d8b4ae38..5eb76debe9804a5195747cb6b90707fd0a242ec6 100644 --- a/content/public/renderer/render_frame_observer.h +++ b/content/public/renderer/render_frame_observer.h @@ -127,6 +127,8 @@ class CONTENT_EXPORT RenderFrameObserver : public IPC::Listener, @@ -23,10 +23,10 @@ index e24c169444c699f295de2c1f1f42683eeca73436..4675cdccb1876a318a9a0253cdf552bb int32_t world_id) {} virtual void DidClearWindowObject() {} diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc -index da75e85c94b1dba16c423066940cf27c90c1081c..7884866e2358f78a994dd784f187fdb8bd592bad 100644 +index 173952d4545d59ecb1b99aa07b6c8f8bcd1b2e86..395bb615c0a2d5a49cfbc6d8a9e9f3d9a809b595 100644 --- a/content/renderer/render_frame_impl.cc +++ b/content/renderer/render_frame_impl.cc -@@ -4446,6 +4446,12 @@ void RenderFrameImpl::DidCreateScriptContext(v8::Local context, +@@ -4461,6 +4461,12 @@ void RenderFrameImpl::DidCreateScriptContext(v8::Local context, observer.DidCreateScriptContext(context, world_id); } @@ -40,10 +40,10 @@ index da75e85c94b1dba16c423066940cf27c90c1081c..7884866e2358f78a994dd784f187fdb8 int world_id) { for (auto& observer : observers_) diff --git a/content/renderer/render_frame_impl.h b/content/renderer/render_frame_impl.h -index a2577aefe0f7121daa46765014fd94cc9c5264b9..302aeb4257105b04cb8ca4ce484354021757ee8d 100644 +index 4cd3901203e5399fb5a2855fca98e083fe0973d1..b11cb66d157023d36113f28399d57ff2b2f10abb 100644 --- a/content/renderer/render_frame_impl.h +++ b/content/renderer/render_frame_impl.h -@@ -588,6 +588,8 @@ class CONTENT_EXPORT RenderFrameImpl +@@ -593,6 +593,8 @@ class CONTENT_EXPORT RenderFrameImpl blink::WebLocalFrameClient::LazyLoadBehavior lazy_load_behavior) override; void DidCreateScriptContext(v8::Local context, int world_id) override; @@ -53,10 +53,10 @@ index a2577aefe0f7121daa46765014fd94cc9c5264b9..302aeb4257105b04cb8ca4ce48435402 int world_id) override; void DidChangeScrollOffset() override; diff --git a/third_party/blink/public/web/web_local_frame_client.h b/third_party/blink/public/web/web_local_frame_client.h -index 99ddb8f449481647a499a5bb3fd7f5d5272ae414..00d7f0bbb8dc3afdc2303668481cf17fbdfbdcba 100644 +index 0ccf54bd50144bc890c96651978f54b0d33713b6..de26aa9f319bd0c762b96f729ccf25a72dd90eb3 100644 --- a/third_party/blink/public/web/web_local_frame_client.h +++ b/third_party/blink/public/web/web_local_frame_client.h -@@ -587,6 +587,9 @@ class BLINK_EXPORT WebLocalFrameClient { +@@ -589,6 +589,9 @@ class BLINK_EXPORT WebLocalFrameClient { virtual void DidCreateScriptContext(v8::Local, int32_t world_id) {} @@ -79,10 +79,10 @@ index b0d5db60fbe57275dda835113b0fb21acb9a422f..b6c9c389943088004a419677a2a17be0 if (World().IsMainWorld()) { GetFrame()->Loader().DispatchDidClearWindowObjectInMainWorld(); diff --git a/third_party/blink/renderer/core/frame/local_frame_client.h b/third_party/blink/renderer/core/frame/local_frame_client.h -index 8d7a0e9445d7817441f02b4def1777020d35618f..6f0f79b2766ee8f42815c15744ccfc2a75976b0b 100644 +index 727b770b33f209288904cc10f486ab25f82b4cd6..b25c945378a01ac918ff6dc6caf69effde3685e6 100644 --- a/third_party/blink/renderer/core/frame/local_frame_client.h +++ b/third_party/blink/renderer/core/frame/local_frame_client.h -@@ -300,6 +300,8 @@ class CORE_EXPORT LocalFrameClient : public FrameClient { +@@ -303,6 +303,8 @@ class CORE_EXPORT LocalFrameClient : public FrameClient { virtual void DidCreateScriptContext(v8::Local, int32_t world_id) = 0; @@ -92,7 +92,7 @@ index 8d7a0e9445d7817441f02b4def1777020d35618f..6f0f79b2766ee8f42815c15744ccfc2a int32_t world_id) = 0; virtual bool AllowScriptExtensions() = 0; diff --git a/third_party/blink/renderer/core/frame/local_frame_client_impl.cc b/third_party/blink/renderer/core/frame/local_frame_client_impl.cc -index 94e332a2da9522e83ce55d8b7ce303a383e37d05..a3fa8d72ffb450f502de161a8875a81d72c075e8 100644 +index ba855e42e395f1ba1838400f08827a5bdc19d90f..c74031e118ffb7ff6312c33f99a6ff9d67b5bf19 100644 --- a/third_party/blink/renderer/core/frame/local_frame_client_impl.cc +++ b/third_party/blink/renderer/core/frame/local_frame_client_impl.cc @@ -273,6 +273,13 @@ void LocalFrameClientImpl::DidCreateScriptContext( @@ -110,7 +110,7 @@ index 94e332a2da9522e83ce55d8b7ce303a383e37d05..a3fa8d72ffb450f502de161a8875a81d v8::Local context, int32_t world_id) { diff --git a/third_party/blink/renderer/core/frame/local_frame_client_impl.h b/third_party/blink/renderer/core/frame/local_frame_client_impl.h -index 0d7ecf011c802f8c4d874815e345b16ac3a0b5dc..572968b7f6495ee544cdf265aa9b7f6728c74cc9 100644 +index 57c9b6b733ebf5b9483d31959fbdccad8b72031c..13c7e6924a19717473379045ae1c1f0e6f6d52cf 100644 --- a/third_party/blink/renderer/core/frame/local_frame_client_impl.h +++ b/third_party/blink/renderer/core/frame/local_frame_client_impl.h @@ -77,6 +77,8 @@ class CORE_EXPORT LocalFrameClientImpl final : public LocalFrameClient { @@ -123,10 +123,10 @@ index 0d7ecf011c802f8c4d874815e345b16ac3a0b5dc..572968b7f6495ee544cdf265aa9b7f67 int32_t world_id) override; diff --git a/third_party/blink/renderer/core/loader/empty_clients.h b/third_party/blink/renderer/core/loader/empty_clients.h -index ec4dfeb2d6fd5206c1d6d697a36d5d78899023cb..7b978f119d3321416dffcc2dea266403dd86f2b6 100644 +index 65356d0acdc5868cce8401ed88b90d75c6306f28..338ebba74360e09bfc93c5be943ab828d22b500b 100644 --- a/third_party/blink/renderer/core/loader/empty_clients.h +++ b/third_party/blink/renderer/core/loader/empty_clients.h -@@ -356,6 +356,8 @@ class CORE_EXPORT EmptyLocalFrameClient : public LocalFrameClient { +@@ -359,6 +359,8 @@ class CORE_EXPORT EmptyLocalFrameClient : public LocalFrameClient { void DidCreateScriptContext(v8::Local, int32_t world_id) override {} diff --git a/patches/chromium/allow_disabling_blink_scheduler_throttling_per_renderview.patch b/patches/chromium/allow_disabling_blink_scheduler_throttling_per_renderview.patch index 0d7914bbac29d..50900cd0a86bb 100644 --- a/patches/chromium/allow_disabling_blink_scheduler_throttling_per_renderview.patch +++ b/patches/chromium/allow_disabling_blink_scheduler_throttling_per_renderview.patch @@ -113,10 +113,10 @@ index 7995eb16a7cf6a824653736ca067baa5e688834f..c26e087f2f4d7a1446ce439e5a08a34a mojom::blink::PageVisibilityState WebViewImpl::GetVisibilityState() { diff --git a/third_party/blink/renderer/core/exported/web_view_impl.h b/third_party/blink/renderer/core/exported/web_view_impl.h -index e7b0409bd60df8c1476f0c9ce14380bfade9773d..3a955aa7fcf08a7d7222eca37222870c6ec8fe36 100644 +index 293e146acb0257a80d41eecf0794b7f08aa0ffc4..c1c88c9349d3882f3896fa1ed715433d9cf19429 100644 --- a/third_party/blink/renderer/core/exported/web_view_impl.h +++ b/third_party/blink/renderer/core/exported/web_view_impl.h -@@ -416,6 +416,7 @@ class CORE_EXPORT WebViewImpl final : public WebView, +@@ -417,6 +417,7 @@ class CORE_EXPORT WebViewImpl final : public WebView, LocalDOMWindow* PagePopupWindow() const; PageScheduler* Scheduler() const override; @@ -124,7 +124,7 @@ index e7b0409bd60df8c1476f0c9ce14380bfade9773d..3a955aa7fcf08a7d7222eca37222870c void SetVisibilityState(mojom::blink::PageVisibilityState visibility_state, bool is_initial_state) override; mojom::blink::PageVisibilityState GetVisibilityState() override; -@@ -847,6 +848,8 @@ class CORE_EXPORT WebViewImpl final : public WebView, +@@ -848,6 +849,8 @@ class CORE_EXPORT WebViewImpl final : public WebView, // If true, we send IPC messages when |preferred_size_| changes. bool send_preferred_size_changes_ = false; diff --git a/patches/chromium/blink_local_frame.patch b/patches/chromium/blink_local_frame.patch index 0fba56f7c8c9e..379e9c71bfc8a 100644 --- a/patches/chromium/blink_local_frame.patch +++ b/patches/chromium/blink_local_frame.patch @@ -49,7 +49,7 @@ index 8bf6b4bc077cc41da5e0e6b13302bc343537c68f..01bddc0bcb7476408023c4cfc042a088 // its owning reference back to our owning LocalFrame. client_->Detached(type); diff --git a/third_party/blink/renderer/core/frame/local_frame.cc b/third_party/blink/renderer/core/frame/local_frame.cc -index a9c4d4efe4d66a152c02c7d6029d8c7e3740ebfb..cce1fc3bc9d7779215cd3536553e09078c8d9680 100644 +index cf505929c9f6eac724a22e5abcd362ed70aed710..b49500d62fb29f179ae802366108c84e2f891836 100644 --- a/third_party/blink/renderer/core/frame/local_frame.cc +++ b/third_party/blink/renderer/core/frame/local_frame.cc @@ -553,10 +553,6 @@ bool LocalFrame::DetachImpl(FrameDetachType type) { diff --git a/patches/chromium/build_add_electron_tracing_category.patch b/patches/chromium/build_add_electron_tracing_category.patch index c9e46a7e8760e..fc0724439af53 100644 --- a/patches/chromium/build_add_electron_tracing_category.patch +++ b/patches/chromium/build_add_electron_tracing_category.patch @@ -8,7 +8,7 @@ categories in use are known / declared. This patch is required for us to introduce a new Electron category for Electron-specific tracing. diff --git a/base/trace_event/builtin_categories.h b/base/trace_event/builtin_categories.h -index 81dea0e4a02ae26b2b55e6839202d6864a120d45..5174db10126c9cb81dc422bdac9ba18e498debe8 100644 +index efa8e6578dbdda31a9cfafe680d03c809617f84c..46affd2c438a5108440848943fb20efe070e6ed0 100644 --- a/base/trace_event/builtin_categories.h +++ b/base/trace_event/builtin_categories.h @@ -77,6 +77,7 @@ diff --git a/patches/chromium/build_do_not_depend_on_packed_resource_integrity.patch b/patches/chromium/build_do_not_depend_on_packed_resource_integrity.patch index ded08ddd58ca7..ec6fa30045523 100644 --- a/patches/chromium/build_do_not_depend_on_packed_resource_integrity.patch +++ b/patches/chromium/build_do_not_depend_on_packed_resource_integrity.patch @@ -11,7 +11,7 @@ if we ever align our .pak file generation with Chrome we can remove this patch. diff --git a/chrome/BUILD.gn b/chrome/BUILD.gn -index d4436b93723cac8b33a6ffab1437b221446a1fb0..3aef47b5f85c11845962e48efd75a1d5064b7412 100644 +index 897e473cbb4c3e8b244210706e4e1549b1e71a0c..cde17f7fee3851e96afc181c92121867c97a0f95 100644 --- a/chrome/BUILD.gn +++ b/chrome/BUILD.gn @@ -165,11 +165,16 @@ if (!is_android && !is_mac) { @@ -33,10 +33,10 @@ index d4436b93723cac8b33a6ffab1437b221446a1fb0..3aef47b5f85c11845962e48efd75a1d5 "//base", "//build:branding_buildflags", diff --git a/chrome/browser/BUILD.gn b/chrome/browser/BUILD.gn -index 74f816aef514eef1263d9b2c25cf3a52359860a6..a9cb81f06f1a4ef57e90190b9dde01df5dc67124 100644 +index 3acfeb5e5bf721fabe2339e389193cd9e154e293..9cdea4ca822f74cf7398d3f474bcc5ccfd43f829 100644 --- a/chrome/browser/BUILD.gn +++ b/chrome/browser/BUILD.gn -@@ -4367,7 +4367,7 @@ static_library("browser") { +@@ -4398,7 +4398,7 @@ static_library("browser") { # On Windows, the hashes are embedded in //chrome:chrome_initial rather # than here in :chrome_dll. @@ -46,10 +46,10 @@ index 74f816aef514eef1263d9b2c25cf3a52359860a6..a9cb81f06f1a4ef57e90190b9dde01df } diff --git a/chrome/test/BUILD.gn b/chrome/test/BUILD.gn -index c506774eef1725c67f6b56abe36f5541ef940cd0..4585132bb6b2d35560d851940ef0d71441fda6a9 100644 +index f8eeccc044eebd0c7f1a845ff29c7e46acf83252..d81d15061a88a7e38d7ee46ca7b0f6fcbe994961 100644 --- a/chrome/test/BUILD.gn +++ b/chrome/test/BUILD.gn -@@ -5328,7 +5328,6 @@ test("unit_tests") { +@@ -5353,7 +5353,6 @@ test("unit_tests") { assert(toolkit_views) sources += [ "../browser/ui/startup/credential_provider_signin_info_fetcher_win_unittest.cc" ] deps += [ @@ -57,7 +57,7 @@ index c506774eef1725c67f6b56abe36f5541ef940cd0..4585132bb6b2d35560d851940ef0d714 "//chrome/browser:chrome_process_finder", "//chrome/browser/safe_browsing/chrome_cleaner", "//chrome/browser/safe_browsing/chrome_cleaner:public", -@@ -5341,6 +5340,12 @@ test("unit_tests") { +@@ -5366,6 +5365,12 @@ test("unit_tests") { "//components/chrome_cleaner/public/proto", "//ui/events/devices:test_support", ] @@ -70,17 +70,17 @@ index c506774eef1725c67f6b56abe36f5541ef940cd0..4585132bb6b2d35560d851940ef0d714 } # TODO(crbug.com/931218): Ninja cannot handle certain characters appearing -@@ -5933,7 +5938,6 @@ test("unit_tests") { +@@ -5953,7 +5958,6 @@ test("unit_tests") { } deps += [ - "//chrome:packed_resources_integrity_hash", "//chrome/browser:cart_db_content_proto", "//chrome/browser/media/router:test_support", - "//chrome/browser/promo_browser_command:mojo_bindings", -@@ -5969,6 +5973,9 @@ test("unit_tests") { - "//ui/color:test_support", + "//chrome/browser/resource_coordinator:intervention_policy_database_proto", +@@ -5989,6 +5993,9 @@ test("unit_tests") { "//ui/native_theme:test_support", + "//ui/webui/resources/js/browser_command:mojo_bindings", ] + if (!is_electron_build) { + deps += [ "//chrome:packed_resources_integrity_hash" ] diff --git a/patches/chromium/can_create_window.patch b/patches/chromium/can_create_window.patch index b68db1cd791a0..4f689cf618769 100644 --- a/patches/chromium/can_create_window.patch +++ b/patches/chromium/can_create_window.patch @@ -9,10 +9,10 @@ potentially prevent a window from being created. TODO(loc): this patch is currently broken. diff --git a/content/browser/renderer_host/render_frame_host_impl.cc b/content/browser/renderer_host/render_frame_host_impl.cc -index ac98459fd07c4daee384c50e2ac4b19da14ccaf6..b5f7104ffde611652c55ebe85e3969394dbf76fc 100644 +index befd11fbac2068e6ac303989528ee609263ae9b2..ea22c655ae4e5c1e023d68fbedb2a684edabe1fe 100644 --- a/content/browser/renderer_host/render_frame_host_impl.cc +++ b/content/browser/renderer_host/render_frame_host_impl.cc -@@ -6348,6 +6348,7 @@ void RenderFrameHostImpl::CreateNewWindow( +@@ -6406,6 +6406,7 @@ void RenderFrameHostImpl::CreateNewWindow( last_committed_origin_, params->window_container_type, params->target_url, params->referrer.To(), params->frame_name, params->disposition, *params->features, @@ -21,10 +21,10 @@ index ac98459fd07c4daee384c50e2ac4b19da14ccaf6..b5f7104ffde611652c55ebe85e396939 &no_javascript_access); diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc -index 6f0d2cee13b39ef0fb60ceec0bbf25f17f8b1152..183fa12d38d28f3de40bdd9f26155388658e8ffe 100644 +index afee3ed1f21aa9b95e2dc48191445d0f18049bbb..0ba0990cf02624cc7cf1b304a0d9b63692cd464d 100644 --- a/content/browser/web_contents/web_contents_impl.cc +++ b/content/browser/web_contents/web_contents_impl.cc -@@ -3727,6 +3727,14 @@ FrameTree* WebContentsImpl::CreateNewWindow( +@@ -3739,6 +3739,14 @@ FrameTree* WebContentsImpl::CreateNewWindow( } auto* new_contents_impl = new_contents.get(); @@ -39,7 +39,7 @@ index 6f0d2cee13b39ef0fb60ceec0bbf25f17f8b1152..183fa12d38d28f3de40bdd9f26155388 new_contents_impl->GetController().SetSessionStorageNamespace( partition_id, session_storage_namespace); -@@ -3769,12 +3777,6 @@ FrameTree* WebContentsImpl::CreateNewWindow( +@@ -3781,12 +3789,6 @@ FrameTree* WebContentsImpl::CreateNewWindow( AddWebContentsDestructionObserver(new_contents_impl); } @@ -53,13 +53,13 @@ index 6f0d2cee13b39ef0fb60ceec0bbf25f17f8b1152..183fa12d38d28f3de40bdd9f26155388 new_contents_impl, opener, params.target_url, params.referrer.To(), params.disposition, diff --git a/content/common/frame.mojom b/content/common/frame.mojom -index 72fd11b1733aa5433c1905933c357aa58c02578d..d6cdf5cfe1287cddf29279e28ce878cf11616cca 100644 +index 74ed9ae0eae10e77dace6905b5108a834b07f8b4..924d6b43d444ccb919d6985c975eb8862ca35b20 100644 --- a/content/common/frame.mojom +++ b/content/common/frame.mojom -@@ -523,6 +523,10 @@ struct CreateNewWindowParams { - // The impression associated with the navigation in the new window, if - // one is specified. - blink.mojom.Impression? impression; +@@ -533,6 +533,10 @@ struct CreateNewWindowParams { + + // Governs how downloads are handled if `target_url` results in a download. + blink.mojom.NavigationDownloadPolicy download_policy; + + // Extra fields added by Electron. + string raw_features; @@ -68,10 +68,10 @@ index 72fd11b1733aa5433c1905933c357aa58c02578d..d6cdf5cfe1287cddf29279e28ce878cf // Operation result when the renderer asks the browser to create a new window. diff --git a/content/public/browser/content_browser_client.cc b/content/public/browser/content_browser_client.cc -index 757313d3543d3777b0fb751197a6c16cb262514a..8bcdbc88d1445df9c833f7d6cd5f768c7a1b9c62 100644 +index 9f8dbbc7a63cf8a1a8166dd67efd452eab791426..8a45f8c39fe160829de316c513e73327dabfc391 100644 --- a/content/public/browser/content_browser_client.cc +++ b/content/public/browser/content_browser_client.cc -@@ -556,6 +556,8 @@ bool ContentBrowserClient::CanCreateWindow( +@@ -557,6 +557,8 @@ bool ContentBrowserClient::CanCreateWindow( const std::string& frame_name, WindowOpenDisposition disposition, const blink::mojom::WindowFeatures& features, @@ -81,10 +81,10 @@ index 757313d3543d3777b0fb751197a6c16cb262514a..8bcdbc88d1445df9c833f7d6cd5f768c bool opener_suppressed, bool* no_javascript_access) { diff --git a/content/public/browser/content_browser_client.h b/content/public/browser/content_browser_client.h -index f97d7367f0e46eb7c59d6654138a6aec607beeea..75227e160dda6724e59271e702c956ea1470a40e 100644 +index 4db050cb8e5e328f84d4a5fc92aee7d743ee16c4..bb30bb3604a793cbe37d20a3a18b21d5abfd6530 100644 --- a/content/public/browser/content_browser_client.h +++ b/content/public/browser/content_browser_client.h -@@ -164,6 +164,7 @@ class NetworkService; +@@ -166,6 +166,7 @@ class NetworkService; class TrustedURLLoaderHeaderClient; } // namespace mojom struct ResourceRequest; @@ -92,7 +92,7 @@ index f97d7367f0e46eb7c59d6654138a6aec607beeea..75227e160dda6724e59271e702c956ea } // namespace network namespace sandbox { -@@ -921,6 +922,8 @@ class CONTENT_EXPORT ContentBrowserClient { +@@ -924,6 +925,8 @@ class CONTENT_EXPORT ContentBrowserClient { const std::string& frame_name, WindowOpenDisposition disposition, const blink::mojom::WindowFeatures& features, @@ -150,7 +150,7 @@ index a0da74d5cbe4ab8be84d6f1a92f444e858320745..5936fa4bce09895595ccb294504f5b89 // typically happens when popups are created. virtual void WebContentsCreated(WebContents* source_contents, diff --git a/content/renderer/render_view_impl.cc b/content/renderer/render_view_impl.cc -index 092352d96858b45a46ac1eddd162a63b1e468031..aa1cf3dfca39c4443311895a3d7abfc89aad8951 100644 +index ea22a86dc1a6e5cdb3e3dfa31a929a3dd14b9e61..215b059bb2dfcead6c709c99b39578f8e2216d93 100644 --- a/content/renderer/render_view_impl.cc +++ b/content/renderer/render_view_impl.cc @@ -31,6 +31,7 @@ @@ -169,9 +169,9 @@ index 092352d96858b45a46ac1eddd162a63b1e468031..aa1cf3dfca39c4443311895a3d7abfc8 + WTF::UTF8ConversionMode::kStrictUTF8ConversionReplacingUnpairedSurrogatesWithFFFD); + params->body = GetRequestBodyForWebURLRequest(request); + - // We preserve this information before sending the message since |params| is - // moved on send. - bool is_background_tab = + params->download_policy.ApplyDownloadFramePolicy( + /*is_opener_navigation=*/false, request.HasUserGesture(), + // `openee_can_access_opener_origin` only matters for opener navigations, diff --git a/content/web_test/browser/web_test_content_browser_client.cc b/content/web_test/browser/web_test_content_browser_client.cc index c6872573086e628a894f482877db2d417552c6a1..5e67b6a59c3e3d6881f738985ab947a2d7902f0a 100644 --- a/content/web_test/browser/web_test_content_browser_client.cc @@ -220,10 +220,10 @@ index 84d32491a56528a84b4395fba1d54cdbb38d522b..09998a83c449ef8cd9f360fbcdcf7edc } // namespace blink diff --git a/third_party/blink/renderer/core/frame/local_dom_window.cc b/third_party/blink/renderer/core/frame/local_dom_window.cc -index 1a46a0589b5891ca0513ba9854fca034c56b25b8..d1040bc168dfd20405a09436e089a29696e31d41 100644 +index 10e40d408bb0b1526534918add49906e65d17368..b6a0473ad93f8ef1adc53536411e8fd62c106b5d 100644 --- a/third_party/blink/renderer/core/frame/local_dom_window.cc +++ b/third_party/blink/renderer/core/frame/local_dom_window.cc -@@ -2008,6 +2008,7 @@ DOMWindow* LocalDOMWindow::open(v8::Isolate* isolate, +@@ -2022,6 +2022,7 @@ DOMWindow* LocalDOMWindow::open(v8::Isolate* isolate, WebWindowFeatures window_features = GetWindowFeaturesFromString(features, incumbent_window); diff --git a/patches/chromium/chore_provide_iswebcontentscreationoverridden_with_full_params.patch b/patches/chromium/chore_provide_iswebcontentscreationoverridden_with_full_params.patch index 514ce2cf6d2b2..e20f2880d02f8 100644 --- a/patches/chromium/chore_provide_iswebcontentscreationoverridden_with_full_params.patch +++ b/patches/chromium/chore_provide_iswebcontentscreationoverridden_with_full_params.patch @@ -108,10 +108,10 @@ index ef84e04d628fb5cdbaf8fbbf84af3bf23e00c522..f1ee0bee5bfd08227a29498f8410d5d3 } diff --git a/chrome/browser/ui/browser.cc b/chrome/browser/ui/browser.cc -index c522e51369fbcdf482a467475abce309bd8195c5..f7c95b019f4a19c94ec95234e7bdda84d8bfcf51 100644 +index 61724ab53609f80cf5a0139c8bdb2ad1fb0413b2..b8647710bf9a16e8ffc3ca3b25aa4f6c584fa9be 100644 --- a/chrome/browser/ui/browser.cc +++ b/chrome/browser/ui/browser.cc -@@ -1788,12 +1788,11 @@ bool Browser::IsWebContentsCreationOverridden( +@@ -1789,12 +1789,11 @@ bool Browser::IsWebContentsCreationOverridden( content::SiteInstance* source_site_instance, content::mojom::WindowContainerType window_container_type, const GURL& opener_url, @@ -127,10 +127,10 @@ index c522e51369fbcdf482a467475abce309bd8195c5..f7c95b019f4a19c94ec95234e7bdda84 WebContents* Browser::CreateCustomWebContents( diff --git a/chrome/browser/ui/browser.h b/chrome/browser/ui/browser.h -index 17c3233034d0e40970887253c2518486cc32825e..795a8390c23ac016d05ea8898f2a082cd5a80fbc 100644 +index 7649c59dde3f58b5ec153eb6146b159cfc190975..c1cc53b89d805f63fe4dcda12e02cd0a2687f926 100644 --- a/chrome/browser/ui/browser.h +++ b/chrome/browser/ui/browser.h -@@ -798,8 +798,7 @@ class Browser : public TabStripModelObserver, +@@ -807,8 +807,7 @@ class Browser : public TabStripModelObserver, content::SiteInstance* source_site_instance, content::mojom::WindowContainerType window_container_type, const GURL& opener_url, @@ -232,10 +232,10 @@ index c5c5a7b63b5b3b62a9517cbef3ae23ce57a3c89c..4f1b7e88d6d2ae89a60311c8aeb1fcee void AddNewContents(content::WebContents* source, std::unique_ptr new_contents, diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc -index 1e38a16e950a4ee5ed63405576b57185fe7b9e3c..8b9e76ad6eee5e03bfa97a2f5c6c7d8898f0dfe5 100644 +index bc84aa5826d4ca8aef8f496acd3569152007b7a8..b6524566b96a141ba710441ab70d17f46e5b1b9a 100644 --- a/content/browser/web_contents/web_contents_impl.cc +++ b/content/browser/web_contents/web_contents_impl.cc -@@ -3675,8 +3675,7 @@ FrameTree* WebContentsImpl::CreateNewWindow( +@@ -3687,8 +3687,7 @@ FrameTree* WebContentsImpl::CreateNewWindow( if (delegate_ && delegate_->IsWebContentsCreationOverridden( source_site_instance, params.window_container_type, @@ -302,10 +302,10 @@ index 9b293d0df6c634bf44a69d607c4eee839a74b4a1..7e5b9cbdcc232c5e20eae0130d800f50 content::RenderFrameHost* opener, content::SiteInstance* source_site_instance, diff --git a/extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc b/extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc -index 2dc016e4be765413b4cef0f5471dcf9240f73ff5..224cd2be71670ac565d02ecb2838123154255dc6 100644 +index b794ee4204fb8eaf90084e762f80988af13609b4..ac4e00f2ef1d2a722851d88531c28e65dea0341e 100644 --- a/extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc +++ b/extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc -@@ -386,8 +386,7 @@ bool MimeHandlerViewGuest::IsWebContentsCreationOverridden( +@@ -385,8 +385,7 @@ bool MimeHandlerViewGuest::IsWebContentsCreationOverridden( content::SiteInstance* source_site_instance, content::mojom::WindowContainerType window_container_type, const GURL& opener_url, @@ -344,10 +344,10 @@ index 2863abb239a77b96e638c83f47ae7219cf0ccec8..5675ad386efa99383067eb404b385cf2 // can catch bad client behavior while not interfering with normal operation. constexpr size_t kMaxPendingWebContentsCount = 10; diff --git a/fuchsia/engine/browser/frame_impl.h b/fuchsia/engine/browser/frame_impl.h -index e2736c5329d9516fdd417df4dff8039f991e800e..11081373e0d70e7ec366c6917c21db61c4e18cca 100644 +index 3e65c4e8faf63ab1d42e3f57457a071e322383dc..5f4d859f8f3ebb58336485a0a39837eec2c46294 100644 --- a/fuchsia/engine/browser/frame_impl.h +++ b/fuchsia/engine/browser/frame_impl.h -@@ -245,8 +245,7 @@ class FrameImpl : public fuchsia::web::Frame, +@@ -246,8 +246,7 @@ class FrameImpl : public fuchsia::web::Frame, content::SiteInstance* source_site_instance, content::mojom::WindowContainerType window_container_type, const GURL& opener_url, @@ -358,7 +358,7 @@ index e2736c5329d9516fdd417df4dff8039f991e800e..11081373e0d70e7ec366c6917c21db61 int opener_render_process_id, int opener_render_frame_id, diff --git a/headless/lib/browser/headless_web_contents_impl.cc b/headless/lib/browser/headless_web_contents_impl.cc -index dd1f6129173a0e19023f4ec9b66c44486b080456..d10468c06f84b59387af0a8fd5bc1c06108865eb 100644 +index 09bb4b3ef68aeb6dc2fa83ab574c46bebc68dcd1..e104fcba8c5c2e5530ae9a231c21fb1cd69ee303 100644 --- a/headless/lib/browser/headless_web_contents_impl.cc +++ b/headless/lib/browser/headless_web_contents_impl.cc @@ -192,8 +192,7 @@ class HeadlessWebContentsImpl::Delegate : public content::WebContentsDelegate { diff --git a/patches/chromium/chore_use_electron_resources_not_chrome_for_spellchecker.patch b/patches/chromium/chore_use_electron_resources_not_chrome_for_spellchecker.patch index f8d0c75db555c..f153e95542c0d 100644 --- a/patches/chromium/chore_use_electron_resources_not_chrome_for_spellchecker.patch +++ b/patches/chromium/chore_use_electron_resources_not_chrome_for_spellchecker.patch @@ -7,10 +7,10 @@ spellchecker uses a few IDS_ resources. We need to load these from Electrons grit header instead of Chromes diff --git a/chrome/browser/BUILD.gn b/chrome/browser/BUILD.gn -index 708f198ecb05fe37ea979cd7d79c6613a3fd3ff5..74f816aef514eef1263d9b2c25cf3a52359860a6 100644 +index 8847ed67e305d746c671afb49b445afaf24b85b3..3acfeb5e5bf721fabe2339e389193cd9e154e293 100644 --- a/chrome/browser/BUILD.gn +++ b/chrome/browser/BUILD.gn -@@ -6635,6 +6635,7 @@ static_library("browser") { +@@ -6689,6 +6689,7 @@ static_library("browser") { deps += [ "//components/spellcheck/browser", "//components/spellcheck/common", diff --git a/patches/chromium/dcheck.patch b/patches/chromium/dcheck.patch index f6d701883b5f9..cf7a0e53fa123 100644 --- a/patches/chromium/dcheck.patch +++ b/patches/chromium/dcheck.patch @@ -17,10 +17,10 @@ only one or two specific checks fail. Then it's better to simply comment out the failing checks and allow the rest of the target to have them enabled. diff --git a/ui/base/clipboard/clipboard_win.cc b/ui/base/clipboard/clipboard_win.cc -index 9422954679f29f24db141120e6167c35fad7a890..e548bcc0c5908ea6f1db8fdba143304afebde8cd 100644 +index 68c758df6954c0deb25d8d93da2d22f8cdf00771..03bdc80a1e1b5db4731a81f5a2851722e3c0d652 100644 --- a/ui/base/clipboard/clipboard_win.cc +++ b/ui/base/clipboard/clipboard_win.cc -@@ -941,10 +941,10 @@ SkBitmap ClipboardWin::ReadImageInternal(ClipboardBuffer buffer) const { +@@ -923,10 +923,10 @@ SkBitmap ClipboardWin::ReadImageInternal(ClipboardBuffer buffer) const { void ClipboardWin::WriteToClipboard(ClipboardFormatType format, HANDLE handle) { UINT cf_format = format.ToFormatEtc().cfFormat; diff --git a/patches/chromium/delay_lock_the_protocol_scheme_registry.patch b/patches/chromium/delay_lock_the_protocol_scheme_registry.patch index 0c7bc144e33a2..5a9221c4e9dd3 100644 --- a/patches/chromium/delay_lock_the_protocol_scheme_registry.patch +++ b/patches/chromium/delay_lock_the_protocol_scheme_registry.patch @@ -19,7 +19,7 @@ https://chromium-review.googlesource.com/c/chromium/src/+/1901591, we should try re-submitting the patch. diff --git a/content/app/content_main_runner_impl.cc b/content/app/content_main_runner_impl.cc -index 095bc943529c38c4f469bf69b79006ca48a4e0d5..0e358e2d140bccf2e987db234cd5922732149168 100644 +index 7e7a16e6f9cb187a834ecc44b27f288c9146b6a6..a2aca80f9a95c345e6d394b78d3341534fd0450f 100644 --- a/content/app/content_main_runner_impl.cc +++ b/content/app/content_main_runner_impl.cc @@ -751,7 +751,7 @@ int ContentMainRunnerImpl::Initialize(const ContentMainParams& params) { diff --git a/patches/chromium/disable-redraw-lock.patch b/patches/chromium/disable-redraw-lock.patch index b21962b24bb7b..599d5858f56fd 100644 --- a/patches/chromium/disable-redraw-lock.patch +++ b/patches/chromium/disable-redraw-lock.patch @@ -15,7 +15,7 @@ the redraw locking mechanism, which fixes these issues. The electron issue can be found at https://github.com/electron/electron/issues/1821 diff --git a/ui/views/win/hwnd_message_handler.cc b/ui/views/win/hwnd_message_handler.cc -index c471f43c6da9e8d7b09f0a07adaa80f5c5632aba..5a08221e56951bd5f4cd2065fa7f70e773ed1214 100644 +index 21e96caaa87538f962b7446dc889bd0ece3ca986..21d64ed9c116088fb5f4becad8a5e827ff47f1c4 100644 --- a/ui/views/win/hwnd_message_handler.cc +++ b/ui/views/win/hwnd_message_handler.cc @@ -307,6 +307,10 @@ constexpr int kSynthesizedMouseMessagesTimeDifference = 500; diff --git a/patches/chromium/disable_color_correct_rendering.patch b/patches/chromium/disable_color_correct_rendering.patch index 172d974b21a82..c88acd3554f4a 100644 --- a/patches/chromium/disable_color_correct_rendering.patch +++ b/patches/chromium/disable_color_correct_rendering.patch @@ -20,7 +20,7 @@ to deal with color spaces. That is being tracked at https://crbug.com/634542 and https://crbug.com/711107. diff --git a/cc/trees/layer_tree_host_impl.cc b/cc/trees/layer_tree_host_impl.cc -index 63f61838cbfa9733b0a0f6831ccf0d9a1958e81e..a6fb9b69ba52af1b0d76cf8110c784058e2599d7 100644 +index 3be9e62159ad6ac98e1cd0790c7c06921effe5e3..356a8f451061b0bddeb1fcc1b64d7e48b7e8c8a6 100644 --- a/cc/trees/layer_tree_host_impl.cc +++ b/cc/trees/layer_tree_host_impl.cc @@ -1802,6 +1802,10 @@ void LayerTreeHostImpl::SetIsLikelyToRequireADraw( @@ -229,7 +229,7 @@ index 1e2ad6423a5e316a9a1713abab7579ea0d2a82f9..22df5e1728e5dc2879c9b96911f6e734 + +#undef PATCH_CS diff --git a/content/browser/gpu/gpu_process_host.cc b/content/browser/gpu/gpu_process_host.cc -index 20c70c62a8e085a50cef7b90ef859efd014d16c9..8a780e2324935f196db9720649ff974ee43f3d3a 100644 +index cc90e0aae77c0ca80eeab84eee8ff89a1295dbd2..fa96e7fa8c4f5d14da548398e533b10f153723ed 100644 --- a/content/browser/gpu/gpu_process_host.cc +++ b/content/browser/gpu/gpu_process_host.cc @@ -224,6 +224,7 @@ GpuTerminationStatus ConvertToGpuTerminationStatus( @@ -241,18 +241,18 @@ index 20c70c62a8e085a50cef7b90ef859efd014d16c9..8a780e2324935f196db9720649ff974e sandbox::policy::switches::kGpuSandboxAllowSysVShm, sandbox::policy::switches::kGpuSandboxFailuresFatal, diff --git a/content/browser/renderer_host/render_process_host_impl.cc b/content/browser/renderer_host/render_process_host_impl.cc -index 8c61ce5f2035a63675d17fda429b839c1e1e8e3b..b6b26ce465407a75dd8e15138187d614a3415941 100644 +index 0a53d80feb2cdaa599da3ea87a8a6a8f8327ae92..532e82ca5145853b218c1e835d0b71bc1b158564 100644 --- a/content/browser/renderer_host/render_process_host_impl.cc +++ b/content/browser/renderer_host/render_process_host_impl.cc -@@ -219,6 +219,7 @@ +@@ -183,6 +183,7 @@ #include "ui/accessibility/accessibility_switches.h" #include "ui/base/ui_base_switches.h" #include "ui/display/display_switches.h" +#include "ui/gfx/switches.h" #include "ui/gl/gl_switches.h" - #include "ui/native_theme/native_theme_features.h" + #include "url/gurl.h" #include "url/origin.h" -@@ -3381,6 +3382,7 @@ void RenderProcessHostImpl::PropagateBrowserCommandLineToRenderer( +@@ -3375,6 +3376,7 @@ void RenderProcessHostImpl::PropagateBrowserCommandLineToRenderer( // Propagate the following switches to the renderer command line (along // with any associated values) if present in the browser command line. static const char* const kSwitchNames[] = { @@ -315,10 +315,10 @@ index 083e7c6d49574ae5d1beeba02b334ae864d60afb..85626cd2354b0c13caceb8a1b4f7d585 // is what the renderer uses if its not threaded. settings.enable_checker_imaging = diff --git a/ui/gfx/mac/io_surface.cc b/ui/gfx/mac/io_surface.cc -index 546e43318ee74746a84a70c731e9117c88ea9136..3cc93ff14f3471e99e42d533517df36d16d3cca2 100644 +index 7a199bc598eb6ec3a90ca7a6209e6598e48b79d5..eb368323105f7232c1e3ac79b7db56525f2d906f 100644 --- a/ui/gfx/mac/io_surface.cc +++ b/ui/gfx/mac/io_surface.cc -@@ -20,6 +20,7 @@ +@@ -21,6 +21,7 @@ #include "ui/gfx/buffer_format_util.h" #include "ui/gfx/color_space.h" #include "ui/gfx/icc_profile.h" @@ -326,7 +326,7 @@ index 546e43318ee74746a84a70c731e9117c88ea9136..3cc93ff14f3471e99e42d533517df36d namespace gfx { -@@ -131,6 +132,14 @@ void IOSurfaceMachPortTraits::Release(mach_port_t port) { +@@ -132,6 +133,14 @@ void IOSurfaceMachPortTraits::Release(mach_port_t port) { // Common method used by IOSurfaceSetColorSpace and IOSurfaceCanSetColorSpace. bool IOSurfaceSetColorSpace(IOSurfaceRef io_surface, const ColorSpace& color_space) { @@ -341,7 +341,7 @@ index 546e43318ee74746a84a70c731e9117c88ea9136..3cc93ff14f3471e99e42d533517df36d // Allow but ignore invalid color spaces. if (!color_space.IsValid()) return true; -@@ -297,6 +306,15 @@ IOSurfaceRef CreateIOSurface(const gfx::Size& size, +@@ -302,6 +311,15 @@ IOSurfaceRef CreateIOSurface(const gfx::Size& size, DCHECK_EQ(kIOReturnSuccess, r); } diff --git a/patches/chromium/disable_compositor_recycling.patch b/patches/chromium/disable_compositor_recycling.patch index 66697ab5e3d9b..dc011ac38a5f7 100644 --- a/patches/chromium/disable_compositor_recycling.patch +++ b/patches/chromium/disable_compositor_recycling.patch @@ -6,10 +6,10 @@ Subject: fix: disabling compositor recycling Compositor recycling is useful for Chrome because there can be many tabs and spinning up a compositor for each one would be costly. In practice, Chrome uses the parent compositor code path of browser_compositor_view_mac.mm; the NSView of each tab is detached when it's hidden and attached when it's shown. For Electron, there is no parent compositor, so we're forced into the "own compositor" code path, which seems to be non-optimal and pretty ruthless in terms of the release of resources. Electron has no real concept of multiple tabs per window, so it should be okay to disable this ruthless recycling altogether in Electron. diff --git a/content/browser/renderer_host/render_widget_host_view_mac.mm b/content/browser/renderer_host/render_widget_host_view_mac.mm -index e9f3e0d499c53cebc20d417d396190f7dc384c69..950dbc9e0644accbbc3131c8973c6b738274530e 100644 +index 515d1588c0de8daa503df91338dc3a5c072c5690..b524f3125f955ba065c2d87e992606ec88b95b55 100644 --- a/content/browser/renderer_host/render_widget_host_view_mac.mm +++ b/content/browser/renderer_host/render_widget_host_view_mac.mm -@@ -482,7 +482,11 @@ +@@ -483,7 +483,11 @@ return; host()->WasHidden(); diff --git a/patches/chromium/disable_hidden.patch b/patches/chromium/disable_hidden.patch index 9c21a02384f6f..09872b803a121 100644 --- a/patches/chromium/disable_hidden.patch +++ b/patches/chromium/disable_hidden.patch @@ -6,7 +6,7 @@ Subject: disable_hidden.patch Electron uses this to disable background throttling for hidden windows. diff --git a/content/browser/renderer_host/render_widget_host_impl.cc b/content/browser/renderer_host/render_widget_host_impl.cc -index ebb771918923b3d8552bde02602ab88a2e1d61a7..4bec6c3593de51f6098c632a08793508106ec21d 100644 +index 095ae394b95b07f17295611dc1ade9ae7b4f2c1c..b72e3f6ab2a43e8a7f707e9634fb3a4abb87e993 100644 --- a/content/browser/renderer_host/render_widget_host_impl.cc +++ b/content/browser/renderer_host/render_widget_host_impl.cc @@ -773,6 +773,9 @@ void RenderWidgetHostImpl::WasHidden() { @@ -20,10 +20,10 @@ index ebb771918923b3d8552bde02602ab88a2e1d61a7..4bec6c3593de51f6098c632a08793508 blink::mojom::PointerLockResult::kWrongDocument); diff --git a/content/browser/renderer_host/render_widget_host_impl.h b/content/browser/renderer_host/render_widget_host_impl.h -index d082d920c4124b38f1e0358f065ab9b6a18baa76..f966eb89e61a56571d8478f385d5623a119956b5 100644 +index 59b0439a6ba6959b5c37c316fcb955a1486c343d..2b93a57863f4e0e5e41fbf4a640510d70b794830 100644 --- a/content/browser/renderer_host/render_widget_host_impl.h +++ b/content/browser/renderer_host/render_widget_host_impl.h -@@ -855,6 +855,9 @@ class CONTENT_EXPORT RenderWidgetHostImpl +@@ -856,6 +856,9 @@ class CONTENT_EXPORT RenderWidgetHostImpl mojom::CreateFrameWidgetParamsPtr BindAndGenerateCreateFrameWidgetParamsForNewWindow(); @@ -34,10 +34,10 @@ index d082d920c4124b38f1e0358f065ab9b6a18baa76..f966eb89e61a56571d8478f385d5623a // |routing_id| must not be MSG_ROUTING_NONE. // If this object outlives |delegate|, DetachDelegate() must be called when diff --git a/content/browser/renderer_host/render_widget_host_view_aura.cc b/content/browser/renderer_host/render_widget_host_view_aura.cc -index 0ff5615d8d8704086aad1361334a93fd9465e670..a8bbfa6a50acf6318290308cb4ff6d4854df49c5 100644 +index 2f508cbb53a9d5734c1be40827b5b4794b639056..555937e97250f62d68860ec86026efafe6a5d616 100644 --- a/content/browser/renderer_host/render_widget_host_view_aura.cc +++ b/content/browser/renderer_host/render_widget_host_view_aura.cc -@@ -598,7 +598,7 @@ void RenderWidgetHostViewAura::HideImpl() { +@@ -605,7 +605,7 @@ void RenderWidgetHostViewAura::HideImpl() { DCHECK(visibility_ == Visibility::HIDDEN || visibility_ == Visibility::OCCLUDED); diff --git a/patches/chromium/disable_unload_metrics.patch b/patches/chromium/disable_unload_metrics.patch index ed2b68294ab5f..4d84314cf082a 100644 --- a/patches/chromium/disable_unload_metrics.patch +++ b/patches/chromium/disable_unload_metrics.patch @@ -24,10 +24,10 @@ This patch temporarily disables the metrics so we can have green CI, and we should continue seeking for a real fix. diff --git a/content/browser/renderer_host/navigator.cc b/content/browser/renderer_host/navigator.cc -index ab2f90337a64aa9737ada27bfa7c4344f1358bb6..1d308e7ec0bcf302d86f61fd5e39cb3e87c9a25b 100644 +index cd3055cb99e117868d6b1d2d7a4faedca0a3981f..5f5bf984b28c5f708db632f1771601b08f23a3b1 100644 --- a/content/browser/renderer_host/navigator.cc +++ b/content/browser/renderer_host/navigator.cc -@@ -1092,6 +1092,7 @@ void Navigator::RecordNavigationMetrics( +@@ -1098,6 +1098,7 @@ void Navigator::RecordNavigationMetrics( .InMilliseconds()); } @@ -35,7 +35,7 @@ index ab2f90337a64aa9737ada27bfa7c4344f1358bb6..1d308e7ec0bcf302d86f61fd5e39cb3e // If this is a same-process navigation and we have timestamps for unload // durations, fill those metrics out as well. if (params.unload_start && params.unload_end && -@@ -1138,6 +1139,7 @@ void Navigator::RecordNavigationMetrics( +@@ -1144,6 +1145,7 @@ void Navigator::RecordNavigationMetrics( first_before_unload_start_time) .InMilliseconds()); } diff --git a/patches/chromium/disable_use_lld_for_macos.patch b/patches/chromium/disable_use_lld_for_macos.patch deleted file mode 100644 index c235858f959e8..0000000000000 --- a/patches/chromium/disable_use_lld_for_macos.patch +++ /dev/null @@ -1,21 +0,0 @@ -From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001 -From: mlaurencin -Date: Fri, 6 Aug 2021 15:29:48 -0700 -Subject: disable use_lld for macOS - -This patch disables use_lld on macOS, in order to prevent a linking bug -that occurs when building for arm64. - -diff --git a/build/config/compiler/compiler.gni b/build/config/compiler/compiler.gni -index 6f1faaf10fa67a82077023ebbac31cca12cd6578..d7167629fa4cf5b2e46d2959d104e0dcec4acac4 100644 ---- a/build/config/compiler/compiler.gni -+++ b/build/config/compiler/compiler.gni -@@ -200,7 +200,7 @@ declare_args() { - # Set to true to use lld, the LLVM linker. - # In late bring-up on macOS (see docs/mac_lld.md), and not functional at all for - # iOS. The default linker everywhere else. -- use_lld = is_clang && (!is_apple || host_os == "linux") -+ use_lld = is_clang && !is_apple - } - - declare_args() { diff --git a/patches/chromium/don_t_use_potentially_null_getwebframe_-_view_when_get_blink.patch b/patches/chromium/don_t_use_potentially_null_getwebframe_-_view_when_get_blink.patch index ae7322bd182e8..96cbd2fc1bf1c 100644 --- a/patches/chromium/don_t_use_potentially_null_getwebframe_-_view_when_get_blink.patch +++ b/patches/chromium/don_t_use_potentially_null_getwebframe_-_view_when_get_blink.patch @@ -11,10 +11,10 @@ This regressed in https://chromium-review.googlesource.com/c/chromium/src/+/2572 Upstream: https://chromium-review.googlesource.com/c/chromium/src/+/2598393 diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc -index 7884866e2358f78a994dd784f187fdb8bd592bad..336fef1c0da9c1a729c90323cf9bfc26d75f1411 100644 +index 395bb615c0a2d5a49cfbc6d8a9e9f3d9a809b595..dcf47a194713764d0ccb588ff07de7fc43e30bdc 100644 --- a/content/renderer/render_frame_impl.cc +++ b/content/renderer/render_frame_impl.cc -@@ -2358,7 +2358,7 @@ const blink::WebView* RenderFrameImpl::GetWebView() const { +@@ -2357,7 +2357,7 @@ const blink::WebView* RenderFrameImpl::GetWebView() const { } const blink::web_pref::WebPreferences& RenderFrameImpl::GetBlinkPreferences() { diff --git a/patches/chromium/dump_syms.patch b/patches/chromium/dump_syms.patch index 8f7b43980934a..fc1aa66036758 100644 --- a/patches/chromium/dump_syms.patch +++ b/patches/chromium/dump_syms.patch @@ -8,10 +8,10 @@ this but it is not a blocker for releasing Electron. This patch removes tthe hard fail on dylib resolve failure from dump_syms diff --git a/components/crash/content/tools/generate_breakpad_symbols.py b/components/crash/content/tools/generate_breakpad_symbols.py -index ae381dd057d3fd4b6e70ba868edf30eeba93752e..78b2b2fe4e7be6b19bc0e980fee4d6817139701c 100755 +index 149c2b49c21efe7f6c5449ea225c8ed7d52287a8..4b68592d88cf703a6abbe8f875bffefdee8272bc 100755 --- a/components/crash/content/tools/generate_breakpad_symbols.py +++ b/components/crash/content/tools/generate_breakpad_symbols.py -@@ -205,7 +205,7 @@ def GetSharedLibraryDependenciesMac(binary, exe_path): +@@ -206,7 +206,7 @@ def GetSharedLibraryDependenciesMac(binary, exe_path): 'ERROR: failed to resolve %s, exe_path %s, loader_path %s, ' 'rpaths %s' % (m.group(1), exe_path, loader_path, ', '.join(rpaths))), file=sys.stderr) diff --git a/patches/chromium/enable_reset_aspect_ratio.patch b/patches/chromium/enable_reset_aspect_ratio.patch index 5f42135b04ebe..e1309d986dc8a 100644 --- a/patches/chromium/enable_reset_aspect_ratio.patch +++ b/patches/chromium/enable_reset_aspect_ratio.patch @@ -6,7 +6,7 @@ Subject: feat: enable setting aspect ratio to 0 Make SetAspectRatio accept 0 as valid input, which would reset to null. diff --git a/ui/views/widget/desktop_aura/desktop_window_tree_host_win.cc b/ui/views/widget/desktop_aura/desktop_window_tree_host_win.cc -index 042fb2b5d16533767bf33ca8fffa9c4bc5c35f87..fdcd982e77838b3fd128f5af25575101a4575b41 100644 +index 17668789847d1a7f7037b9507adb824c02f1cb31..6401d9b00d6c7071c16ca44866a3d53116ddfb89 100644 --- a/ui/views/widget/desktop_aura/desktop_window_tree_host_win.cc +++ b/ui/views/widget/desktop_aura/desktop_window_tree_host_win.cc @@ -527,7 +527,7 @@ void DesktopWindowTreeHostWin::SetOpacity(float opacity) { @@ -19,7 +19,7 @@ index 042fb2b5d16533767bf33ca8fffa9c4bc5c35f87..fdcd982e77838b3fd128f5af25575101 aspect_ratio.height()); } diff --git a/ui/views/win/hwnd_message_handler.cc b/ui/views/win/hwnd_message_handler.cc -index 5a08221e56951bd5f4cd2065fa7f70e773ed1214..18acd3724d486f7acdaa6aeedcd8ff3681729746 100644 +index 21d64ed9c116088fb5f4becad8a5e827ff47f1c4..7f6ab51b2d83a8c555de1d1e19a40b93b438fbd4 100644 --- a/ui/views/win/hwnd_message_handler.cc +++ b/ui/views/win/hwnd_message_handler.cc @@ -926,8 +926,11 @@ void HWNDMessageHandler::SetFullscreen(bool fullscreen) { diff --git a/patches/chromium/export_gin_v8platform_pageallocator_for_usage_outside_of_the_gin.patch b/patches/chromium/export_gin_v8platform_pageallocator_for_usage_outside_of_the_gin.patch index d69cb4a3c766b..b4a82e8fca0bb 100644 --- a/patches/chromium/export_gin_v8platform_pageallocator_for_usage_outside_of_the_gin.patch +++ b/patches/chromium/export_gin_v8platform_pageallocator_for_usage_outside_of_the_gin.patch @@ -21,10 +21,10 @@ index fa0e7faad9296b9be8d662324c52f40e502f2e38..a579b359c684ccd72dcbe43f40b4aa7b #endif std::shared_ptr GetForegroundTaskRunner( diff --git a/gin/v8_platform.cc b/gin/v8_platform.cc -index 60f38b2dd015bea3410e8c69e9cb4a1d092e299b..4f44735c4e841f82091bdab474790d3f1a1a76ad 100644 +index 6acf18c405774774fa9074f1b3d5daeefbda120e..9147b28b0f7f016a26e3d9e346f1eeb72d719a79 100644 --- a/gin/v8_platform.cc +++ b/gin/v8_platform.cc -@@ -465,6 +465,10 @@ v8::PageAllocator* V8Platform::GetPageAllocator() { +@@ -472,6 +472,10 @@ v8::PageAllocator* V8Platform::GetPageAllocator() { return g_page_allocator.Pointer(); } diff --git a/patches/chromium/expose_setuseragent_on_networkcontext.patch b/patches/chromium/expose_setuseragent_on_networkcontext.patch index 92ba3a79b55ce..8122eb598dee9 100644 --- a/patches/chromium/expose_setuseragent_on_networkcontext.patch +++ b/patches/chromium/expose_setuseragent_on_networkcontext.patch @@ -33,10 +33,10 @@ index 0ccfe130f00ec3b6c75cd8ee04d5a2777e1fd00c..653829457d58bf92057cc36aa8a28970 DISALLOW_COPY_AND_ASSIGN(StaticHttpUserAgentSettings); }; diff --git a/services/network/network_context.cc b/services/network/network_context.cc -index 94085578e6b80d082b5ac67730381c998a418601..1877a2b555423ca65e051fb128ef3ff546e248ea 100644 +index 3896a834cbb17bfe6ecfc602886ea7d77d7d5167..4f752b1e961e23cf2f0e07a93dfe3867bbd56737 100644 --- a/services/network/network_context.cc +++ b/services/network/network_context.cc -@@ -1287,6 +1287,13 @@ void NetworkContext::SetNetworkConditions( +@@ -1285,6 +1285,13 @@ void NetworkContext::SetNetworkConditions( std::move(network_conditions)); } @@ -51,10 +51,10 @@ index 94085578e6b80d082b5ac67730381c998a418601..1877a2b555423ca65e051fb128ef3ff5 // This may only be called on NetworkContexts created with the constructor // that calls MakeURLRequestContext(). diff --git a/services/network/network_context.h b/services/network/network_context.h -index db9baee0a272674db2eb807932fc8123b9c3a24d..e526cfe29452faf33f7301cf05eddbf3a06129a2 100644 +index 00bcb6e3b31b7e61a36c6df96d39cd0d5cc5e28a..aacda36b0a14beb415592a1f0e478dc1964d82eb 100644 --- a/services/network/network_context.h +++ b/services/network/network_context.h -@@ -269,6 +269,7 @@ class COMPONENT_EXPORT(NETWORK_SERVICE) NetworkContext +@@ -270,6 +270,7 @@ class COMPONENT_EXPORT(NETWORK_SERVICE) NetworkContext void CloseIdleConnections(CloseIdleConnectionsCallback callback) override; void SetNetworkConditions(const base::UnguessableToken& throttling_profile_id, mojom::NetworkConditionsPtr conditions) override; @@ -63,10 +63,10 @@ index db9baee0a272674db2eb807932fc8123b9c3a24d..e526cfe29452faf33f7301cf05eddbf3 void SetEnableReferrers(bool enable_referrers) override; #if BUILDFLAG(IS_CHROMEOS_ASH) diff --git a/services/network/public/mojom/network_context.mojom b/services/network/public/mojom/network_context.mojom -index 987e464333e1f8db3fa810dfa9aaa00e6dae6722..c8f312c3a453d7eaddff65415c9325f3460c68d5 100644 +index 9a4ab0a7493688e31acd119b816de69bfb47d9d7..751769a979c0fc8d3cdcded177ee23c227fcd103 100644 --- a/services/network/public/mojom/network_context.mojom +++ b/services/network/public/mojom/network_context.mojom -@@ -988,6 +988,9 @@ interface NetworkContext { +@@ -998,6 +998,9 @@ interface NetworkContext { SetNetworkConditions(mojo_base.mojom.UnguessableToken throttling_profile_id, NetworkConditions? conditions); @@ -77,10 +77,10 @@ index 987e464333e1f8db3fa810dfa9aaa00e6dae6722..c8f312c3a453d7eaddff65415c9325f3 SetAcceptLanguage(string new_accept_language); diff --git a/services/network/test/test_network_context.h b/services/network/test/test_network_context.h -index 09a537564e30ac14807b7e5c4c1b154ab160f70a..2348e7d78c22d1e8b98860ecf10422e27c523032 100644 +index 6bf98a5e9028cc162aa5493a5dc6910f59aa10d7..48d1f1414894c3ca71de74a7cb5e49eb98a1bf30 100644 --- a/services/network/test/test_network_context.h +++ b/services/network/test/test_network_context.h -@@ -126,6 +126,7 @@ class TestNetworkContext : public mojom::NetworkContext { +@@ -134,6 +134,7 @@ class TestNetworkContext : public mojom::NetworkContext { void CloseIdleConnections(CloseIdleConnectionsCallback callback) override {} void SetNetworkConditions(const base::UnguessableToken& throttling_profile_id, mojom::NetworkConditionsPtr conditions) override {} diff --git a/patches/chromium/feat_enable_offscreen_rendering_with_viz_compositor.patch b/patches/chromium/feat_enable_offscreen_rendering_with_viz_compositor.patch index 860a15f83272d..e59efd8ffd705 100644 --- a/patches/chromium/feat_enable_offscreen_rendering_with_viz_compositor.patch +++ b/patches/chromium/feat_enable_offscreen_rendering_with_viz_compositor.patch @@ -544,7 +544,7 @@ index 409115f95787e3cf037f762a33368b173441012f..45a7a1607b8711420ba4e1a5455a61fb // Notifies that a swap has occurred and provides information about the pixel diff --git a/services/viz/privileged/mojom/compositing/frame_sink_manager.mojom b/services/viz/privileged/mojom/compositing/frame_sink_manager.mojom -index e33e5de0bfb59afe9b21ee27bb6dad5d898932b6..55aff8c8d05ce55bef8440185ac73f48f589d06c 100644 +index 83e7682b14367571a2d52bb3a6f2f63918d8efe9..3b6f2627196170e3a17992ad36534ac9bc178e4a 100644 --- a/services/viz/privileged/mojom/compositing/frame_sink_manager.mojom +++ b/services/viz/privileged/mojom/compositing/frame_sink_manager.mojom @@ -32,6 +32,7 @@ struct RootCompositorFrameSinkParams { diff --git a/patches/chromium/feat_expose_raw_response_headers_from_urlloader.patch b/patches/chromium/feat_expose_raw_response_headers_from_urlloader.patch index 3b498e5e28117..8a696cbb170f9 100644 --- a/patches/chromium/feat_expose_raw_response_headers_from_urlloader.patch +++ b/patches/chromium/feat_expose_raw_response_headers_from_urlloader.patch @@ -39,7 +39,7 @@ index cea1fb864ab46b4b0eabf1db11a0392d6cd575c1..df033f65d50b088778268827e506963a string mime_type; diff --git a/services/network/url_loader.cc b/services/network/url_loader.cc -index 0c0f52fdba85b3a7a5d256e6649763d436b74ee3..92c96b4b693d59ea393bff98a50567e631fdc804 100644 +index c8e3249c79063c001028add6acd3a451074df214..5abf78a851c3a676315e683c7171badc4cb64505 100644 --- a/services/network/url_loader.cc +++ b/services/network/url_loader.cc @@ -1259,6 +1259,19 @@ void URLLoader::OnResponseStarted(net::URLRequest* url_request, int net_error) { diff --git a/patches/chromium/fix_chrome_root_store_codegen_for_cross-compile_builds.patch b/patches/chromium/fix_chrome_root_store_codegen_for_cross-compile_builds.patch new file mode 100644 index 0000000000000..591267ea33d76 --- /dev/null +++ b/patches/chromium/fix_chrome_root_store_codegen_for_cross-compile_builds.patch @@ -0,0 +1,101 @@ +From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001 +From: Hubert Chao +Date: Tue, 31 Aug 2021 23:20:50 +0000 +Subject: Fix chrome root store codegen for cross-compile builds. + +Assuming that the textproto file was underneath base::DIR_SOURCE_ROOT +didn't work for cross-compile builds, so change the build system to +pass the absolute path to the root_store_dir. + +Bug: 1244436 +Change-Id: I06bd6e5729f23e725bfca0c8f0195fcc89d70ba1 +Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3133701 +Commit-Queue: Hubert Chao +Reviewed-by: David Benjamin +Cr-Commit-Position: refs/heads/main@{#917023} + +diff --git a/net/data/ssl/chrome_root_store/BUILD.gn b/net/data/ssl/chrome_root_store/BUILD.gn +index 185d53ec0555fe37be208be488ec1626f1d220ac..92ad13431a3addafdc210cd79501c754a539c38d 100644 +--- a/net/data/ssl/chrome_root_store/BUILD.gn ++++ b/net/data/ssl/chrome_root_store/BUILD.gn +@@ -135,9 +135,11 @@ compiled_action("gen_root_store_inc") { + "store/certs/fd73dad31c644ff1b43bef0ccdda96710b9cd9875eca7e31707af3e96d522bbd.pem", + ] + outputs = [ "${target_gen_dir}/chrome-root-store-inc.cc" ] +- args = [ "--write-cpp=" + +- rebase_path("${target_gen_dir}/chrome-root-store-inc.cc", +- root_build_dir) ] ++ args = [ ++ "--root-store-dir=" + rebase_path("//net/data/ssl/chrome_root_store/store"), ++ "--write-cpp=" + rebase_path("${target_gen_dir}/chrome-root-store-inc.cc", ++ root_build_dir), ++ ] + } + + compiled_action("gen_root_store_test_inc") { +@@ -153,7 +155,8 @@ compiled_action("gen_root_store_test_inc") { + ] + outputs = [ "${target_gen_dir}/chrome-root-store-test-data-inc.cc" ] + args = [ +- "--root-store-dir=net/data/ssl/chrome_root_store/testdata", ++ "--root-store-dir=" + ++ rebase_path("//net/data/ssl/chrome_root_store/testdata"), + "--write-cpp=" + + rebase_path("${target_gen_dir}/chrome-root-store-test-data-inc.cc", + root_build_dir), +diff --git a/net/tools/root_store_tool/root_store_tool.cc b/net/tools/root_store_tool/root_store_tool.cc +index a41379e7a6f83fd2f14e63955337c3fc0ef9f7f3..b16344d9999ed07954f57a88409edc0c69c4e918 100644 +--- a/net/tools/root_store_tool/root_store_tool.cc ++++ b/net/tools/root_store_tool/root_store_tool.cc +@@ -123,37 +123,29 @@ int main(int argc, char** argv) { + base::CommandLine& command_line = *base::CommandLine::ForCurrentProcess(); + base::FilePath proto_path = command_line.GetSwitchValuePath("write-proto"); + base::FilePath cpp_path = command_line.GetSwitchValuePath("write-cpp"); +- if ((proto_path.empty() && cpp_path.empty()) || +- command_line.HasSwitch("help")) { +- std::cerr << "Usage: root_store_tool " +- << "[--root-store-dir=] " +- << "[--write-proto=PROTO_FILE] " +- << "[--write-cpp=CPP_FILE]" << std::endl; +- return 1; +- } +- +- // Find root store directory. Assumptions: +- // - Root store directory is relative to base::DIR_SOURCE_ROOT +- // ++ // Get root store directory. Assumptions: + // - $(ROOT_STORE_DIR)/root_store.textproto contains the textproto definition + // of the root store + // + // - Any certificate files referenced in + // $(ROOT_STORE_DIR)/root_store.textproto exist in the + // $(ROOT_STORE_DIR)/certs/ subdirectory. ++ // ++ // We'd like to assume that Root store directory is relative to ++ // base::DIR_SOURCE_ROOT, but in cross-compile cases this gives the wrong ++ // result leading to broken builds. See https://crbug.com/1244436. + base::FilePath root_store_dir = + command_line.GetSwitchValuePath("root-store-dir"); +- base::FilePath source_root; +- CHECK(base::PathService::Get(base::DIR_SOURCE_ROOT, &source_root)); +- if (root_store_dir.empty()) { +- root_store_dir = source_root.AppendASCII("net") +- .AppendASCII("data") +- .AppendASCII("ssl") +- .AppendASCII("chrome_root_store") +- .AppendASCII("store"); +- } else { +- root_store_dir = source_root.Append(root_store_dir); ++ ++ if ((proto_path.empty() && cpp_path.empty()) || root_store_dir.empty() || ++ command_line.HasSwitch("help")) { ++ std::cerr << "Usage: root_store_tool " ++ << "--root-store-dir= " ++ << "[--write-proto=PROTO_FILE] " ++ << "[--write-cpp=CPP_FILE]" << std::endl; ++ return 1; + } ++ + absl::optional root_store = ReadTextRootStore(root_store_dir); + if (!root_store) { + return 1; diff --git a/patches/chromium/fix_expose_decrementcapturercount_in_web_contents_impl.patch b/patches/chromium/fix_expose_decrementcapturercount_in_web_contents_impl.patch index 1d281261ffa66..2c5fb5ae90974 100644 --- a/patches/chromium/fix_expose_decrementcapturercount_in_web_contents_impl.patch +++ b/patches/chromium/fix_expose_decrementcapturercount_in_web_contents_impl.patch @@ -8,10 +8,10 @@ we invoke it in order to expose contents.decrementCapturerCount([stayHidden, sta to users. We should try to upstream this. diff --git a/content/browser/web_contents/web_contents_impl.h b/content/browser/web_contents/web_contents_impl.h -index 6240a5a997894055bd5f7c2d9ceb741cd9bfe1e4..cbf2121193b63d1bcf9018e65f06f4fc4f7eae47 100644 +index 4fa272275ba3883d105ddfd8deeb4987071d1b06..937980bdc07b7dbe007f6be550bc5eaf62295526 100644 --- a/content/browser/web_contents/web_contents_impl.h +++ b/content/browser/web_contents/web_contents_impl.h -@@ -1769,10 +1769,12 @@ class CONTENT_EXPORT WebContentsImpl : public WebContents, +@@ -1771,10 +1771,12 @@ class CONTENT_EXPORT WebContentsImpl : public WebContents, // outermost frame trees in this WebContents. std::vector GetOutermostMainFrames(); diff --git a/patches/chromium/fix_patch_out_profile_refs_in_accessibility_ui.patch b/patches/chromium/fix_patch_out_profile_refs_in_accessibility_ui.patch index e4ea4b28b9aa6..9841dd9ae92c5 100644 --- a/patches/chromium/fix_patch_out_profile_refs_in_accessibility_ui.patch +++ b/patches/chromium/fix_patch_out_profile_refs_in_accessibility_ui.patch @@ -7,7 +7,7 @@ This tweaks Chrome's Accessibility support at chrome://accessibility to make it usable from Electron by removing Profile references. diff --git a/chrome/browser/accessibility/accessibility_ui.cc b/chrome/browser/accessibility/accessibility_ui.cc -index 8905cd790b7d4c81b907107cae6cd00a8d731706..ca79072ec325d4b2ab52ac8e8344365648f0df77 100644 +index aaf2d7839245b46d60f54bbaa8fd28ade00401f3..0b5efe1b330f7405d88748d80aad189182d408db 100644 --- a/chrome/browser/accessibility/accessibility_ui.cc +++ b/chrome/browser/accessibility/accessibility_ui.cc @@ -20,7 +20,10 @@ diff --git a/patches/chromium/fix_properly_honor_printing_page_ranges.patch b/patches/chromium/fix_properly_honor_printing_page_ranges.patch index 33452ef9b80cf..10aee33cb17c7 100644 --- a/patches/chromium/fix_properly_honor_printing_page_ranges.patch +++ b/patches/chromium/fix_properly_honor_printing_page_ranges.patch @@ -25,10 +25,10 @@ index 0fb5c91b8abcdd7e674251bafebfc2c51044ef77..8c134bae25afeb0dbbb6e33182f053bb // Returns true if duplex mode is set. bool SetDuplexModeInPrintSettings(mojom::DuplexMode mode); diff --git a/printing/printing_context_mac.mm b/printing/printing_context_mac.mm -index 9f80fe6f10515849dd02d580db9852e6fbbbaa30..67f5b76a8141857ba02abd806341f06b07a4ebdc 100644 +index dfa69dfec319e48e1475cf8b40ec7414cab00e5e..6dcff7c9b0b5f9ad1e41407037b96ba52f313977 100644 --- a/printing/printing_context_mac.mm +++ b/printing/printing_context_mac.mm -@@ -190,7 +190,8 @@ PMPaper MatchPaper(CFArrayRef paper_list, +@@ -191,7 +191,8 @@ PMPaper MatchPaper(CFArrayRef paper_list, !SetCollateInPrintSettings(settings_->collate()) || !SetDuplexModeInPrintSettings(settings_->duplex_mode()) || !SetOutputColor(static_cast(settings_->color())) || @@ -38,7 +38,7 @@ index 9f80fe6f10515849dd02d580db9852e6fbbbaa30..67f5b76a8141857ba02abd806341f06b return OnError(); } } -@@ -343,6 +344,22 @@ PMPaper MatchPaper(CFArrayRef paper_list, +@@ -344,6 +345,22 @@ PMPaper MatchPaper(CFArrayRef paper_list, return PMSetCopies(print_settings, copies, false) == noErr; } diff --git a/patches/chromium/fix_use_electron_generated_resources.patch b/patches/chromium/fix_use_electron_generated_resources.patch index d6eb8a83d8e1c..a5b5f9212a200 100644 --- a/patches/chromium/fix_use_electron_generated_resources.patch +++ b/patches/chromium/fix_use_electron_generated_resources.patch @@ -26,28 +26,28 @@ index f72431f5bc7ba82316cf318f7845e7523c366d92..5133f3cd28c0d630a039118eb91c6c37 #include "components/zoom/page_zoom_constants.h" #include "pdf/pdf_features.h" diff --git a/chrome/browser/printing/printing_service.cc b/chrome/browser/printing/printing_service.cc -index 2b73b110049b5e8d28b52656bbd2423e18ba07a0..8fd868b39d64c74aa189b8ca3e24c8537d91b1ba 100644 +index 986568e30a4c40104a4e2a681a1b8a22110d4cf8..36758a9ee5eea37ce5199460bb9dc893d7bf250f 100644 --- a/chrome/browser/printing/printing_service.cc +++ b/chrome/browser/printing/printing_service.cc -@@ -6,7 +6,7 @@ +@@ -5,7 +5,7 @@ + #include "chrome/browser/printing/printing_service.h" #include "base/no_destructor.h" - #include "chrome/browser/service_sandbox_type.h" -#include "chrome/grit/generated_resources.h" +#include "electron/grit/electron_resources.h" + #include "chrome/services/printing/public/mojom/printing_service.mojom.h" #include "content/public/browser/service_process_host.h" - const mojo::Remote& GetPrintingService() { diff --git a/chrome/browser/win/icon_reader_service.cc b/chrome/browser/win/icon_reader_service.cc -index 721e1a863cc6925908f8343002df056f2373bf0b..10b2a95162541a8ff4d010c7be864f3f41dae378 100644 +index d5497a7e26cdb66c7c074bc509e2bfec7d7875cd..62d2f555253eef903bd04ff1a0ad37d1470309e0 100644 --- a/chrome/browser/win/icon_reader_service.cc +++ b/chrome/browser/win/icon_reader_service.cc -@@ -5,7 +5,7 @@ +@@ -4,7 +4,7 @@ + #include "chrome/browser/win/icon_reader_service.h" - #include "chrome/browser/service_sandbox_type.h" -#include "chrome/grit/generated_resources.h" +#include "electron/grit/electron_resources.h" + #include "chrome/services/util_win/public/mojom/util_read_icon.mojom.h" #include "content/public/browser/service_process_host.h" - mojo::Remote LaunchIconReaderInstance() { diff --git a/patches/chromium/frame_host_manager.patch b/patches/chromium/frame_host_manager.patch index 567921d74fee3..01841f3ea6ad4 100644 --- a/patches/chromium/frame_host_manager.patch +++ b/patches/chromium/frame_host_manager.patch @@ -6,10 +6,10 @@ Subject: frame_host_manager.patch Allows embedder to intercept site instances created by chromium. diff --git a/content/browser/renderer_host/render_frame_host_manager.cc b/content/browser/renderer_host/render_frame_host_manager.cc -index 93416b8626adc4495f02dac56f106727e83ff427..c37624b1a2af3fbd4f42c2e11e5b7b46a82bf1df 100644 +index 680efc8fe2df3b40cf20bc18c396e661f674a55f..c3e1a28ea8df5a20ba735e46bbc4bf749ba553d3 100644 --- a/content/browser/renderer_host/render_frame_host_manager.cc +++ b/content/browser/renderer_host/render_frame_host_manager.cc -@@ -3078,6 +3078,9 @@ RenderFrameHostManager::GetSiteInstanceForNavigationRequest( +@@ -2986,6 +2986,9 @@ RenderFrameHostManager::GetSiteInstanceForNavigationRequest( request->ResetStateForSiteInstanceChange(); } @@ -20,10 +20,10 @@ index 93416b8626adc4495f02dac56f106727e83ff427..c37624b1a2af3fbd4f42c2e11e5b7b46 } diff --git a/content/public/browser/content_browser_client.h b/content/public/browser/content_browser_client.h -index 75227e160dda6724e59271e702c956ea1470a40e..19a146dcac3e3acfcd23e64fec3f7993aa4a92bd 100644 +index bb30bb3604a793cbe37d20a3a18b21d5abfd6530..24b8927b4224eb890b5377b88dd8060b4dcfd648 100644 --- a/content/public/browser/content_browser_client.h +++ b/content/public/browser/content_browser_client.h -@@ -269,6 +269,11 @@ class CONTENT_EXPORT ContentBrowserClient { +@@ -272,6 +272,11 @@ class CONTENT_EXPORT ContentBrowserClient { virtual ~ContentBrowserClient() = default; diff --git a/patches/chromium/gin_enable_disable_v8_platform.patch b/patches/chromium/gin_enable_disable_v8_platform.patch index db487d6cf0d05..2b8c28383b231 100644 --- a/patches/chromium/gin_enable_disable_v8_platform.patch +++ b/patches/chromium/gin_enable_disable_v8_platform.patch @@ -7,10 +7,10 @@ We don't use gin to create the V8 platform, because we need to inject Node things. diff --git a/gin/isolate_holder.cc b/gin/isolate_holder.cc -index f86478fb8652255fa30252d027bfed2121ed138e..5eed541856097c2edf12c49a6a04dc583a9cceb6 100644 +index e93824463817a71903631dd722ffdfddb65bab3e..366e105c968b1be51eb0f26709486d086cf12eca 100644 --- a/gin/isolate_holder.cc +++ b/gin/isolate_holder.cc -@@ -108,9 +108,10 @@ IsolateHolder::~IsolateHolder() { +@@ -110,9 +110,10 @@ IsolateHolder::~IsolateHolder() { // static void IsolateHolder::Initialize(ScriptMode mode, v8::ArrayBuffer::Allocator* allocator, @@ -24,10 +24,10 @@ index f86478fb8652255fa30252d027bfed2121ed138e..5eed541856097c2edf12c49a6a04dc58 g_reference_table = reference_table; } diff --git a/gin/public/isolate_holder.h b/gin/public/isolate_holder.h -index 41e516899dccb6352aabadcd66a93d69e13031b6..e476c6b4a58caa30d81d082200bfd8c80904857a 100644 +index f0a7d0c05fa3c68b22b1d36e2c0810fe70f5a8a0..8ecce17b5bb8b5106de913a2d0197fd3affb1c08 100644 --- a/gin/public/isolate_holder.h +++ b/gin/public/isolate_holder.h -@@ -89,7 +89,8 @@ class GIN_EXPORT IsolateHolder { +@@ -94,7 +94,8 @@ class GIN_EXPORT IsolateHolder { // reference pointers. Otherwise, it can be nullptr. static void Initialize(ScriptMode mode, v8::ArrayBuffer::Allocator* allocator, @@ -38,10 +38,10 @@ index 41e516899dccb6352aabadcd66a93d69e13031b6..e476c6b4a58caa30d81d082200bfd8c8 // Returns whether `Initialize` has already been invoked in the process. // Initialization is a one-way operation (i.e., this method cannot return diff --git a/gin/v8_initializer.cc b/gin/v8_initializer.cc -index 042ce4e6d0cb20686d3493ba034dcf41edcd658c..a9b2c43bacdf851b12c24b53080b40585405c4ae 100644 +index 941ced089ed7e201d348b58b38d9d0d74bc843b1..9c78e04219e5bcd8d8044e576367833d0891f7d6 100644 --- a/gin/v8_initializer.cc +++ b/gin/v8_initializer.cc -@@ -267,7 +267,8 @@ void SetV8FlagsIfOverridden(const base::Feature& feature, +@@ -269,7 +269,8 @@ void SetV8FlagsIfOverridden(const base::Feature& feature, } // namespace // static @@ -51,7 +51,7 @@ index 042ce4e6d0cb20686d3493ba034dcf41edcd658c..a9b2c43bacdf851b12c24b53080b4058 static bool v8_is_initialized = false; if (v8_is_initialized) return; -@@ -277,7 +278,8 @@ void V8Initializer::Initialize(IsolateHolder::ScriptMode mode) { +@@ -279,7 +280,8 @@ void V8Initializer::Initialize(IsolateHolder::ScriptMode mode) { RunArrayBufferCageReservationExperiment(); } @@ -62,10 +62,10 @@ index 042ce4e6d0cb20686d3493ba034dcf41edcd658c..a9b2c43bacdf851b12c24b53080b4058 if (!base::FeatureList::IsEnabled(features::kV8OptimizeJavascript)) { // We avoid explicitly passing --opt if kV8OptimizeJavascript is enabled diff --git a/gin/v8_initializer.h b/gin/v8_initializer.h -index 2918c6235688ee4eb7c43387296e6d24145c14aa..069c2c96d5067f0444dac3c6ce6d83f75e770129 100644 +index 955be10e118e1c54515dd0ee19edec7504419bdc..699f84c73b71a6d870ae93f2fce98174c924e2fa 100644 --- a/gin/v8_initializer.h +++ b/gin/v8_initializer.h -@@ -20,7 +20,8 @@ namespace gin { +@@ -24,7 +24,8 @@ namespace gin { class GIN_EXPORT V8Initializer { public: // This should be called by IsolateHolder::Initialize(). diff --git a/patches/chromium/gritsettings_resource_ids.patch b/patches/chromium/gritsettings_resource_ids.patch index d930974e3cea5..4d91a2c86b23b 100644 --- a/patches/chromium/gritsettings_resource_ids.patch +++ b/patches/chromium/gritsettings_resource_ids.patch @@ -6,10 +6,10 @@ Subject: gritsettings_resource_ids.patch Add electron resources file to the list of resource ids generation. diff --git a/tools/gritsettings/resource_ids.spec b/tools/gritsettings/resource_ids.spec -index 50dded5f9fcbc3620d78f83d0c9210aeacd9ba34..1b2dbfa0fb76c5d2cafbda956d486acc6c13ab5d 100644 +index 7a0344321c3050ec9a3c7c5346e2f391ab133b36..6f4750bb6bbbd0fde2c03596fba9de2e050aecc3 100644 --- a/tools/gritsettings/resource_ids.spec +++ b/tools/gritsettings/resource_ids.spec -@@ -844,6 +844,11 @@ +@@ -850,6 +850,11 @@ "includes": [3880], }, diff --git a/patches/chromium/hack_to_allow_gclient_sync_with_host_os_mac_on_linux_in_ci.patch b/patches/chromium/hack_to_allow_gclient_sync_with_host_os_mac_on_linux_in_ci.patch index 7273396577c67..fa0198c2c5314 100644 --- a/patches/chromium/hack_to_allow_gclient_sync_with_host_os_mac_on_linux_in_ci.patch +++ b/patches/chromium/hack_to_allow_gclient_sync_with_host_os_mac_on_linux_in_ci.patch @@ -11,7 +11,7 @@ If removing this patch causes no sync failures, it's safe to delete :+1: Ref https://chromium-review.googlesource.com/c/chromium/src/+/2953903 diff --git a/tools/clang/scripts/update.py b/tools/clang/scripts/update.py -index 57107a56480343778baf3445fd5725ac8130dd52..56b1a39e7883c89fbf27a205c136fc2c12a785f5 100755 +index 95ba8a59241ed74b0c85ccf1fd480acb0bb9b82d..474f14af183e2fbbed9977b0f1d815fe7bf86889 100755 --- a/tools/clang/scripts/update.py +++ b/tools/clang/scripts/update.py @@ -286,6 +286,8 @@ def main(): diff --git a/patches/chromium/isolate_holder.patch b/patches/chromium/isolate_holder.patch index 956253fed8f20..d7ae1459dc530 100644 --- a/patches/chromium/isolate_holder.patch +++ b/patches/chromium/isolate_holder.patch @@ -15,10 +15,10 @@ for us to register the isolate in between Isolate::Allocate and Isolate::Initialize. diff --git a/gin/isolate_holder.cc b/gin/isolate_holder.cc -index 5eed541856097c2edf12c49a6a04dc583a9cceb6..beea6526a0e7b2170f21fdc7d26b7c50cd334691 100644 +index 366e105c968b1be51eb0f26709486d086cf12eca..70ba5d0ecd8c4c10628db11818012e620895684b 100644 --- a/gin/isolate_holder.cc +++ b/gin/isolate_holder.cc -@@ -53,7 +53,8 @@ IsolateHolder::IsolateHolder( +@@ -55,7 +55,8 @@ IsolateHolder::IsolateHolder( AccessMode access_mode, AllowAtomicsWaitMode atomics_wait_mode, IsolateType isolate_type, @@ -28,7 +28,7 @@ index 5eed541856097c2edf12c49a6a04dc583a9cceb6..beea6526a0e7b2170f21fdc7d26b7c50 : access_mode_(access_mode), isolate_type_(isolate_type) { CHECK(Initialized()) << "You need to invoke gin::IsolateHolder::Initialize first"; -@@ -64,7 +65,11 @@ IsolateHolder::IsolateHolder( +@@ -66,7 +67,11 @@ IsolateHolder::IsolateHolder( v8::ArrayBuffer::Allocator* allocator = g_array_buffer_allocator; DCHECK(allocator); @@ -42,10 +42,10 @@ index 5eed541856097c2edf12c49a6a04dc583a9cceb6..beea6526a0e7b2170f21fdc7d26b7c50 access_mode_, task_runner); if (isolate_creation_mode == IsolateCreationMode::kCreateSnapshot) { diff --git a/gin/public/isolate_holder.h b/gin/public/isolate_holder.h -index e476c6b4a58caa30d81d082200bfd8c80904857a..ed7f738478b666811f32ae6598147bdca9877922 100644 +index 8ecce17b5bb8b5106de913a2d0197fd3affb1c08..554beedf1fd1e256466b144468b1338fc6ccd473 100644 --- a/gin/public/isolate_holder.h +++ b/gin/public/isolate_holder.h -@@ -74,7 +74,8 @@ class GIN_EXPORT IsolateHolder { +@@ -79,7 +79,8 @@ class GIN_EXPORT IsolateHolder { AccessMode access_mode, AllowAtomicsWaitMode atomics_wait_mode, IsolateType isolate_type, diff --git a/patches/chromium/mas_disable_remote_accessibility.patch b/patches/chromium/mas_disable_remote_accessibility.patch index 6b2cd1383da6e..f3afdbc13a621 100644 --- a/patches/chromium/mas_disable_remote_accessibility.patch +++ b/patches/chromium/mas_disable_remote_accessibility.patch @@ -11,7 +11,7 @@ needs to think it's coming from the PWA process). I think it can just be chopped out -- if there are any side-effects, we should be able to work around them. diff --git a/components/remote_cocoa/app_shim/application_bridge.mm b/components/remote_cocoa/app_shim/application_bridge.mm -index 9ddda9116e7284cbccde8a51e23ad7560dd06367..e846091ad99b0154636489e53491209ff3cbfaaa 100644 +index 6af35b457b4acc4bbbac36b2f8a2617495d9d1f4..3c377839a8882d8e842edd8ca4b9b64cfccc58f9 100644 --- a/components/remote_cocoa/app_shim/application_bridge.mm +++ b/components/remote_cocoa/app_shim/application_bridge.mm @@ -49,6 +49,7 @@ @@ -32,7 +32,7 @@ index 9ddda9116e7284cbccde8a51e23ad7560dd06367..e846091ad99b0154636489e53491209f } void DispatchKeyEvent(ui::KeyEvent* event) override { bool event_handled = false; -@@ -96,8 +100,10 @@ void GetWordAt(const gfx::Point& location_in_content, +@@ -97,8 +101,10 @@ void GetWordAt(const gfx::Point& location_in_content, mojo::AssociatedRemote text_input_host_remote_; std::unique_ptr bridge_; @@ -44,7 +44,7 @@ index 9ddda9116e7284cbccde8a51e23ad7560dd06367..e846091ad99b0154636489e53491209f } // namespace diff --git a/components/remote_cocoa/app_shim/native_widget_ns_window_bridge.mm b/components/remote_cocoa/app_shim/native_widget_ns_window_bridge.mm -index 89e8a69b2bbb28fb90314b19c062b47d618b7038..e3f6be21487823d1d96945f163a7865119ce5605 100644 +index 2a4679b620db93d9eeb45873a97f5daba6e19456..04414494a859438972cb266aabdd47687bdafca5 100644 --- a/components/remote_cocoa/app_shim/native_widget_ns_window_bridge.mm +++ b/components/remote_cocoa/app_shim/native_widget_ns_window_bridge.mm @@ -557,10 +557,12 @@ NSUInteger CountBridgedWindows(NSArray* child_windows) { @@ -87,10 +87,10 @@ index c3a9fbf0f9d2b80c1de42a22ad094a286f0b559b..02493d4b62c98a3aebd3e460c459218a DISALLOW_COPY_AND_ASSIGN(RenderWidgetHostNSViewBridgeOwner); }; diff --git a/content/browser/renderer_host/render_widget_host_view_mac.h b/content/browser/renderer_host/render_widget_host_view_mac.h -index 5eeea0e2f0ee51c21542dee1963c41b0e0401bc8..d54e2b86ce8ccb94cdc5c882fdd77a5417f4849c 100644 +index 0345506d7ca2a64737109f97524b563dd55ecc3a..3a58d7354feae315fff91ca12339da67f6cf3cfb 100644 --- a/content/browser/renderer_host/render_widget_host_view_mac.h +++ b/content/browser/renderer_host/render_widget_host_view_mac.h -@@ -47,7 +47,9 @@ class ScopedPasswordInputEnabler; +@@ -48,7 +48,9 @@ class ScopedPasswordInputEnabler; @protocol RenderWidgetHostViewMacDelegate; @@ -100,7 +100,7 @@ index 5eeea0e2f0ee51c21542dee1963c41b0e0401bc8..d54e2b86ce8ccb94cdc5c882fdd77a54 @class RenderWidgetHostViewCocoa; namespace content { -@@ -651,10 +653,12 @@ class CONTENT_EXPORT RenderWidgetHostViewMac +@@ -653,10 +655,12 @@ class CONTENT_EXPORT RenderWidgetHostViewMac // EnsureSurfaceSynchronizedForWebTest(). uint32_t latest_capture_sequence_number_ = 0u; @@ -114,7 +114,7 @@ index 5eeea0e2f0ee51c21542dee1963c41b0e0401bc8..d54e2b86ce8ccb94cdc5c882fdd77a54 // Used to force the NSApplication's focused accessibility element to be the // content::BrowserAccessibilityCocoa accessibility tree when the NSView for diff --git a/content/browser/renderer_host/render_widget_host_view_mac.mm b/content/browser/renderer_host/render_widget_host_view_mac.mm -index 2615d14ebae066833cf346d47641ce2fa5bde678..e9f3e0d499c53cebc20d417d396190f7dc384c69 100644 +index d5a4cbe5cf985221451488a0440a63818e85dc87..515d1588c0de8daa503df91338dc3a5c072c5690 100644 --- a/content/browser/renderer_host/render_widget_host_view_mac.mm +++ b/content/browser/renderer_host/render_widget_host_view_mac.mm @@ -240,8 +240,10 @@ @@ -128,7 +128,7 @@ index 2615d14ebae066833cf346d47641ce2fa5bde678..e9f3e0d499c53cebc20d417d396190f7 // Disconnect from the previous bridge (this will have the effect of // destroying the associated bridge), and close the receiver (to allow it -@@ -1438,8 +1440,10 @@ void CombineTextNodesAndMakeCallback(SpeechCallback callback, +@@ -1439,8 +1441,10 @@ void CombineTextNodesAndMakeCallback(SpeechCallback callback, gfx::NativeViewAccessible RenderWidgetHostViewMac::AccessibilityGetNativeViewAccessibleForWindow() { @@ -139,7 +139,7 @@ index 2615d14ebae066833cf346d47641ce2fa5bde678..e9f3e0d499c53cebc20d417d396190f7 return [GetInProcessNSView() window]; } -@@ -1483,9 +1487,11 @@ void CombineTextNodesAndMakeCallback(SpeechCallback callback, +@@ -1484,9 +1488,11 @@ void CombineTextNodesAndMakeCallback(SpeechCallback callback, } void RenderWidgetHostViewMac::SetAccessibilityWindow(NSWindow* window) { @@ -151,7 +151,7 @@ index 2615d14ebae066833cf346d47641ce2fa5bde678..e9f3e0d499c53cebc20d417d396190f7 } bool RenderWidgetHostViewMac::SyncIsWidgetForMainFrame( -@@ -1979,12 +1985,14 @@ void CombineTextNodesAndMakeCallback(SpeechCallback callback, +@@ -1980,12 +1986,14 @@ void CombineTextNodesAndMakeCallback(SpeechCallback callback, void RenderWidgetHostViewMac::SetRemoteAccessibilityWindowToken( const std::vector& window_token) { @@ -167,10 +167,10 @@ index 2615d14ebae066833cf346d47641ce2fa5bde678..e9f3e0d499c53cebc20d417d396190f7 /////////////////////////////////////////////////////////////////////////////// diff --git a/ui/base/BUILD.gn b/ui/base/BUILD.gn -index 338e600b4495096e45494b72d950a7c051e36097..e81bcb074d3dc78bd68433640928a2c6eff80fc5 100644 +index 32d0427d811b2c9b2c2591066c85fdd343850207..f93a10b1e2e37cb0d476ac7bdfa1302cf7864e7b 100644 --- a/ui/base/BUILD.gn +++ b/ui/base/BUILD.gn -@@ -320,6 +320,13 @@ component("base") { +@@ -322,6 +322,13 @@ component("base") { ] } @@ -205,7 +205,7 @@ index e7adfee3210ec723c687adfcc4bee8827ef643e7..25a924a47eeb30d783ef83dbb4896c4b + #endif // UI_BASE_COCOA_REMOTE_ACCESSIBILITY_API_H_ diff --git a/ui/views/cocoa/native_widget_mac_ns_window_host.h b/ui/views/cocoa/native_widget_mac_ns_window_host.h -index ce96d1bee29c8ee13f4a10bb17a7000b332637c8..74bfcc4eb8490f8b27363283372525dfffd11776 100644 +index 7277159ea1fae7778b6725bc97278a6721872a7e..787f5e072ea9e615bbd67b83ab0e9cc57d05549a 100644 --- a/ui/views/cocoa/native_widget_mac_ns_window_host.h +++ b/ui/views/cocoa/native_widget_mac_ns_window_host.h @@ -30,7 +30,9 @@ @@ -218,7 +218,7 @@ index ce96d1bee29c8ee13f4a10bb17a7000b332637c8..74bfcc4eb8490f8b27363283372525df @class NSView; namespace remote_cocoa { -@@ -424,11 +426,13 @@ class VIEWS_EXPORT NativeWidgetMacNSWindowHost +@@ -425,11 +427,13 @@ class VIEWS_EXPORT NativeWidgetMacNSWindowHost mojo::AssociatedRemote remote_ns_window_remote_; @@ -233,7 +233,7 @@ index ce96d1bee29c8ee13f4a10bb17a7000b332637c8..74bfcc4eb8490f8b27363283372525df // Used to force the NSApplication's focused accessibility element to be the // views::Views accessibility tree when the NSView for this is focused. diff --git a/ui/views/cocoa/native_widget_mac_ns_window_host.mm b/ui/views/cocoa/native_widget_mac_ns_window_host.mm -index da26f5e6bee82cb16d2a192e26f206e491b5a068..6b62858ddb2bf3e977550ee6d257e8d6d99d4d90 100644 +index c93fa3fd7ebbecbc6fa8eb7db485f39f3b05da9a..bef702754dd0c45037dddbadd2663ee88ad5301e 100644 --- a/ui/views/cocoa/native_widget_mac_ns_window_host.mm +++ b/ui/views/cocoa/native_widget_mac_ns_window_host.mm @@ -285,14 +285,22 @@ void HandleAccelerator(const ui::Accelerator& accelerator, @@ -259,7 +259,7 @@ index da26f5e6bee82cb16d2a192e26f206e491b5a068..6b62858ddb2bf3e977550ee6d257e8d6 } remote_cocoa::mojom::NativeWidgetNSWindow* -@@ -1201,6 +1209,7 @@ void HandleAccelerator(const ui::Accelerator& accelerator, +@@ -1205,6 +1213,7 @@ void HandleAccelerator(const ui::Accelerator& accelerator, void NativeWidgetMacNSWindowHost::SetRemoteAccessibilityTokens( const std::vector& window_token, const std::vector& view_token) { @@ -267,7 +267,7 @@ index da26f5e6bee82cb16d2a192e26f206e491b5a068..6b62858ddb2bf3e977550ee6d257e8d6 remote_window_accessible_ = ui::RemoteAccessibility::GetRemoteElementFromToken(window_token); remote_view_accessible_ = -@@ -1208,14 +1217,17 @@ void HandleAccelerator(const ui::Accelerator& accelerator, +@@ -1212,14 +1221,17 @@ void HandleAccelerator(const ui::Accelerator& accelerator, [remote_view_accessible_ setWindowUIElement:remote_window_accessible_.get()]; [remote_view_accessible_ setTopLevelUIElement:remote_window_accessible_.get()]; diff --git a/patches/chromium/mas_disable_remote_layer.patch b/patches/chromium/mas_disable_remote_layer.patch index e8847fdfae99f..9c54053caa4a1 100644 --- a/patches/chromium/mas_disable_remote_layer.patch +++ b/patches/chromium/mas_disable_remote_layer.patch @@ -16,7 +16,7 @@ cases where performance improves when disabling remote CoreAnimation (remote CoreAnimation is really only about battery usage). diff --git a/gpu/ipc/service/image_transport_surface_overlay_mac.h b/gpu/ipc/service/image_transport_surface_overlay_mac.h -index 2be155f12e8d1e66cf7123ed44246d2ac8537c3b..7bc2f4eded2ed1bc450f804f88663269c122b703 100644 +index c49b1befb9cd7bdcb5982db014ced3203b4fd561..c2a9347da27bc51cc2216520801d410c467f9b0b 100644 --- a/gpu/ipc/service/image_transport_surface_overlay_mac.h +++ b/gpu/ipc/service/image_transport_surface_overlay_mac.h @@ -20,7 +20,9 @@ @@ -29,7 +29,7 @@ index 2be155f12e8d1e66cf7123ed44246d2ac8537c3b..7bc2f4eded2ed1bc450f804f88663269 @class CALayer; namespace ui { -@@ -117,7 +119,9 @@ class ImageTransportSurfaceOverlayMacBase : public BaseClass, +@@ -118,7 +120,9 @@ class ImageTransportSurfaceOverlayMacBase : public BaseClass, base::WeakPtr delegate_; bool use_remote_layer_api_; @@ -40,7 +40,7 @@ index 2be155f12e8d1e66cf7123ed44246d2ac8537c3b..7bc2f4eded2ed1bc450f804f88663269 gfx::Size pixel_size_; diff --git a/gpu/ipc/service/image_transport_surface_overlay_mac.mm b/gpu/ipc/service/image_transport_surface_overlay_mac.mm -index efb3585ab339147158e8a80f967d373792ed758f..66d8d5ef9265455fea7ceba54e620fb5995e6d5b 100644 +index d7d7ab38ed248663bf0bb08a72b591c87e0b9459..07e243419f6d52af992fbdd009dce2d08f8adde2 100644 --- a/gpu/ipc/service/image_transport_surface_overlay_mac.mm +++ b/gpu/ipc/service/image_transport_surface_overlay_mac.mm @@ -53,7 +53,7 @@ diff --git a/patches/chromium/mas_no_private_api.patch b/patches/chromium/mas_no_private_api.patch index 18f81fbc08489..c2b0e40c8547a 100644 --- a/patches/chromium/mas_no_private_api.patch +++ b/patches/chromium/mas_no_private_api.patch @@ -7,10 +7,10 @@ Guard usages in blink of private Mac APIs by MAS_BUILD, so they can be excluded for people who want to submit their apps to the Mac App store. diff --git a/content/browser/accessibility/accessibility_tree_formatter_mac.mm b/content/browser/accessibility/accessibility_tree_formatter_mac.mm -index 6d3ddaf426f170431f68ed05f863a0913df89208..8630e3b40611fd92cd71d5e895c8091c8356e211 100644 +index 4bdefce738229f76f8fc9998733314284f5fa97a..699bf65a0e39a09d8689e85a55c203729b2f7e7e 100644 --- a/content/browser/accessibility/accessibility_tree_formatter_mac.mm +++ b/content/browser/accessibility/accessibility_tree_formatter_mac.mm -@@ -294,7 +294,7 @@ +@@ -289,7 +289,7 @@ return PopulateSize([value sizeValue]); } } @@ -19,7 +19,7 @@ index 6d3ddaf426f170431f68ed05f863a0913df89208..8630e3b40611fd92cd71d5e895c8091c // AXTextMarker if (content::IsAXTextMarker(value)) { return PopulateTextPosition(content::AXTextMarkerToAXPosition(value), -@@ -305,6 +305,7 @@ +@@ -300,6 +300,7 @@ if (content::IsAXTextMarkerRange(value)) { return PopulateTextMarkerRange(value, line_indexer); } @@ -27,7 +27,7 @@ index 6d3ddaf426f170431f68ed05f863a0913df89208..8630e3b40611fd92cd71d5e895c8091c // AXValue if (CFGetTypeID(value) == AXValueGetTypeID()) { -@@ -424,7 +425,7 @@ +@@ -419,7 +420,7 @@ AXMakeConst(affinity)); return set; } @@ -36,7 +36,7 @@ index 6d3ddaf426f170431f68ed05f863a0913df89208..8630e3b40611fd92cd71d5e895c8091c base::Value AccessibilityTreeFormatterMac::PopulateTextMarkerRange( id marker_range, const LineIndexer* line_indexer) const { -@@ -440,7 +441,7 @@ +@@ -435,7 +436,7 @@ PopulateTextPosition(ax_range.focus()->Clone(), line_indexer)); return dict; } @@ -148,10 +148,10 @@ index 4ce4b7ebcf8be625619e6fee0cab4185add42454..eca83c0807e37c36022a29187b1dc1c8 OptionalNSObject MakePairArray(const OptionalNSObject& obj1, const OptionalNSObject& obj2) { diff --git a/content/browser/accessibility/browser_accessibility_cocoa.h b/content/browser/accessibility/browser_accessibility_cocoa.h -index c786676b3758d004601b786c4de87f1b874f2fb7..6ae540b44f2ce1ce8aea1c43d86b600f867c62b4 100644 +index eb62bcb05aa03a8ff0a09c1a5109af2bdb8c66b7..f14557a9ac49488b345bf64747125e51a3cf8139 100644 --- a/content/browser/accessibility/browser_accessibility_cocoa.h +++ b/content/browser/accessibility/browser_accessibility_cocoa.h -@@ -159,7 +159,9 @@ id AXTextMarkerRangeFrom(id anchor_text_marker, id focus_text_marker); +@@ -161,7 +161,9 @@ id AXTextMarkerRangeFrom(id anchor_text_marker, id focus_text_marker); @property(nonatomic, readonly) NSNumber* enabled; // Returns a text marker that points to the last character in the document that // can be selected with Voiceover. @@ -161,7 +161,7 @@ index c786676b3758d004601b786c4de87f1b874f2fb7..6ae540b44f2ce1ce8aea1c43d86b600f @property(nonatomic, readonly) NSNumber* expanded; @property(nonatomic, readonly) NSNumber* focused; @property(nonatomic, readonly) NSNumber* grabbed; -@@ -171,7 +173,9 @@ id AXTextMarkerRangeFrom(id anchor_text_marker, id focus_text_marker); +@@ -173,7 +175,9 @@ id AXTextMarkerRangeFrom(id anchor_text_marker, id focus_text_marker); // Index of a row, column, or tree item. @property(nonatomic, readonly) NSNumber* index; @property(nonatomic, readonly) NSNumber* treeItemRowIndex; @@ -171,7 +171,7 @@ index c786676b3758d004601b786c4de87f1b874f2fb7..6ae540b44f2ce1ce8aea1c43d86b600f @property(nonatomic, readonly) NSString* invalid; @property(nonatomic, readonly) NSNumber* isMultiSelectable; @property(nonatomic, readonly) NSString* placeholderValue; -@@ -194,14 +198,18 @@ id AXTextMarkerRangeFrom(id anchor_text_marker, id focus_text_marker); +@@ -196,14 +200,18 @@ id AXTextMarkerRangeFrom(id anchor_text_marker, id focus_text_marker); // The object is selected as a whole. @property(nonatomic, readonly) NSNumber* selected; @property(nonatomic, readonly) NSArray* selectedChildren; @@ -191,10 +191,10 @@ index c786676b3758d004601b786c4de87f1b874f2fb7..6ae540b44f2ce1ce8aea1c43d86b600f // is concerned. @property(nonatomic, readonly) NSString* subrole; diff --git a/content/browser/accessibility/browser_accessibility_cocoa.mm b/content/browser/accessibility/browser_accessibility_cocoa.mm -index f3cb26f6310ad95edba124828be17939e3b36fa9..ab6c0c2010a2aac4cf94349ca446fbb94423f672 100644 +index 4ad415b3d71dfb8aa419088ef43436003b16a182..8ad9a55531ed17be240986036e0cf42f8fb9e36e 100644 --- a/content/browser/accessibility/browser_accessibility_cocoa.mm +++ b/content/browser/accessibility/browser_accessibility_cocoa.mm -@@ -205,6 +205,7 @@ +@@ -206,6 +206,7 @@ NSString* const NSAccessibilityLengthForTextMarkerRangeParameterizedAttribute = @"AXLengthForTextMarkerRange"; @@ -202,7 +202,7 @@ index f3cb26f6310ad95edba124828be17939e3b36fa9..ab6c0c2010a2aac4cf94349ca446fbb9 // Private attributes that can be used for testing text markers, e.g. in dump // tree tests. NSString* const -@@ -216,6 +217,7 @@ +@@ -217,6 +218,7 @@ NSString* const NSAccessibilityTextMarkerNodeDebugDescriptionParameterizedAttribute = @"AXTextMarkerNodeDebugDescription"; @@ -210,7 +210,7 @@ index f3cb26f6310ad95edba124828be17939e3b36fa9..ab6c0c2010a2aac4cf94349ca446fbb9 // Other private attributes. NSString* const NSAccessibilityIdentifierChromeAttribute = @"ChromeAXNodeId"; -@@ -240,6 +242,7 @@ +@@ -241,6 +243,7 @@ // VoiceOver uses -1 to mean "no limit" for AXResultsLimit. const int kAXResultsLimitNoLimit = -1; @@ -218,7 +218,7 @@ index f3cb26f6310ad95edba124828be17939e3b36fa9..ab6c0c2010a2aac4cf94349ca446fbb9 extern "C" { // The following are private accessibility APIs required for cursor navigation -@@ -478,6 +481,7 @@ void AddMisspelledTextAttributes(const BrowserAccessibility::AXRange& ax_range, +@@ -479,6 +482,7 @@ void AddMisspelledTextAttributes(const BrowserAccessibility::AXRange& ax_range, AddMisspelledTextAttributes(ax_range, attributed_text); return attributed_text; } @@ -226,7 +226,7 @@ index f3cb26f6310ad95edba124828be17939e3b36fa9..ab6c0c2010a2aac4cf94349ca446fbb9 // Returns an autoreleased copy of the AXNodeData's attribute. NSString* NSStringForStringAttribute(BrowserAccessibility* browserAccessibility, -@@ -754,6 +758,7 @@ bool IsSelectedStateRelevant(BrowserAccessibility* item) { +@@ -755,6 +759,7 @@ bool IsSelectedStateRelevant(BrowserAccessibility* item) { 0 == strcmp([value objCType], @encode(NSRange)); } @@ -234,7 +234,7 @@ index f3cb26f6310ad95edba124828be17939e3b36fa9..ab6c0c2010a2aac4cf94349ca446fbb9 bool content::IsAXTextMarker(id object) { if (object == nil) return false; -@@ -797,6 +802,7 @@ bool IsSelectedStateRelevant(BrowserAccessibility* item) { +@@ -798,6 +803,7 @@ bool IsSelectedStateRelevant(BrowserAccessibility* item) { kCFAllocatorDefault, anchor_textmarker, focus_textmarker); return [static_cast(cf_marker_range) autorelease]; } @@ -242,7 +242,7 @@ index f3cb26f6310ad95edba124828be17939e3b36fa9..ab6c0c2010a2aac4cf94349ca446fbb9 @implementation BrowserAccessibilityCocoa -@@ -836,7 +842,9 @@ + (void)initialize { +@@ -838,7 +844,9 @@ + (void)initialize { {NSAccessibilityEditableAncestorAttribute, @"editableAncestor"}, {NSAccessibilityElementBusyAttribute, @"elementBusy"}, {NSAccessibilityEnabledAttribute, @"enabled"}, @@ -252,7 +252,7 @@ index f3cb26f6310ad95edba124828be17939e3b36fa9..ab6c0c2010a2aac4cf94349ca446fbb9 {NSAccessibilityExpandedAttribute, @"expanded"}, {NSAccessibilityFocusableAncestorAttribute, @"focusableAncestor"}, {NSAccessibilityFocusedAttribute, @"focused"}, -@@ -848,8 +856,10 @@ + (void)initialize { +@@ -850,8 +858,10 @@ + (void)initialize { {NSAccessibilityHighestEditableAncestorAttribute, @"highestEditableAncestor"}, {NSAccessibilityIndexAttribute, @"index"}, @@ -263,7 +263,7 @@ index f3cb26f6310ad95edba124828be17939e3b36fa9..ab6c0c2010a2aac4cf94349ca446fbb9 {NSAccessibilityInvalidAttribute, @"invalid"}, {NSAccessibilityIsMultiSelectableAttribute, @"isMultiSelectable"}, {NSAccessibilityLanguageAttribute, @"language"}, -@@ -872,13 +882,17 @@ + (void)initialize { +@@ -874,13 +884,17 @@ + (void)initialize { {NSAccessibilityRowsAttribute, @"rows"}, // TODO(aboxhall): expose // NSAccessibilityServesAsTitleForUIElementsAttribute @@ -281,7 +281,7 @@ index f3cb26f6310ad95edba124828be17939e3b36fa9..ab6c0c2010a2aac4cf94349ca446fbb9 {NSAccessibilitySizeAttribute, @"size"}, {NSAccessibilitySortDirectionAttribute, @"sortDirection"}, {NSAccessibilitySubroleAttribute, @"subrole"}, -@@ -1383,6 +1397,7 @@ - (NSNumber*)enabled { +@@ -1408,6 +1422,7 @@ - (NSNumber*)enabled { ax::mojom::Restriction::kDisabled); } @@ -289,7 +289,7 @@ index f3cb26f6310ad95edba124828be17939e3b36fa9..ab6c0c2010a2aac4cf94349ca446fbb9 // Returns a text marker that points to the last character in the document that // can be selected with VoiceOver. - (id)endTextMarker { -@@ -1391,6 +1406,7 @@ - (id)endTextMarker { +@@ -1416,6 +1431,7 @@ - (id)endTextMarker { BrowserAccessibility::AXPosition position = _owner->CreateTextPositionAt(0); return CreateTextMarker(position->CreatePositionAtEndOfContent()); } @@ -297,15 +297,15 @@ index f3cb26f6310ad95edba124828be17939e3b36fa9..ab6c0c2010a2aac4cf94349ca446fbb9 - (NSNumber*)expanded { if (![self instanceActive]) -@@ -1591,6 +1607,7 @@ - (bool)findRowIndex:(BrowserAccessibilityCocoa*)toFind +@@ -1616,6 +1632,7 @@ - (bool)findRowIndex:(BrowserAccessibilityCocoa*)toFind return false; } +#ifndef MAS_BUILD - - (NSNumber*)insertionPointLineNumber { - if (![self instanceActive]) - return nil; -@@ -1616,6 +1633,7 @@ - (NSNumber*)insertionPointLineNumber { + - (NSNumber*)AXInsertionPointLineNumber { + return [self insertionPointLineNumber]; + } +@@ -1645,6 +1662,7 @@ - (NSNumber*)insertionPointLineNumber { caretPosition->AsTextPosition()->text_offset()); return @(std::distance(lineBreaks.begin(), iterator)); } @@ -313,7 +313,7 @@ index f3cb26f6310ad95edba124828be17939e3b36fa9..ab6c0c2010a2aac4cf94349ca446fbb9 // Returns whether or not this node should be ignored in the // accessibility tree. -@@ -1974,8 +1992,12 @@ - (BOOL)shouldExposeTitleUIElement { +@@ -2012,8 +2030,12 @@ - (BOOL)shouldExposeTitleUIElement { return content::AXTextEdit(newValue, std::u16string(), nil); } } @@ -326,29 +326,15 @@ index f3cb26f6310ad95edba124828be17939e3b36fa9..ab6c0c2010a2aac4cf94349ca446fbb9 } - (BOOL)instanceActive { -@@ -2301,6 +2323,7 @@ - (NSArray*)selectedChildren { +@@ -2346,6 +2368,7 @@ - (NSArray*)selectedChildren { return ret; } +#ifndef MAS_BUILD - - (NSString*)selectedText { - if (![self instanceActive]) - return nil; -@@ -2312,11 +2335,13 @@ - (NSString*)selectedText { - return nil; - return base::SysUTF16ToNSString(range.GetText()); + - (NSString*)AXSelectedText { + return [self selectedText]; } -+#endif - - // Returns range of text under the current object that is selected. - // - // Example, caret at offset 5: - // NSRange: “pos=5 len=0” -+#ifndef MAS_BUILD - - (NSValue*)selectedTextRange { - if (![self instanceActive]) - return nil; -@@ -2341,7 +2366,9 @@ - (NSValue*)selectedTextRange { +@@ -2394,7 +2417,9 @@ - (NSValue*)selectedTextRange { int selLength = range.GetText().length(); return [NSValue valueWithRange:NSMakeRange(selStart, selLength)]; } @@ -358,7 +344,7 @@ index f3cb26f6310ad95edba124828be17939e3b36fa9..ab6c0c2010a2aac4cf94349ca446fbb9 - (id)selectedTextMarkerRange { if (![self instanceActive]) return nil; -@@ -2353,6 +2380,7 @@ - (id)selectedTextMarkerRange { +@@ -2406,6 +2431,7 @@ - (id)selectedTextMarkerRange { // words correctly. return CreateTextMarkerRange(ax_range.AsBackwardRange()); } @@ -366,7 +352,7 @@ index f3cb26f6310ad95edba124828be17939e3b36fa9..ab6c0c2010a2aac4cf94349ca446fbb9 - (NSValue*)size { if (![self instanceActive]) -@@ -2385,6 +2413,7 @@ - (NSString*)sortDirection { +@@ -2438,6 +2464,7 @@ - (NSString*)sortDirection { return nil; } @@ -374,15 +360,15 @@ index f3cb26f6310ad95edba124828be17939e3b36fa9..ab6c0c2010a2aac4cf94349ca446fbb9 // Returns a text marker that points to the first character in the document that // can be selected with VoiceOver. - (id)startTextMarker { -@@ -2393,6 +2422,7 @@ - (id)startTextMarker { +@@ -2446,6 +2473,7 @@ - (id)startTextMarker { BrowserAccessibility::AXPosition position = _owner->CreateTextPositionAt(0); return CreateTextMarker(position->CreatePositionAtStartOfContent()); } +#endif - // Returns a subrole based upon the role. - - (NSString*)subrole { -@@ -2726,12 +2756,14 @@ - (NSAttributedString*)attributedValueForRange:(NSRange)range { + - (NSString*)AXSubrole { + return [self subrole]; +@@ -2793,12 +2821,14 @@ - (NSAttributedString*)attributedValueForRange:(NSRange)range { NSMutableAttributedString* attributedInnerText = [[[NSMutableAttributedString alloc] initWithString:base::SysUTF16ToNSString(innerText)] autorelease]; @@ -397,7 +383,7 @@ index f3cb26f6310ad95edba124828be17939e3b36fa9..ab6c0c2010a2aac4cf94349ca446fbb9 return [attributedInnerText attributedSubstringFromRange:range]; } -@@ -2844,6 +2876,7 @@ - (id)accessibilityAttributeValue:(NSString*)attribute +@@ -2930,6 +2960,7 @@ - (id)accessibilityAttributeValue:(NSString*)attribute return ToBrowserAccessibilityCocoa(cell); } @@ -405,7 +391,7 @@ index f3cb26f6310ad95edba124828be17939e3b36fa9..ab6c0c2010a2aac4cf94349ca446fbb9 if ([attribute isEqualToString: NSAccessibilityUIElementForTextMarkerParameterizedAttribute]) { -@@ -3167,6 +3200,7 @@ - (id)accessibilityAttributeValue:(NSString*)attribute +@@ -3253,6 +3284,7 @@ - (id)accessibilityAttributeValue:(NSString*)attribute return CreateTextMarker(root->CreateTextPositionAt(index)); } @@ -413,7 +399,7 @@ index f3cb26f6310ad95edba124828be17939e3b36fa9..ab6c0c2010a2aac4cf94349ca446fbb9 if ([attribute isEqualToString: NSAccessibilityBoundsForRangeParameterizedAttribute]) { -@@ -3197,6 +3231,7 @@ - (id)accessibilityAttributeValue:(NSString*)attribute +@@ -3283,6 +3315,7 @@ - (id)accessibilityAttributeValue:(NSString*)attribute return nil; } @@ -421,7 +407,7 @@ index f3cb26f6310ad95edba124828be17939e3b36fa9..ab6c0c2010a2aac4cf94349ca446fbb9 if ([attribute isEqualToString: NSAccessibilityLineTextMarkerRangeForTextMarkerParameterizedAttribute]) { -@@ -3316,6 +3351,7 @@ - (id)accessibilityAttributeValue:(NSString*)attribute +@@ -3402,6 +3435,7 @@ - (id)accessibilityAttributeValue:(NSString*)attribute return @(child->GetIndexInParent()); } @@ -429,7 +415,7 @@ index f3cb26f6310ad95edba124828be17939e3b36fa9..ab6c0c2010a2aac4cf94349ca446fbb9 return nil; } -@@ -3852,6 +3888,7 @@ - (void)accessibilitySetValue:(id)value forAttribute:(NSString*)attribute { +@@ -3971,6 +4005,7 @@ - (void)accessibilitySetValue:(id)value forAttribute:(NSString*)attribute { ->AsTextSelectionPosition())); } } @@ -437,7 +423,7 @@ index f3cb26f6310ad95edba124828be17939e3b36fa9..ab6c0c2010a2aac4cf94349ca446fbb9 if ([attribute isEqualToString:NSAccessibilitySelectedTextMarkerRangeAttribute]) { BrowserAccessibility::AXRange range = CreateRangeFromTextMarkerRange(value); -@@ -3862,6 +3899,7 @@ - (void)accessibilitySetValue:(id)value forAttribute:(NSString*)attribute { +@@ -3981,6 +4016,7 @@ - (void)accessibilitySetValue:(id)value forAttribute:(NSString*)attribute { range.anchor()->AsTextSelectionPosition(), range.focus()->AsTextSelectionPosition())); } @@ -446,10 +432,10 @@ index f3cb26f6310ad95edba124828be17939e3b36fa9..ab6c0c2010a2aac4cf94349ca446fbb9 - (id)accessibilityFocusedUIElement { diff --git a/content/browser/accessibility/browser_accessibility_manager_mac.mm b/content/browser/accessibility/browser_accessibility_manager_mac.mm -index 91e7c04b310eedb4fa4e6aa4c186a7f8a80b1e3c..37508b4566c8ffd6a6f2996138f875e3cc2245cf 100644 +index 58f6c6ad44112166f4ff14912a2cc2b8be81c887..716a83853985dced4ec09d137e84dd0356e4aa2c 100644 --- a/content/browser/accessibility/browser_accessibility_manager_mac.mm +++ b/content/browser/accessibility/browser_accessibility_manager_mac.mm -@@ -501,7 +501,7 @@ void PostAnnouncementNotification(NSString* announcement) { +@@ -502,7 +502,7 @@ void PostAnnouncementNotification(NSString* announcement) { if (native_focus_object && [native_focus_object instanceActive]) { [user_info setObject:native_focus_object forKey:ui::NSAccessibilityTextChangeElement]; @@ -458,7 +444,7 @@ index 91e7c04b310eedb4fa4e6aa4c186a7f8a80b1e3c..37508b4566c8ffd6a6f2996138f875e3 id selected_text = [native_focus_object selectedTextMarkerRange]; if (selected_text) { NSString* const NSAccessibilitySelectedTextMarkerRangeAttribute = -@@ -509,6 +509,7 @@ void PostAnnouncementNotification(NSString* announcement) { +@@ -510,6 +510,7 @@ void PostAnnouncementNotification(NSString* announcement) { [user_info setObject:selected_text forKey:NSAccessibilitySelectedTextMarkerRangeAttribute]; } @@ -466,6 +452,24 @@ index 91e7c04b310eedb4fa4e6aa4c186a7f8a80b1e3c..37508b4566c8ffd6a6f2996138f875e3 } return user_info; +diff --git a/content/common/pseudonymization_salt.cc b/content/common/pseudonymization_salt.cc +index 28e003bef910abff022def659fe18d4cd0549f8a..530bcbdb5d350f6486dc1e8536f7b279be69e241 100644 +--- a/content/common/pseudonymization_salt.cc ++++ b/content/common/pseudonymization_salt.cc +@@ -41,11 +41,13 @@ uint32_t GetPseudonymizationSalt() { + uint32_t salt = g_salt.load(); + + if (salt == 0) { ++#ifndef MAS_BUILD + #if DCHECK_IS_ON() + // Only the Browser process needs to initialize the `salt` on demand. + // Other processes (identified via the IsProcessSandboxed heuristic) should + // receive the salt from their parent processes. + DCHECK(!sandbox::policy::Sandbox::IsProcessSandboxed()); ++#endif + #endif + salt = InitializeSalt(); + } diff --git a/content/renderer/renderer_main_platform_delegate_mac.mm b/content/renderer/renderer_main_platform_delegate_mac.mm index 894ac47e596c1c96a7e0659be80ed8a5629d0304..eca797a24df79b8502b9698e6ed8830ad1c5cb59 100644 --- a/content/renderer/renderer_main_platform_delegate_mac.mm diff --git a/patches/chromium/network_service_allow_remote_certificate_verification_logic.patch b/patches/chromium/network_service_allow_remote_certificate_verification_logic.patch index bfc49b7f9b021..d2623506fc3b1 100644 --- a/patches/chromium/network_service_allow_remote_certificate_verification_logic.patch +++ b/patches/chromium/network_service_allow_remote_certificate_verification_logic.patch @@ -7,10 +7,10 @@ This adds a callback from the network service that's used to implement session.setCertificateVerifyCallback. diff --git a/services/network/network_context.cc b/services/network/network_context.cc -index 57b5f7a56368bd27464df83d2d45dab8bb68fc30..94085578e6b80d082b5ac67730381c998a418601 100644 +index 13b458774a9b36388e2079231c786e38354974bc..3896a834cbb17bfe6ecfc602886ea7d77d7d5167 100644 --- a/services/network/network_context.cc +++ b/services/network/network_context.cc -@@ -117,6 +117,11 @@ +@@ -118,6 +118,11 @@ #include "services/network/web_transport.h" #include "third_party/abseil-cpp/absl/types/optional.h" @@ -22,7 +22,7 @@ index 57b5f7a56368bd27464df83d2d45dab8bb68fc30..94085578e6b80d082b5ac67730381c99 #if BUILDFLAG(IS_CT_SUPPORTED) #include "components/certificate_transparency/chrome_ct_policy_enforcer.h" #include "components/certificate_transparency/chrome_require_ct_delegate.h" -@@ -395,6 +400,79 @@ void GetCTPolicyConfigForCTLogInfo( +@@ -419,6 +424,79 @@ bool GetFullDataFilePath( } // namespace @@ -102,7 +102,7 @@ index 57b5f7a56368bd27464df83d2d45dab8bb68fc30..94085578e6b80d082b5ac67730381c99 constexpr uint32_t NetworkContext::kMaxOutstandingRequestsPerProcess; NetworkContext::PendingCertVerify::PendingCertVerify() = default; -@@ -624,6 +702,13 @@ void NetworkContext::SetClient( +@@ -643,6 +721,13 @@ void NetworkContext::SetClient( client_.Bind(std::move(client)); } @@ -116,7 +116,7 @@ index 57b5f7a56368bd27464df83d2d45dab8bb68fc30..94085578e6b80d082b5ac67730381c99 void NetworkContext::CreateURLLoaderFactory( mojo::PendingReceiver receiver, mojom::URLLoaderFactoryParamsPtr params) { -@@ -2080,6 +2165,9 @@ URLRequestContextOwner NetworkContext::MakeURLRequestContext( +@@ -2078,6 +2163,9 @@ URLRequestContextOwner NetworkContext::MakeURLRequestContext( std::move(cert_verifier)); cert_verifier = base::WrapUnique(cert_verifier_with_trust_anchors_); #endif // BUILDFLAG(IS_CHROMEOS_ASH) @@ -127,10 +127,10 @@ index 57b5f7a56368bd27464df83d2d45dab8bb68fc30..94085578e6b80d082b5ac67730381c99 builder.SetCertVerifier(IgnoreErrorsCertVerifier::MaybeWrapCertVerifier( diff --git a/services/network/network_context.h b/services/network/network_context.h -index 6912997330a1e1d52f558921e83e8d5fb3be85f9..db9baee0a272674db2eb807932fc8123b9c3a24d 100644 +index dedd877897901bec01e1cc55519a3c2ca656cd9b..00bcb6e3b31b7e61a36c6df96d39cd0d5cc5e28a 100644 --- a/services/network/network_context.h +++ b/services/network/network_context.h -@@ -98,6 +98,7 @@ class DomainReliabilityMonitor; +@@ -99,6 +99,7 @@ class DomainReliabilityMonitor; namespace network { class CertVerifierWithTrustAnchors; @@ -138,7 +138,7 @@ index 6912997330a1e1d52f558921e83e8d5fb3be85f9..db9baee0a272674db2eb807932fc8123 class CookieManager; class ExpectCTReporter; class HostResolver; -@@ -209,6 +210,8 @@ class COMPONENT_EXPORT(NETWORK_SERVICE) NetworkContext +@@ -210,6 +211,8 @@ class COMPONENT_EXPORT(NETWORK_SERVICE) NetworkContext void CreateURLLoaderFactory( mojo::PendingReceiver receiver, mojom::URLLoaderFactoryParamsPtr params) override; @@ -147,7 +147,7 @@ index 6912997330a1e1d52f558921e83e8d5fb3be85f9..db9baee0a272674db2eb807932fc8123 void ResetURLLoaderFactories() override; void GetCookieManager( mojo::PendingReceiver receiver) override; -@@ -736,6 +739,8 @@ class COMPONENT_EXPORT(NETWORK_SERVICE) NetworkContext +@@ -741,6 +744,8 @@ class COMPONENT_EXPORT(NETWORK_SERVICE) NetworkContext CertVerifierWithTrustAnchors* cert_verifier_with_trust_anchors_ = nullptr; #endif @@ -157,11 +157,11 @@ index 6912997330a1e1d52f558921e83e8d5fb3be85f9..db9baee0a272674db2eb807932fc8123 // CertNetFetcher is not used by the current platform, or if the actual // net::CertVerifier is instantiated outside of the network service. diff --git a/services/network/public/mojom/network_context.mojom b/services/network/public/mojom/network_context.mojom -index b51365f91caa268c2c9d24e85d7dc0ba3a3aa694..987e464333e1f8db3fa810dfa9aaa00e6dae6722 100644 +index 0d84746e3495fd233db239d97d5a71ab8daa43ac..9a4ab0a7493688e31acd119b816de69bfb47d9d7 100644 --- a/services/network/public/mojom/network_context.mojom +++ b/services/network/public/mojom/network_context.mojom -@@ -190,6 +190,17 @@ struct CTPolicy { - array excluded_legacy_spkis; +@@ -232,6 +232,17 @@ struct NetworkContextFilePaths { + mojo_base.mojom.FilePath? reporting_and_nel_store_database_name; }; +interface CertVerifierClient { @@ -178,7 +178,7 @@ index b51365f91caa268c2c9d24e85d7dc0ba3a3aa694..987e464333e1f8db3fa810dfa9aaa00e // Parameters for constructing a network context. struct NetworkContextParams { // Name used by memory tools to identify the context. -@@ -755,6 +766,9 @@ interface NetworkContext { +@@ -743,6 +754,9 @@ interface NetworkContext { // Sets a client for this network context. SetClient(pending_remote client); diff --git a/patches/chromium/notification_provenance.patch b/patches/chromium/notification_provenance.patch index 2189a9490ee95..3ce3ecc254521 100644 --- a/patches/chromium/notification_provenance.patch +++ b/patches/chromium/notification_provenance.patch @@ -108,10 +108,10 @@ index 78f9ab684d2eeef9a647d82ccb39c1b208e999d4..d55a4e51a0d263ec07ca115715cccc30 const GURL& document_url, mojo::PendingReceiver receiver); diff --git a/content/browser/renderer_host/render_process_host_impl.cc b/content/browser/renderer_host/render_process_host_impl.cc -index 36a63aac2ea769a75d596ad74310cf168de1be48..80826440781926cb6a244c62117f8e2964c701d0 100644 +index b96ad3f8b173d0425069dbb6ec5ea4e3690fd0fb..ca49f2c9de55e95024e5ff680794e09a53061ffd 100644 --- a/content/browser/renderer_host/render_process_host_impl.cc +++ b/content/browser/renderer_host/render_process_host_impl.cc -@@ -2299,7 +2299,7 @@ void RenderProcessHostImpl::CreateNotificationService( +@@ -2270,7 +2270,7 @@ void RenderProcessHostImpl::CreateNotificationService( document_url = rfh->GetLastCommittedURL(); storage_partition_impl_->GetPlatformNotificationContext()->CreateService( diff --git a/patches/chromium/pepper_plugin_support.patch b/patches/chromium/pepper_plugin_support.patch index e24b00d599b61..354f4999ba37e 100644 --- a/patches/chromium/pepper_plugin_support.patch +++ b/patches/chromium/pepper_plugin_support.patch @@ -7,7 +7,7 @@ This tweaks Chrome's pepper flash and PDF plugin support to make it usable from Electron. diff --git a/chrome/browser/renderer_host/pepper/pepper_isolated_file_system_message_filter.cc b/chrome/browser/renderer_host/pepper/pepper_isolated_file_system_message_filter.cc -index 66e5a32ca6021a712a82d918a6dcb44039f71bf2..ce1559ea6020825ad0fa996e3148ff2744fa00c4 100644 +index d75adab3141094e2897b2ed4ca9005bf82d70979..7ee78a7345e29a3ee8836a7a06af9a63258d7340 100644 --- a/chrome/browser/renderer_host/pepper/pepper_isolated_file_system_message_filter.cc +++ b/chrome/browser/renderer_host/pepper/pepper_isolated_file_system_message_filter.cc @@ -7,17 +7,21 @@ diff --git a/patches/chromium/printing.patch b/patches/chromium/printing.patch index 05095365b1196..e3493c43bf662 100644 --- a/patches/chromium/printing.patch +++ b/patches/chromium/printing.patch @@ -617,10 +617,10 @@ index 90236920457c931c86426049c6cbc30b592b597f..353178863eba37b9112e784ffa4b3519 #if BUILDFLAG(ENABLE_PRINT_PREVIEW) // Set options for print preset from source PDF document. diff --git a/printing/printing_context.cc b/printing/printing_context.cc -index 24cf547a45b76705ec4094bec219c53785781059..b81e7bcee4139dbfb4c5211f4164c53b864768bd 100644 +index 7f617267b4eefd6d7cf9db6a56aaffad5035bab4..df79c62570f02f581ecb69ab3c03eeebfc43c50e 100644 --- a/printing/printing_context.cc +++ b/printing/printing_context.cc -@@ -97,7 +97,6 @@ PrintingContext::Result PrintingContext::UsePdfSettings() { +@@ -115,7 +115,6 @@ PrintingContext::Result PrintingContext::UsePdfSettings() { PrintingContext::Result PrintingContext::UpdatePrintSettings( base::Value job_settings) { @@ -629,22 +629,26 @@ index 24cf547a45b76705ec4094bec219c53785781059..b81e7bcee4139dbfb4c5211f4164c53b std::unique_ptr settings = PrintSettingsFromJobSettings(job_settings); diff --git a/printing/printing_context.h b/printing/printing_context.h -index 5c300fa414fbb8688674aed114543e602cdb96db..ba6d0bbce4edcb1a6e05108e4e83fc6ba5894bb4 100644 +index 3f83f961ca953d1a6fe544a49e3a3d7addaf6c50..7a639e7d2975fa8d033ea32f371e3b6539ea0c7e 100644 --- a/printing/printing_context.h +++ b/printing/printing_context.h -@@ -133,12 +133,12 @@ class COMPONENT_EXPORT(PRINTING) PrintingContext { +@@ -145,6 +145,9 @@ class COMPONENT_EXPORT(PRINTING) PrintingContext { int job_id() const { return job_id_; } -- protected: -- explicit PrintingContext(Delegate* delegate); -- - // Reinitializes the settings for object reuse. - void ResetSettings(); - -+ protected: -+ explicit PrintingContext(Delegate* delegate); ++ // Reinitializes the settings for object reuse. ++ void ResetSettings(); + + protected: + explicit PrintingContext(Delegate* delegate); + +@@ -152,9 +155,6 @@ class COMPONENT_EXPORT(PRINTING) PrintingContext { + // implement this method to create an object of their implementation. + static std::unique_ptr CreateImpl(Delegate* delegate); + +- // Reinitializes the settings for object reuse. +- void ResetSettings(); +- // Does bookkeeping when an error occurs. PrintingContext::Result OnError(); diff --git a/patches/chromium/refactor_expose_cursor_changes_to_the_webcontentsobserver.patch b/patches/chromium/refactor_expose_cursor_changes_to_the_webcontentsobserver.patch index 6f079c81ead58..5795db0123afd 100644 --- a/patches/chromium/refactor_expose_cursor_changes_to_the_webcontentsobserver.patch +++ b/patches/chromium/refactor_expose_cursor_changes_to_the_webcontentsobserver.patch @@ -8,7 +8,7 @@ Chrome moved the SetCursor IPC message to mojo, which we use to tell OSR about ` Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2172779 diff --git a/content/browser/renderer_host/render_widget_host_delegate.h b/content/browser/renderer_host/render_widget_host_delegate.h -index 0d5902fab0ada390c04f77a176cbae79e898c5f7..da77fda56eef9e46f7c41effeada67fab9cbf760 100644 +index 0abf9abd6a02dd13742148596d4729af8b8d967b..23560bbf3acf688045cc25f1e4289ef4c1f6552b 100644 --- a/content/browser/renderer_host/render_widget_host_delegate.h +++ b/content/browser/renderer_host/render_widget_host_delegate.h @@ -14,6 +14,7 @@ @@ -30,7 +30,7 @@ index 0d5902fab0ada390c04f77a176cbae79e898c5f7..da77fda56eef9e46f7c41effeada67fa // RenderWidgetHost on the main frame, and false otherwise. virtual bool IsWidgetForMainFrame(RenderWidgetHostImpl*); diff --git a/content/browser/renderer_host/render_widget_host_impl.cc b/content/browser/renderer_host/render_widget_host_impl.cc -index 4bec6c3593de51f6098c632a08793508106ec21d..c59146ea61717f260292efcc04f723989a12383e 100644 +index b72e3f6ab2a43e8a7f707e9634fb3a4abb87e993..68536fc453f85089b6bc8d3c58b24212ed42cc93 100644 --- a/content/browser/renderer_host/render_widget_host_impl.cc +++ b/content/browser/renderer_host/render_widget_host_impl.cc @@ -2009,6 +2009,8 @@ void RenderWidgetHostImpl::FilterDropData(DropData* drop_data) { @@ -43,10 +43,10 @@ index 4bec6c3593de51f6098c632a08793508106ec21d..c59146ea61717f260292efcc04f72398 void RenderWidgetHostImpl::ShowContextMenuAtPoint( diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc -index 183fa12d38d28f3de40bdd9f26155388658e8ffe..1e38a16e950a4ee5ed63405576b57185fe7b9e3c 100644 +index 0ba0990cf02624cc7cf1b304a0d9b63692cd464d..bc84aa5826d4ca8aef8f496acd3569152007b7a8 100644 --- a/content/browser/web_contents/web_contents_impl.cc +++ b/content/browser/web_contents/web_contents_impl.cc -@@ -4283,6 +4283,11 @@ TextInputManager* WebContentsImpl::GetTextInputManager() { +@@ -4307,6 +4307,11 @@ TextInputManager* WebContentsImpl::GetTextInputManager() { return text_input_manager_.get(); } @@ -59,10 +59,10 @@ index 183fa12d38d28f3de40bdd9f26155388658e8ffe..1e38a16e950a4ee5ed63405576b57185 RenderWidgetHostImpl* render_widget_host) { return render_widget_host == GetMainFrame()->GetRenderWidgetHost(); diff --git a/content/browser/web_contents/web_contents_impl.h b/content/browser/web_contents/web_contents_impl.h -index 7183994d0bbcd4b21878bbc29088e877ee032001..6240a5a997894055bd5f7c2d9ceb741cd9bfe1e4 100644 +index 1d749125dba6a4051ff8a147ef7a990d7523707b..4fa272275ba3883d105ddfd8deeb4987071d1b06 100644 --- a/content/browser/web_contents/web_contents_impl.h +++ b/content/browser/web_contents/web_contents_impl.h -@@ -947,6 +947,7 @@ class CONTENT_EXPORT WebContentsImpl : public WebContents, +@@ -949,6 +949,7 @@ class CONTENT_EXPORT WebContentsImpl : public WebContents, blink::mojom::FrameVisibility visibility) override; void SendScreenRects() override; TextInputManager* GetTextInputManager() override; diff --git a/patches/chromium/render_widget_host_view_base.patch b/patches/chromium/render_widget_host_view_base.patch index e53f025f97cfa..2a4d8b90b7e97 100644 --- a/patches/chromium/render_widget_host_view_base.patch +++ b/patches/chromium/render_widget_host_view_base.patch @@ -24,10 +24,10 @@ index beaa6476fe5d8ad8718a6e15425cf46561b28ae1..2f0b3eb5056710b09b01ae36f2227811 const blink::WebMouseEvent& event, const ui::LatencyInfo& latency) { diff --git a/content/browser/renderer_host/render_widget_host_view_base.h b/content/browser/renderer_host/render_widget_host_view_base.h -index 21669355ec8d1bef63f7dd918d9c1d3d0bf0577b..af13cf1b1685a9b5e4bb43cd224dc926cd1c8291 100644 +index 5e1fbd03146192f417cb95bb88b44047fd40096a..da57f3a6c863abc9cbf14d2ce5ae99666fd3f37e 100644 --- a/content/browser/renderer_host/render_widget_host_view_base.h +++ b/content/browser/renderer_host/render_widget_host_view_base.h -@@ -24,8 +24,10 @@ +@@ -25,8 +25,10 @@ #include "components/viz/host/hit_test/hit_test_query.h" #include "content/browser/renderer_host/display_feature.h" #include "content/browser/renderer_host/event_with_latency_info.h" @@ -38,7 +38,7 @@ index 21669355ec8d1bef63f7dd918d9c1d3d0bf0577b..af13cf1b1685a9b5e4bb43cd224dc926 #include "content/public/browser/render_widget_host_view.h" #include "content/public/browser/visibility.h" #include "content/public/common/widget_type.h" -@@ -67,9 +69,11 @@ class CursorManager; +@@ -68,9 +70,11 @@ class CursorManager; class MouseWheelPhaseHandler; class RenderWidgetHostImpl; class RenderWidgetHostViewBaseObserver; @@ -50,7 +50,7 @@ index 21669355ec8d1bef63f7dd918d9c1d3d0bf0577b..af13cf1b1685a9b5e4bb43cd224dc926 class WebCursor; class WebContentsAccessibility; class DelegatedFrameHost; -@@ -141,6 +145,9 @@ class CONTENT_EXPORT RenderWidgetHostViewBase : public RenderWidgetHostView { +@@ -142,6 +146,9 @@ class CONTENT_EXPORT RenderWidgetHostViewBase : public RenderWidgetHostView { void NotifyVirtualKeyboardOverlayRect( const gfx::Rect& keyboard_rect) override {} @@ -60,7 +60,7 @@ index 21669355ec8d1bef63f7dd918d9c1d3d0bf0577b..af13cf1b1685a9b5e4bb43cd224dc926 // This only needs to be overridden by RenderWidgetHostViewBase subclasses // that handle content embedded within other RenderWidgetHostViews. gfx::PointF TransformPointToRootCoordSpaceF( -@@ -303,6 +310,11 @@ class CONTENT_EXPORT RenderWidgetHostViewBase : public RenderWidgetHostView { +@@ -304,6 +311,11 @@ class CONTENT_EXPORT RenderWidgetHostViewBase : public RenderWidgetHostView { virtual void ProcessGestureEvent(const blink::WebGestureEvent& event, const ui::LatencyInfo& latency); diff --git a/patches/chromium/resource_file_conflict.patch b/patches/chromium/resource_file_conflict.patch index 76e513ddd4027..816dc2fb666e5 100644 --- a/patches/chromium/resource_file_conflict.patch +++ b/patches/chromium/resource_file_conflict.patch @@ -52,10 +52,10 @@ Some alternatives to this patch: None of these options seems like a substantial maintainability win over this patch to me (@nornagon). diff --git a/chrome/BUILD.gn b/chrome/BUILD.gn -index c25d483469dbc2580f12340daefb85f085b4e127..d4436b93723cac8b33a6ffab1437b221446a1fb0 100644 +index d7a430eb9911a3a13da807e25204abd58025fdc9..897e473cbb4c3e8b244210706e4e1549b1e71a0c 100644 --- a/chrome/BUILD.gn +++ b/chrome/BUILD.gn -@@ -1523,7 +1523,7 @@ if (is_chrome_branded && !is_android) { +@@ -1536,7 +1536,7 @@ if (is_chrome_branded && !is_android) { } } @@ -64,7 +64,7 @@ index c25d483469dbc2580f12340daefb85f085b4e127..d4436b93723cac8b33a6ffab1437b221 chrome_paks("packed_resources") { if (is_mac) { output_dir = "$root_gen_dir/repack" -@@ -1551,6 +1551,12 @@ if (!is_android) { +@@ -1564,6 +1564,12 @@ if (!is_android) { } } diff --git a/patches/chromium/revert_roll_clang_llvmorg-14-init-1002-gb5e470aa-1.patch b/patches/chromium/revert_roll_clang_llvmorg-14-init-1002-gb5e470aa-1.patch deleted file mode 100644 index dcb68089a8b43..0000000000000 --- a/patches/chromium/revert_roll_clang_llvmorg-14-init-1002-gb5e470aa-1.patch +++ /dev/null @@ -1,21 +0,0 @@ -From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001 -From: John Kleinschmidt -Date: Mon, 23 Aug 2021 13:42:34 -0400 -Subject: Revert "Roll clang llvmorg-14-init-1002-gb5e470aa-1 : - llvmorg-14-init-1380-gee659383-1" - -This reverts commit 65172c258c45f5bc22f2018884d013b8d11f4b26. - -diff --git a/tools/clang/scripts/update.py b/tools/clang/scripts/update.py -index 56b1a39e7883c89fbf27a205c136fc2c12a785f5..64f27320cd0f99934ff0c2e105a7cb08a53b5c88 100755 ---- a/tools/clang/scripts/update.py -+++ b/tools/clang/scripts/update.py -@@ -39,7 +39,7 @@ import zipfile - # https://chromium.googlesource.com/chromium/src/+/main/docs/updating_clang.md - # Reverting problematic clang rolls is safe, though. - # This is the output of `git describe` and is usable as a commit-ish. --CLANG_REVISION = 'llvmorg-14-init-1380-gee659383' -+CLANG_REVISION = 'llvmorg-14-init-1002-gb5e470aa' - CLANG_SUB_REVISION = 1 - - PACKAGE_VERSION = '%s-%s' % (CLANG_REVISION, CLANG_SUB_REVISION) diff --git a/patches/chromium/scroll_bounce_flag.patch b/patches/chromium/scroll_bounce_flag.patch index 7ddef83a194d3..eda31423ad5d8 100644 --- a/patches/chromium/scroll_bounce_flag.patch +++ b/patches/chromium/scroll_bounce_flag.patch @@ -6,7 +6,7 @@ Subject: scroll_bounce_flag.patch Patch to make scrollBounce option work. diff --git a/content/renderer/render_thread_impl.cc b/content/renderer/render_thread_impl.cc -index 7e1d2199e024da40c5700164623d45d034c79f27..8b4897a87f6b562978237c573bf86124c0a9ab7f 100644 +index 52c02371bf3735dd8a4670c566da13ac6c37a522..7d462cc901050085dbb211f63ffc0bd817b1ba08 100644 --- a/content/renderer/render_thread_impl.cc +++ b/content/renderer/render_thread_impl.cc @@ -1283,7 +1283,7 @@ bool RenderThreadImpl::IsLcdTextEnabled() { diff --git a/patches/chromium/support_mixed_sandbox_with_zygote.patch b/patches/chromium/support_mixed_sandbox_with_zygote.patch index c21b0bc789573..07b9e1d3e6f8b 100644 --- a/patches/chromium/support_mixed_sandbox_with_zygote.patch +++ b/patches/chromium/support_mixed_sandbox_with_zygote.patch @@ -22,10 +22,10 @@ However, the patch would need to be reviewed by the security team, as it does touch a security-sensitive class. diff --git a/content/browser/renderer_host/render_process_host_impl.cc b/content/browser/renderer_host/render_process_host_impl.cc -index 80826440781926cb6a244c62117f8e2964c701d0..8c61ce5f2035a63675d17fda429b839c1e1e8e3b 100644 +index ca49f2c9de55e95024e5ff680794e09a53061ffd..0a53d80feb2cdaa599da3ea87a8a6a8f8327ae92 100644 --- a/content/browser/renderer_host/render_process_host_impl.cc +++ b/content/browser/renderer_host/render_process_host_impl.cc -@@ -431,10 +431,18 @@ class RendererSandboxedProcessLauncherDelegate +@@ -398,10 +398,18 @@ class RendererSandboxedProcessLauncherDelegate public: RendererSandboxedProcessLauncherDelegate() = default; @@ -44,7 +44,7 @@ index 80826440781926cb6a244c62117f8e2964c701d0..8c61ce5f2035a63675d17fda429b839c const base::CommandLine& browser_command_line = *base::CommandLine::ForCurrentProcess(); base::CommandLine::StringType renderer_prefix = -@@ -452,6 +460,11 @@ class RendererSandboxedProcessLauncherDelegate +@@ -419,6 +427,11 @@ class RendererSandboxedProcessLauncherDelegate sandbox::policy::SandboxType GetSandboxType() override { return sandbox::policy::SandboxType::kRenderer; } @@ -56,7 +56,7 @@ index 80826440781926cb6a244c62117f8e2964c701d0..8c61ce5f2035a63675d17fda429b839c }; #if defined(OS_WIN) -@@ -463,6 +476,9 @@ class RendererSandboxedProcessLauncherDelegateWin +@@ -430,6 +443,9 @@ class RendererSandboxedProcessLauncherDelegateWin bool is_jit_disabled) : renderer_code_integrity_enabled_( GetContentClient()->browser()->IsRendererCodeIntegrityEnabled()) { @@ -66,7 +66,7 @@ index 80826440781926cb6a244c62117f8e2964c701d0..8c61ce5f2035a63675d17fda429b839c if (is_jit_disabled) { dynamic_code_can_be_disabled_ = true; return; -@@ -2014,9 +2030,15 @@ bool RenderProcessHostImpl::Init() { +@@ -1982,9 +1998,15 @@ bool RenderProcessHostImpl::Init() { std::unique_ptr sandbox_delegate = std::make_unique( cmd_line.get(), IsJitDisabled()); diff --git a/patches/chromium/web_contents.patch b/patches/chromium/web_contents.patch index 662e74f6e8347..a43a061b8e4e8 100644 --- a/patches/chromium/web_contents.patch +++ b/patches/chromium/web_contents.patch @@ -9,10 +9,10 @@ is needed for OSR. Originally landed in https://github.com/electron/libchromiumcontent/pull/226. diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc -index 8b9e76ad6eee5e03bfa97a2f5c6c7d8898f0dfe5..5426f4631ba0c8159de323969ed379c44352eab4 100644 +index b6524566b96a141ba710441ab70d17f46e5b1b9a..6a48e38254024ea721d2f10a9e88aa8ce00f8975 100644 --- a/content/browser/web_contents/web_contents_impl.cc +++ b/content/browser/web_contents/web_contents_impl.cc -@@ -2885,6 +2885,12 @@ void WebContentsImpl::Init(const WebContents::CreateParams& params) { +@@ -2897,6 +2897,12 @@ void WebContentsImpl::Init(const WebContents::CreateParams& params) { frame_tree_.Init(site_instance.get(), params.renderer_initiated_creation, params.main_frame_name); @@ -25,7 +25,7 @@ index 8b9e76ad6eee5e03bfa97a2f5c6c7d8898f0dfe5..5426f4631ba0c8159de323969ed379c4 WebContentsViewDelegate* delegate = GetContentClient()->browser()->GetWebContentsViewDelegate(this); -@@ -2895,6 +2901,7 @@ void WebContentsImpl::Init(const WebContents::CreateParams& params) { +@@ -2907,6 +2913,7 @@ void WebContentsImpl::Init(const WebContents::CreateParams& params) { view_.reset(CreateWebContentsView(this, delegate, &render_view_host_delegate_view_)); } diff --git a/patches/chromium/webview_fullscreen.patch b/patches/chromium/webview_fullscreen.patch index 34047097e0ea6..f7f786d27dc12 100644 --- a/patches/chromium/webview_fullscreen.patch +++ b/patches/chromium/webview_fullscreen.patch @@ -14,10 +14,10 @@ Note that we also need to manually update embedder's `api::WebContents::IsFullscreenForTabOrPending` value. diff --git a/content/browser/renderer_host/render_frame_host_impl.cc b/content/browser/renderer_host/render_frame_host_impl.cc -index b5f7104ffde611652c55ebe85e3969394dbf76fc..1001c3c9e486ba17466d23168ad7df6aecc8eeee 100644 +index ea22c655ae4e5c1e023d68fbedb2a684edabe1fe..0a4be87c33dcd6f6952288ce5f19f2263299e68f 100644 --- a/content/browser/renderer_host/render_frame_host_impl.cc +++ b/content/browser/renderer_host/render_frame_host_impl.cc -@@ -5771,6 +5771,15 @@ void RenderFrameHostImpl::EnterFullscreen( +@@ -5830,6 +5830,15 @@ void RenderFrameHostImpl::EnterFullscreen( notified_instances.insert(parent_site_instance); } @@ -31,5 +31,5 @@ index b5f7104ffde611652c55ebe85e3969394dbf76fc..1001c3c9e486ba17466d23168ad7df6a + } + delegate_->EnterFullscreenMode(this, *options); - delegate_->FullscreenStateChanged(this, true /* is_fullscreen */, + delegate_->FullscreenStateChanged(this, /*is_fullscreen=*/true, std::move(options)); diff --git a/patches/chromium/worker_context_will_destroy.patch b/patches/chromium/worker_context_will_destroy.patch index a8e70fc53a4fc..2e5ec3d2adc3b 100644 --- a/patches/chromium/worker_context_will_destroy.patch +++ b/patches/chromium/worker_context_will_destroy.patch @@ -10,10 +10,10 @@ An attempt to upstream this was made, but rejected: https://chromium-review.googlesource.com/c/chromium/src/+/1954347 diff --git a/content/public/renderer/content_renderer_client.h b/content/public/renderer/content_renderer_client.h -index 7ec0901cf6ba2c3b8d8dd69d02f12c1c603f13b8..d8c7a1954d5acc0eb4bb675795038eae0e16bc05 100644 +index b62158069f9a1ae7141c8f9ef191bd11660797d2..74846c92e2fdfc4dffe9014a010a0acdf9e3017c 100644 --- a/content/public/renderer/content_renderer_client.h +++ b/content/public/renderer/content_renderer_client.h -@@ -366,6 +366,11 @@ class CONTENT_EXPORT ContentRendererClient { +@@ -358,6 +358,11 @@ class CONTENT_EXPORT ContentRendererClient { virtual void DidInitializeWorkerContextOnWorkerThread( v8::Local context) {} @@ -26,10 +26,10 @@ index 7ec0901cf6ba2c3b8d8dd69d02f12c1c603f13b8..d8c7a1954d5acc0eb4bb675795038eae // An empty URL is returned if the URL is not overriden. virtual GURL OverrideFlashEmbedWithHTML(const GURL& url); diff --git a/content/renderer/renderer_blink_platform_impl.cc b/content/renderer/renderer_blink_platform_impl.cc -index 272d5c2d7aa766c36a6e5473f2d0a3213d7722df..03f65f0061cac241e6555cab8d8793d5eb134331 100644 +index 337c630fc85f33346dccffd51c1fb06db032f1fb..1db3e3674b2b8457f61012565c6103fe1a693929 100644 --- a/content/renderer/renderer_blink_platform_impl.cc +++ b/content/renderer/renderer_blink_platform_impl.cc -@@ -950,6 +950,12 @@ void RendererBlinkPlatformImpl::WillStopWorkerThread() { +@@ -936,6 +936,12 @@ void RendererBlinkPlatformImpl::WillStopWorkerThread() { WorkerThreadRegistry::Instance()->WillStopCurrentWorkerThread(); } @@ -43,10 +43,10 @@ index 272d5c2d7aa766c36a6e5473f2d0a3213d7722df..03f65f0061cac241e6555cab8d8793d5 const v8::Local& worker) { GetContentClient()->renderer()->DidInitializeWorkerContextOnWorkerThread( diff --git a/content/renderer/renderer_blink_platform_impl.h b/content/renderer/renderer_blink_platform_impl.h -index 918400762b2bf2de641ec3c7a88d9e15184d30ca..c59f582cf7349e825a39a2f1ae9293cd87233e73 100644 +index b199c34615f0230b46b6128cccfce75d5c2ccc9c..0b8515b4e8cc86f332d4c5c6950bd4656d88fac4 100644 --- a/content/renderer/renderer_blink_platform_impl.h +++ b/content/renderer/renderer_blink_platform_impl.h -@@ -206,6 +206,7 @@ class CONTENT_EXPORT RendererBlinkPlatformImpl : public BlinkPlatformImpl { +@@ -205,6 +205,7 @@ class CONTENT_EXPORT RendererBlinkPlatformImpl : public BlinkPlatformImpl { void DidStartWorkerThread() override; void WillStopWorkerThread() override; void WorkerContextCreated(const v8::Local& worker) override; @@ -55,10 +55,10 @@ index 918400762b2bf2de641ec3c7a88d9e15184d30ca..c59f582cf7349e825a39a2f1ae9293cd const blink::WebSecurityOrigin& script_origin) override; blink::ProtocolHandlerSecurityLevel GetProtocolHandlerSecurityLevel() diff --git a/third_party/blink/public/platform/platform.h b/third_party/blink/public/platform/platform.h -index 1928e045f12383d6ce10fc785c50d6e4919cd563..672a29fd5fe78839d6b8f754d1228d8fcf9b88b3 100644 +index f9be3480ae7c96e5a58add277ebce71cbf3b1441..616fd24d928807604fd484a20947e36079affdbe 100644 --- a/third_party/blink/public/platform/platform.h +++ b/third_party/blink/public/platform/platform.h -@@ -728,6 +728,7 @@ class BLINK_PLATFORM_EXPORT Platform { +@@ -724,6 +724,7 @@ class BLINK_PLATFORM_EXPORT Platform { virtual void DidStartWorkerThread() {} virtual void WillStopWorkerThread() {} virtual void WorkerContextCreated(const v8::Local& worker) {} diff --git a/patches/chromium/worker_feat_add_hook_to_notify_script_ready.patch b/patches/chromium/worker_feat_add_hook_to_notify_script_ready.patch index 4a7841344e41f..ce3b6fc0bcab7 100644 --- a/patches/chromium/worker_feat_add_hook_to_notify_script_ready.patch +++ b/patches/chromium/worker_feat_add_hook_to_notify_script_ready.patch @@ -19,10 +19,10 @@ that clearly establishes the worker script is ready for evaluation with the scop initialized. diff --git a/content/public/renderer/content_renderer_client.h b/content/public/renderer/content_renderer_client.h -index d8c7a1954d5acc0eb4bb675795038eae0e16bc05..0eee88a106abdc6f232b384265da03e85075fb00 100644 +index 74846c92e2fdfc4dffe9014a010a0acdf9e3017c..3dfb2f9dadb682265b90ac5520dd20ae819ff2b9 100644 --- a/content/public/renderer/content_renderer_client.h +++ b/content/public/renderer/content_renderer_client.h -@@ -366,6 +366,11 @@ class CONTENT_EXPORT ContentRendererClient { +@@ -358,6 +358,11 @@ class CONTENT_EXPORT ContentRendererClient { virtual void DidInitializeWorkerContextOnWorkerThread( v8::Local context) {} @@ -35,10 +35,10 @@ index d8c7a1954d5acc0eb4bb675795038eae0e16bc05..0eee88a106abdc6f232b384265da03e8 // from the worker thread. virtual void WillDestroyWorkerContextOnWorkerThread( diff --git a/content/renderer/renderer_blink_platform_impl.cc b/content/renderer/renderer_blink_platform_impl.cc -index 03f65f0061cac241e6555cab8d8793d5eb134331..3dd71874bf23c23f5d5ea31e37b16f83187c7331 100644 +index 1db3e3674b2b8457f61012565c6103fe1a693929..16319411915fb747d234a09185a5d7be1643a4dd 100644 --- a/content/renderer/renderer_blink_platform_impl.cc +++ b/content/renderer/renderer_blink_platform_impl.cc -@@ -962,6 +962,12 @@ void RendererBlinkPlatformImpl::WorkerContextCreated( +@@ -948,6 +948,12 @@ void RendererBlinkPlatformImpl::WorkerContextCreated( worker); } @@ -52,10 +52,10 @@ index 03f65f0061cac241e6555cab8d8793d5eb134331..3dd71874bf23c23f5d5ea31e37b16f83 const blink::WebSecurityOrigin& script_origin) { return GetContentClient()->renderer()->AllowScriptExtensionForServiceWorker( diff --git a/content/renderer/renderer_blink_platform_impl.h b/content/renderer/renderer_blink_platform_impl.h -index c59f582cf7349e825a39a2f1ae9293cd87233e73..9e242a25a6b6cea72a6ed48cb986ebbfa570493a 100644 +index 0b8515b4e8cc86f332d4c5c6950bd4656d88fac4..0bf0c2a5c364404863af1493d30013b8fd9fba68 100644 --- a/content/renderer/renderer_blink_platform_impl.h +++ b/content/renderer/renderer_blink_platform_impl.h -@@ -206,6 +206,8 @@ class CONTENT_EXPORT RendererBlinkPlatformImpl : public BlinkPlatformImpl { +@@ -205,6 +205,8 @@ class CONTENT_EXPORT RendererBlinkPlatformImpl : public BlinkPlatformImpl { void DidStartWorkerThread() override; void WillStopWorkerThread() override; void WorkerContextCreated(const v8::Local& worker) override; @@ -65,10 +65,10 @@ index c59f582cf7349e825a39a2f1ae9293cd87233e73..9e242a25a6b6cea72a6ed48cb986ebbf bool AllowScriptExtensionForServiceWorker( const blink::WebSecurityOrigin& script_origin) override; diff --git a/third_party/blink/public/platform/platform.h b/third_party/blink/public/platform/platform.h -index 672a29fd5fe78839d6b8f754d1228d8fcf9b88b3..71d533bd0923a74e1029596d27d215c0a69d16b4 100644 +index 616fd24d928807604fd484a20947e36079affdbe..247d88dd0c55d2ab5056011277ff5b00e0167fc2 100644 --- a/third_party/blink/public/platform/platform.h +++ b/third_party/blink/public/platform/platform.h -@@ -728,6 +728,8 @@ class BLINK_PLATFORM_EXPORT Platform { +@@ -724,6 +724,8 @@ class BLINK_PLATFORM_EXPORT Platform { virtual void DidStartWorkerThread() {} virtual void WillStopWorkerThread() {} virtual void WorkerContextCreated(const v8::Local& worker) {} @@ -78,10 +78,10 @@ index 672a29fd5fe78839d6b8f754d1228d8fcf9b88b3..71d533bd0923a74e1029596d27d215c0 virtual bool AllowScriptExtensionForServiceWorker( const WebSecurityOrigin& script_origin) { diff --git a/third_party/blink/renderer/bindings/core/v8/worker_or_worklet_script_controller.cc b/third_party/blink/renderer/bindings/core/v8/worker_or_worklet_script_controller.cc -index 8e576c2512fcd28c80bde706c89e497fd105e0d8..ba0266e458a29603c66e2c6aa8a7d0a0912e9de1 100644 +index 8e359fe9c3c9c50bcd85b70c26b6ca7bad9245fa..5fa95eda6835ed5d82182925880d542f8115da6a 100644 --- a/third_party/blink/renderer/bindings/core/v8/worker_or_worklet_script_controller.cc +++ b/third_party/blink/renderer/bindings/core/v8/worker_or_worklet_script_controller.cc -@@ -256,6 +256,7 @@ void WorkerOrWorkletScriptController::PrepareForEvaluation() { +@@ -257,6 +257,7 @@ void WorkerOrWorkletScriptController::PrepareForEvaluation() { V8PerContextData* per_context_data = script_state_->PerContextData(); ignore_result(per_context_data->ConstructorForType( global_scope_->GetWrapperTypeInfo())); diff --git a/patches/node/build_add_gn_build_files.patch b/patches/node/build_add_gn_build_files.patch index 2fc32730dcce0..acb064c70d712 100644 --- a/patches/node/build_add_gn_build_files.patch +++ b/patches/node/build_add_gn_build_files.patch @@ -968,10 +968,10 @@ index 0000000000000000000000000000000000000000..2c9d2826c85bdd033f1df1d6188df636 +} diff --git a/filenames.json b/filenames.json new file mode 100644 -index 0000000000000000000000000000000000000000..5804390a6185cbc5eac85af592eb0f40632d82ff +index 0000000000000000000000000000000000000000..42ae2a31b79f0b5d04d9794416364d14bffdce84 --- /dev/null +++ b/filenames.json -@@ -0,0 +1,549 @@ +@@ -0,0 +1,602 @@ +// This file is automatically generated by generate_gn_filenames_json.py +// DO NOT EDIT +{ @@ -991,10 +991,63 @@ index 0000000000000000000000000000000000000000..5804390a6185cbc5eac85af592eb0f40 + { + "dest_dir": "include/node//", + "files": [ ++ "//v8/include/v8-array-buffer.h", ++ "//v8/include/v8-callbacks.h", ++ "//v8/include/v8-container.h", ++ "//v8/include/v8-context.h", ++ "//v8/include/v8-cppgc.h", ++ "//v8/include/v8-data.h", ++ "//v8/include/v8-date.h", ++ "//v8/include/v8-debug.h", ++ "//v8/include/v8-embedder-heap.h", ++ "//v8/include/v8-exception.h", ++ "//v8/include/v8-extension.h", ++ "//v8/include/v8-external.h", ++ "//v8/include/v8-fast-api-calls.h", ++ "//v8/include/v8-forward.h", ++ "//v8/include/v8-function-callback.h", ++ "//v8/include/v8-function.h", ++ "//v8/include/v8-initialization.h", ++ "//v8/include/v8-inspector-protocol.h", ++ "//v8/include/v8-inspector.h", + "//v8/include/v8-internal.h", ++ "//v8/include/v8-isolate.h", ++ "//v8/include/v8-json.h", ++ "//v8/include/v8-local-handle.h", ++ "//v8/include/v8-locker.h", ++ "//v8/include/v8-maybe.h", ++ "//v8/include/v8-memory-span.h", ++ "//v8/include/v8-message.h", ++ "//v8/include/v8-metrics.h", ++ "//v8/include/v8-microtask-queue.h", ++ "//v8/include/v8-microtask.h", ++ "//v8/include/v8-object.h", ++ "//v8/include/v8-persistent-handle.h", + "//v8/include/v8-platform.h", ++ "//v8/include/v8-primitive-object.h", ++ "//v8/include/v8-primitive.h", + "//v8/include/v8-profiler.h", ++ "//v8/include/v8-promise.h", ++ "//v8/include/v8-proxy.h", ++ "//v8/include/v8-regexp.h", ++ "//v8/include/v8-script.h", ++ "//v8/include/v8-snapshot.h", ++ "//v8/include/v8-statistics.h", ++ "//v8/include/v8-template.h", ++ "//v8/include/v8-traced-handle.h", ++ "//v8/include/v8-typed-array.h", ++ "//v8/include/v8-unwinder-state.h", ++ "//v8/include/v8-unwinder.h", ++ "//v8/include/v8-util.h", ++ "//v8/include/v8-value-serializer-version.h", ++ "//v8/include/v8-value-serializer.h", ++ "//v8/include/v8-value.h", ++ "//v8/include/v8-version-string.h", + "//v8/include/v8-version.h", ++ "//v8/include/v8-wasm-trap-handler-posix.h", ++ "//v8/include/v8-wasm-trap-handler-win.h", ++ "//v8/include/v8-wasm.h", ++ "//v8/include/v8-weak-callback-info.h", + "//v8/include/v8.h", + "//v8/include/v8config.h" + ] @@ -1871,10 +1924,10 @@ index 0000000000000000000000000000000000000000..3088ae4bdf814ae255c9805ebd393b2e + + out_file.writelines(new_contents) diff --git a/tools/install.py b/tools/install.py -index 24cf51e73199e60b4c24700e1074fe9bd0a399e6..3cbf4f45fabec1a26e0edebb18fb589fbecfbe68 100755 +index 24cf51e73199e60b4c24700e1074fe9bd0a399e6..195f231c76b87dd9d06824df80a3f06ee07d8dc8 100755 --- a/tools/install.py +++ b/tools/install.py -@@ -159,17 +159,18 @@ def files(action): +@@ -159,17 +159,71 @@ def files(action): def headers(action): def wanted_v8_headers(files_arg, dest): v8_headers = [ @@ -1892,18 +1945,71 @@ index 24cf51e73199e60b4c24700e1074fe9bd0a399e6..3cbf4f45fabec1a26e0edebb18fb589f + '../../v8/include/libplatform/libplatform.h', + '../../v8/include/libplatform/libplatform-export.h', + '../../v8/include/libplatform/v8-tracing.h', -+ '../../v8/include/v8.h', ++ '../../v8/include/v8-array-buffer.h', ++ '../../v8/include/v8-callbacks.h', ++ '../../v8/include/v8-container.h', ++ '../../v8/include/v8-context.h', ++ '../../v8/include/v8-cppgc.h', ++ '../../v8/include/v8-data.h', ++ '../../v8/include/v8-date.h', ++ '../../v8/include/v8-debug.h', ++ '../../v8/include/v8-embedder-heap.h', ++ '../../v8/include/v8-exception.h', ++ '../../v8/include/v8-extension.h', ++ '../../v8/include/v8-external.h', ++ '../../v8/include/v8-fast-api-calls.h', ++ '../../v8/include/v8-forward.h', ++ '../../v8/include/v8-function-callback.h', ++ '../../v8/include/v8-function.h', ++ '../../v8/include/v8-initialization.h', ++ '../../v8/include/v8-inspector-protocol.h', ++ '../../v8/include/v8-inspector.h', + '../../v8/include/v8-internal.h', ++ '../../v8/include/v8-isolate.h', ++ '../../v8/include/v8-json.h', ++ '../../v8/include/v8-local-handle.h', ++ '../../v8/include/v8-locker.h', ++ '../../v8/include/v8-maybe.h', ++ '../../v8/include/v8-memory-span.h', ++ '../../v8/include/v8-message.h', ++ '../../v8/include/v8-metrics.h', ++ '../../v8/include/v8-microtask-queue.h', ++ '../../v8/include/v8-microtask.h', ++ '../../v8/include/v8-object.h', ++ '../../v8/include/v8-persistent-handle.h', + '../../v8/include/v8-platform.h', ++ '../../v8/include/v8-primitive-object.h', ++ '../../v8/include/v8-primitive.h', + '../../v8/include/v8-profiler.h', ++ '../../v8/include/v8-promise.h', ++ '../../v8/include/v8-proxy.h', ++ '../../v8/include/v8-regexp.h', ++ '../../v8/include/v8-script.h', ++ '../../v8/include/v8-snapshot.h', ++ '../../v8/include/v8-statistics.h', ++ '../../v8/include/v8-template.h', ++ '../../v8/include/v8-traced-handle.h', ++ '../../v8/include/v8-typed-array.h', ++ '../../v8/include/v8-unwinder-state.h', ++ '../../v8/include/v8-unwinder.h', ++ '../../v8/include/v8-util.h', ++ '../../v8/include/v8-value-serializer-version.h', ++ '../../v8/include/v8-value-serializer.h', ++ '../../v8/include/v8-value.h', ++ '../../v8/include/v8-version-string.h', + '../../v8/include/v8-version.h', -+ '../../v8/include/v8config.h', ++ '../../v8/include/v8-wasm-trap-handler-posix.h', ++ '../../v8/include/v8-wasm-trap-handler-win.h', ++ '../../v8/include/v8-wasm.h', ++ '../../v8/include/v8-weak-callback-info.h', ++ '../../v8/include/v8.h', ++ '../../v8/include/v8config.h' ] + v8_headers = [h.replace('deps/', '../../') for h in v8_headers] files_arg = [name for name in files_arg if name in v8_headers] action(files_arg, dest) -@@ -190,7 +191,7 @@ def headers(action): +@@ -190,7 +244,7 @@ def headers(action): if sys.platform.startswith('aix'): action(['out/Release/node.exp'], 'include/node/') diff --git a/patches/node/fix_-wunreachable-code-return.patch b/patches/node/fix_-wunreachable-code-return.patch index 97dc6b6e99c6e..189b473c534f4 100644 --- a/patches/node/fix_-wunreachable-code-return.patch +++ b/patches/node/fix_-wunreachable-code-return.patch @@ -5,6 +5,18 @@ Subject: fix: -Wunreachable-code-return Should be upstreamed. +diff --git a/src/inspector_agent.cc b/src/inspector_agent.cc +index 612ce2b78b41badccbbce0616dffd86de042738f..c4a3322c6d972fc2052af75b79389c522924d9c5 100644 +--- a/src/inspector_agent.cc ++++ b/src/inspector_agent.cc +@@ -87,7 +87,6 @@ inline void* StartIoThreadMain(void* unused) { + if (agent != nullptr) + agent->RequestIoThreadStart(); + } +- return nullptr; + } + + static int StartDebugSignalHandler() { diff --git a/src/node_url.cc b/src/node_url.cc index d7549e3bc05562d67bdef5aebf1fefa550b72eb6..d78cb7a3e1ceb075bd532e823a915b18f5a52afd 100644 --- a/src/node_url.cc diff --git a/patches/v8/.patches b/patches/v8/.patches index 39bd1bc4501e7..ff0b6eb65d118 100644 --- a/patches/v8/.patches +++ b/patches/v8/.patches @@ -6,4 +6,3 @@ workaround_an_undefined_symbol_error.patch do_not_export_private_v8_symbols_on_windows.patch fix_build_deprecated_attirbute_for_older_msvc_versions.patch fix_disable_implies_dcheck_for_node_stream_array_buffers.patch -fix_-wunreachable-code-aggressive_warnings_in_arm_and_arm64_code.patch diff --git a/patches/v8/build_gn.patch b/patches/v8/build_gn.patch index b310f35226d24..a8b02cc5d6269 100644 --- a/patches/v8/build_gn.patch +++ b/patches/v8/build_gn.patch @@ -9,10 +9,10 @@ necessary for native modules to load. Also, some fixes relating to mksnapshot on ARM. diff --git a/BUILD.gn b/BUILD.gn -index a68f7e924d6388fe24a1c3da032e629e3f140a04..e837fce5b0826a506a6835716f4a303c4a01252e 100644 +index 9be25bd786e5c48e420324a39633567e8a76f364..046caab35c77c5eb68d87f5eb7d30cacb670d4a4 100644 --- a/BUILD.gn +++ b/BUILD.gn -@@ -559,7 +559,7 @@ config("internal_config") { +@@ -565,7 +565,7 @@ config("internal_config") { ":cppgc_header_features", ] @@ -21,7 +21,7 @@ index a68f7e924d6388fe24a1c3da032e629e3f140a04..e837fce5b0826a506a6835716f4a303c defines += [ "BUILDING_V8_SHARED" ] } -@@ -5394,7 +5394,7 @@ if (current_toolchain == v8_generator_toolchain) { +@@ -5453,7 +5453,7 @@ if (current_toolchain == v8_generator_toolchain) { "src/interpreter/bytecodes.h", ] @@ -30,7 +30,7 @@ index a68f7e924d6388fe24a1c3da032e629e3f140a04..e837fce5b0826a506a6835716f4a303c deps = [ ":v8_libbase", -@@ -5432,6 +5432,8 @@ if (current_toolchain == v8_snapshot_toolchain) { +@@ -5491,6 +5491,8 @@ if (current_toolchain == v8_snapshot_toolchain) { configs = [ ":internal_config" ] diff --git a/patches/v8/dcheck.patch b/patches/v8/dcheck.patch index 5547ed0d24562..67501e7b2b2c2 100644 --- a/patches/v8/dcheck.patch +++ b/patches/v8/dcheck.patch @@ -6,10 +6,10 @@ Subject: dcheck.patch https://github.com/auchenberg/volkswagen diff --git a/src/api/api.cc b/src/api/api.cc -index 32e7a35c878dabc4f26791bd3fdcba11f3fd0d30..b31abc617b6fa5bcc06ac8bdd126b2f2f8b80d7d 100644 +index dedbd5db66823761c40f24169881ffc5ac06e391..97b0804562c7cd60791901fa9a8d48ff07c1abbf 100644 --- a/src/api/api.cc +++ b/src/api/api.cc -@@ -8867,7 +8867,7 @@ void Isolate::SetPromiseRejectCallback(PromiseRejectCallback callback) { +@@ -8919,7 +8919,7 @@ void Isolate::SetPromiseRejectCallback(PromiseRejectCallback callback) { } void Isolate::PerformMicrotaskCheckpoint() { @@ -19,10 +19,10 @@ index 32e7a35c878dabc4f26791bd3fdcba11f3fd0d30..b31abc617b6fa5bcc06ac8bdd126b2f2 isolate->default_microtask_queue()->PerformCheckpoint(this); } diff --git a/src/heap/heap.cc b/src/heap/heap.cc -index 982b80bb89f765fb7be44ab2504a7c6ad066dbd3..9fd0f4f11ba85966f2477e3ae01a9eea6f8607ee 100644 +index 338ba407a33e695b91f7daed114ecda336bddb02..3edefb22eb86954ea68465d817af37d81c06eb3a 100644 --- a/src/heap/heap.cc +++ b/src/heap/heap.cc -@@ -6028,9 +6028,9 @@ void Heap::DeinitSharedSpaces() { +@@ -6012,9 +6012,9 @@ void Heap::DeinitSharedSpaces() { void Heap::AddGCPrologueCallback(v8::Isolate::GCCallbackWithData callback, GCType gc_type, void* data) { DCHECK_NOT_NULL(callback); diff --git a/patches/v8/do_not_export_private_v8_symbols_on_windows.patch b/patches/v8/do_not_export_private_v8_symbols_on_windows.patch index 0bff0613bfa34..872c36bf04f7f 100644 --- a/patches/v8/do_not_export_private_v8_symbols_on_windows.patch +++ b/patches/v8/do_not_export_private_v8_symbols_on_windows.patch @@ -12,10 +12,10 @@ This patch can be safely removed if, when it is removed, `node.lib` does not contain any standard C++ library exports (e.g. `std::ostringstream`). diff --git a/BUILD.gn b/BUILD.gn -index 232419e12f95f06f57557aa5104ec898d878f83b..ee01ffb3a49b1e5bf5b0da5448e09dedf3b73f03 100644 +index 18ee54f52ad13855b364fa5449dddd9c81d521d9..361b90f4718d00eb5c787e4578d354906c030f47 100644 --- a/BUILD.gn +++ b/BUILD.gn -@@ -559,6 +559,10 @@ config("internal_config") { +@@ -565,6 +565,10 @@ config("internal_config") { ":cppgc_header_features", ] diff --git a/patches/v8/export_symbols_needed_for_windows_build.patch b/patches/v8/export_symbols_needed_for_windows_build.patch index bcdf085e8cd32..f5aacc48bb7e5 100644 --- a/patches/v8/export_symbols_needed_for_windows_build.patch +++ b/patches/v8/export_symbols_needed_for_windows_build.patch @@ -6,10 +6,10 @@ Subject: Export symbols needed for Windows build These symbols are required to build v8 with BUILD_V8_SHARED on Windows. diff --git a/src/objects/objects.h b/src/objects/objects.h -index eb31ec957d72ff4c6dee80b7798e27fadf048ccf..ad2502def9c04040a608a8d8e785750cd88f05fd 100644 +index 61bcf79800c375560a2c62477e7dbec77f259883..6b693d0b3384f058891f349ba66d1e004796245a 100644 --- a/src/objects/objects.h +++ b/src/objects/objects.h -@@ -855,7 +855,7 @@ enum class KeyCollectionMode { +@@ -842,7 +842,7 @@ enum AccessorComponent { ACCESSOR_GETTER, ACCESSOR_SETTER }; // Utility superclass for stack-allocated objects that must be updated // on gc. It provides two ways for the gc to update instances, either // iterating or updating after gc. @@ -19,10 +19,10 @@ index eb31ec957d72ff4c6dee80b7798e27fadf048ccf..ad2502def9c04040a608a8d8e785750c explicit inline Relocatable(Isolate* isolate); inline virtual ~Relocatable(); diff --git a/src/objects/ordered-hash-table.h b/src/objects/ordered-hash-table.h -index 1110352e46b9bac191d5ca12a936e0366d41168f..050610a1a35b162d19c16ae9d5bdc7f6bd10396f 100644 +index 45682e45e906fe9556bef578d5386cdf4e73d71a..569c632f6933ca7aec3ac239258207dede3e2d5e 100644 --- a/src/objects/ordered-hash-table.h +++ b/src/objects/ordered-hash-table.h -@@ -63,7 +63,7 @@ namespace internal { +@@ -64,7 +64,7 @@ namespace internal { // deleted elements count. // [kPrefixSize + 3 + NumberOfDeletedElements()..length]: Not used template diff --git a/patches/v8/expose_mksnapshot.patch b/patches/v8/expose_mksnapshot.patch index 1dd3049cc7cc2..7afa2952dc1eb 100644 --- a/patches/v8/expose_mksnapshot.patch +++ b/patches/v8/expose_mksnapshot.patch @@ -6,10 +6,10 @@ Subject: expose_mksnapshot.patch Needed in order to target mksnapshot for mksnapshot zip. diff --git a/BUILD.gn b/BUILD.gn -index e837fce5b0826a506a6835716f4a303c4a01252e..232419e12f95f06f57557aa5104ec898d878f83b 100644 +index 046caab35c77c5eb68d87f5eb7d30cacb670d4a4..18ee54f52ad13855b364fa5449dddd9c81d521d9 100644 --- a/BUILD.gn +++ b/BUILD.gn -@@ -5406,7 +5406,6 @@ if (current_toolchain == v8_generator_toolchain) { +@@ -5465,7 +5465,6 @@ if (current_toolchain == v8_generator_toolchain) { if (current_toolchain == v8_snapshot_toolchain) { v8_executable("mksnapshot") { diff --git a/patches/v8/fix_-wunreachable-code-aggressive_warnings_in_arm_and_arm64_code.patch b/patches/v8/fix_-wunreachable-code-aggressive_warnings_in_arm_and_arm64_code.patch deleted file mode 100644 index 1d7e8c7c87323..0000000000000 --- a/patches/v8/fix_-wunreachable-code-aggressive_warnings_in_arm_and_arm64_code.patch +++ /dev/null @@ -1,700 +0,0 @@ -From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001 -From: Nico Weber -Date: Wed, 18 Aug 2021 11:16:22 -0400 -Subject: Fix -Wunreachable-code-aggressive warnings in arm and arm64 code - -Like https://chromium-review.googlesource.com/c/v8/v8/+/2994804, but -for arm and arm64. - -Bug: chromium:1066980 -Change-Id: I5f3ac0d64a5031a62d4923d55a89f1d4e88cbc8b -Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3103905 -Auto-Submit: Nico Weber -Commit-Queue: Jakob Gruber -Reviewed-by: Jakob Gruber -Cr-Commit-Position: refs/heads/main@{#76374} -(cherry picked from commit 6711342469c0ec4186bd2083eaec7cd288330cfa) - -diff --git a/src/diagnostics/arm/disasm-arm.cc b/src/diagnostics/arm/disasm-arm.cc -index cf37d12a1f9a5587d3a057f876611526edfcfcd5..7ba20c0d98b79397135648646c014c05b392cb6b 100644 ---- a/src/diagnostics/arm/disasm-arm.cc -+++ b/src/diagnostics/arm/disasm-arm.cc -@@ -676,7 +676,6 @@ int Decoder::FormatOption(Instruction* instr, const char* format) { - } - default: { - UNREACHABLE(); -- return -1; - } - } - out_buffer_pos_ += -@@ -787,7 +786,6 @@ void Decoder::DecodeType01(Instruction* instr) { - break; - default: - UNREACHABLE(); -- break; - } - } else { - // strex -@@ -808,7 +806,6 @@ void Decoder::DecodeType01(Instruction* instr) { - break; - default: - UNREACHABLE(); -- break; - } - } - } else { -@@ -853,7 +850,6 @@ void Decoder::DecodeType01(Instruction* instr) { - default: { - // The PU field is a 2-bit field. - UNREACHABLE(); -- break; - } - } - } else { -@@ -894,7 +890,6 @@ void Decoder::DecodeType01(Instruction* instr) { - default: { - // The PU field is a 2-bit field. - UNREACHABLE(); -- break; - } - } - return; -@@ -1030,7 +1025,6 @@ void Decoder::DecodeType01(Instruction* instr) { - default: { - // The Opcode field is a 4-bit field. - UNREACHABLE(); -- break; - } - } - } -@@ -1107,10 +1101,8 @@ void Decoder::DecodeType3(Instruction* instr) { - break; - case 1: - UNREACHABLE(); -- break; - case 2: - UNREACHABLE(); -- break; - case 3: - Format(instr, "usat 'rd, #'imm05@16, 'rm'shift_sat"); - break; -@@ -1119,7 +1111,6 @@ void Decoder::DecodeType3(Instruction* instr) { - switch (instr->Bits(22, 21)) { - case 0: - UNREACHABLE(); -- break; - case 1: - if (instr->Bits(9, 6) == 1) { - if (instr->Bit(20) == 0) { -@@ -1948,7 +1939,6 @@ void Decoder::DecodeFloatingPointDataProcessing(Instruction* instr) { - break; - default: - UNREACHABLE(); // Case analysis is exhaustive. -- break; - } - } else if (instr->Opc1Value() == 0x4 && op2) { - // Floating-point minNum/maxNum. -@@ -2002,7 +1992,6 @@ void Decoder::DecodeFloatingPointDataProcessing(Instruction* instr) { - break; - default: - UNREACHABLE(); // Case analysis is exhaustive. -- break; - } - } else { - Unknown(instr); -@@ -2617,12 +2606,10 @@ const char* NameConverter::NameOfCPURegister(int reg) const { - - const char* NameConverter::NameOfByteCPURegister(int reg) const { - UNREACHABLE(); // ARM does not have the concept of a byte register -- return "nobytereg"; - } - - const char* NameConverter::NameOfXMMRegister(int reg) const { - UNREACHABLE(); // ARM does not have any XMM registers -- return "noxmmreg"; - } - - const char* NameConverter::NameInCode(byte* addr) const { -diff --git a/src/diagnostics/arm/eh-frame-arm.cc b/src/diagnostics/arm/eh-frame-arm.cc -index 7d0dc49155aec2bad9297f47a761181a41e7a71f..ef0a421820b1c6558770d0b2df79004e3bce0a1f 100644 ---- a/src/diagnostics/arm/eh-frame-arm.cc -+++ b/src/diagnostics/arm/eh-frame-arm.cc -@@ -37,7 +37,6 @@ int EhFrameWriter::RegisterToDwarfCode(Register name) { - return kR0DwarfCode; - default: - UNIMPLEMENTED(); -- return -1; - } - } - -@@ -54,7 +53,6 @@ const char* EhFrameDisassembler::DwarfRegisterCodeToString(int code) { - return "lr"; - default: - UNIMPLEMENTED(); -- return nullptr; - } - } - -diff --git a/src/diagnostics/arm64/disasm-arm64.cc b/src/diagnostics/arm64/disasm-arm64.cc -index 93b9531bd5d5e6d7e7cef13a0158db6c90942f16..af6e7f5441e7f44d73acde8f705e453af42e9650 100644 ---- a/src/diagnostics/arm64/disasm-arm64.cc -+++ b/src/diagnostics/arm64/disasm-arm64.cc -@@ -3954,7 +3954,6 @@ int DisassemblingDecoder::SubstituteImmediateField(Instruction* instr, - } - default: { - UNIMPLEMENTED(); -- return 0; - } - } - } -@@ -3997,7 +3996,6 @@ int DisassemblingDecoder::SubstituteImmediateField(Instruction* instr, - return 0; - } - UNIMPLEMENTED(); -- return 0; - } - case 'L': { // IVLSLane[0123] - suffix indicates access size shift. - AppendToOutput("%d", instr->NEONLSIndex(format[8] - '0')); -@@ -4042,12 +4040,10 @@ int DisassemblingDecoder::SubstituteImmediateField(Instruction* instr, - return static_cast(strlen("IVMIShiftAmt2")); - } else { - UNIMPLEMENTED(); -- return 0; - } - } - default: { - UNIMPLEMENTED(); -- return 0; - } - } - } -@@ -4342,12 +4338,10 @@ const char* NameConverter::NameOfCPURegister(int reg) const { - - const char* NameConverter::NameOfByteCPURegister(int reg) const { - UNREACHABLE(); // ARM64 does not have the concept of a byte register -- return "nobytereg"; - } - - const char* NameConverter::NameOfXMMRegister(int reg) const { - UNREACHABLE(); // ARM64 does not have any XMM registers -- return "noxmmreg"; - } - - const char* NameConverter::NameInCode(byte* addr) const { -diff --git a/src/diagnostics/arm64/eh-frame-arm64.cc b/src/diagnostics/arm64/eh-frame-arm64.cc -index 115d0cc300c87e25fae0a048b4c48a96562a1b91..2d198a9e35ae69d7fc00a37c37bf7e2bdf00473e 100644 ---- a/src/diagnostics/arm64/eh-frame-arm64.cc -+++ b/src/diagnostics/arm64/eh-frame-arm64.cc -@@ -38,7 +38,6 @@ int EhFrameWriter::RegisterToDwarfCode(Register name) { - return kX0DwarfCode; - default: - UNIMPLEMENTED(); -- return -1; - } - } - -diff --git a/src/execution/arm/simulator-arm.cc b/src/execution/arm/simulator-arm.cc -index ec9c05af699e538123a0e4cd2cf27b4df4b8ed5d..310ddab523d0d8c279ba0ac822709431d78b4c2a 100644 ---- a/src/execution/arm/simulator-arm.cc -+++ b/src/execution/arm/simulator-arm.cc -@@ -114,14 +114,10 @@ bool ArmDebugger::GetValue(const char* desc, int32_t* value) { - if (regnum != kNoRegister) { - *value = GetRegisterValue(regnum); - return true; -- } else { -- if (strncmp(desc, "0x", 2) == 0) { -- return SScanF(desc + 2, "%x", reinterpret_cast(value)) == 1; -- } else { -- return SScanF(desc, "%u", reinterpret_cast(value)) == 1; -- } - } -- return false; -+ if (strncmp(desc, "0x", 2) == 0) -+ return SScanF(desc + 2, "%x", reinterpret_cast(value)) == 1; -+ return SScanF(desc, "%u", reinterpret_cast(value)) == 1; - } - - bool ArmDebugger::GetVFPSingleValue(const char* desc, float* value) { -@@ -1192,7 +1188,6 @@ bool Simulator::ConditionallyExecute(Instruction* instr) { - default: - UNREACHABLE(); - } -- return false; - } - - // Calculate and set the Negative and Zero flags. -@@ -1314,7 +1309,6 @@ int32_t Simulator::GetShiftRm(Instruction* instr, bool* carry_out) { - // by immediate - if ((shift == ROR) && (shift_amount == 0)) { - UNIMPLEMENTED(); -- return result; - } else if (((shift == LSR) || (shift == ASR)) && (shift_amount == 0)) { - shift_amount = 32; - } -@@ -1373,7 +1367,6 @@ int32_t Simulator::GetShiftRm(Instruction* instr, bool* carry_out) { - - default: { - UNREACHABLE(); -- break; - } - } - } else { -@@ -1451,7 +1444,6 @@ int32_t Simulator::GetShiftRm(Instruction* instr, bool* carry_out) { - - default: { - UNREACHABLE(); -- break; - } - } - } -@@ -1486,7 +1478,6 @@ int32_t Simulator::ProcessPU(Instruction* instr, int num_regs, int reg_size, - switch (instr->PUField()) { - case da_x: { - UNIMPLEMENTED(); -- break; - } - case ia_x: { - *start_address = rn_val; -@@ -1717,7 +1708,6 @@ void Simulator::SoftwareInterrupt(Instruction* instr) { - break; - default: - UNREACHABLE(); -- break; - } - if (!stack_aligned) { - PrintF(" with unaligned stack %08x\n", get_register(sp)); -@@ -1769,7 +1759,6 @@ void Simulator::SoftwareInterrupt(Instruction* instr) { - } - default: - UNREACHABLE(); -- break; - } - if (::v8::internal::FLAG_trace_sim || !stack_aligned) { - switch (redirection->type()) { -@@ -1783,7 +1772,6 @@ void Simulator::SoftwareInterrupt(Instruction* instr) { - break; - default: - UNREACHABLE(); -- break; - } - } - } else if (redirection->type() == ExternalReference::DIRECT_API_CALL) { -@@ -2121,7 +2109,6 @@ void Simulator::DecodeType01(Instruction* instr) { - } - default: - UNREACHABLE(); -- break; - } - } else { - // The instruction is documented as strex rd, rt, [rn], but the -@@ -2165,7 +2152,6 @@ void Simulator::DecodeType01(Instruction* instr) { - } - default: - UNREACHABLE(); -- break; - } - } - } else { -@@ -2219,7 +2205,6 @@ void Simulator::DecodeType01(Instruction* instr) { - default: { - // The PU field is a 2-bit field. - UNREACHABLE(); -- break; - } - } - } else { -@@ -2262,7 +2247,6 @@ void Simulator::DecodeType01(Instruction* instr) { - default: { - // The PU field is a 2-bit field. - UNREACHABLE(); -- break; - } - } - } -@@ -2600,7 +2584,6 @@ void Simulator::DecodeType01(Instruction* instr) { - - default: { - UNREACHABLE(); -- break; - } - } - } -@@ -2680,7 +2663,6 @@ void Simulator::DecodeType3(Instruction* instr) { - DCHECK(!instr->HasW()); - Format(instr, "'memop'cond'b 'rd, ['rn], -'shift_rm"); - UNIMPLEMENTED(); -- break; - } - case ia_x: { - if (instr->Bit(4) == 0) { -@@ -2714,10 +2696,8 @@ void Simulator::DecodeType3(Instruction* instr) { - break; - case 1: - UNIMPLEMENTED(); -- break; - case 2: - UNIMPLEMENTED(); -- break; - case 3: { - // Usat. - int32_t sat_pos = instr->Bits(20, 16); -@@ -2746,7 +2726,6 @@ void Simulator::DecodeType3(Instruction* instr) { - switch (instr->Bits(22, 21)) { - case 0: - UNIMPLEMENTED(); -- break; - case 1: - if (instr->Bits(9, 6) == 1) { - if (instr->Bit(20) == 0) { -@@ -3442,7 +3421,6 @@ void Simulator::DecodeTypeVFP(Instruction* instr) { - } - default: - UNREACHABLE(); -- break; - } - set_neon_register(vd, q_data); - } -@@ -4433,7 +4411,6 @@ void Simulator::DecodeAdvancedSIMDTwoOrThreeRegisters(Instruction* instr) { - } - default: - UNREACHABLE(); -- break; - } - break; - } -@@ -4469,13 +4446,11 @@ void Simulator::DecodeAdvancedSIMDTwoOrThreeRegisters(Instruction* instr) { - } - default: - UNREACHABLE(); -- break; - } - break; - } - default: - UNREACHABLE(); -- break; - } - } else if (opc1 == 0 && (opc2 == 0b0100 || opc2 == 0b0101)) { - DCHECK_EQ(1, instr->Bit(6)); // Only support Q regs. -@@ -4625,7 +4600,6 @@ void Simulator::DecodeAdvancedSIMDTwoOrThreeRegisters(Instruction* instr) { - break; - default: - UNIMPLEMENTED(); -- break; - } - } - } else if (opc1 == 0b01 && (opc2 & 0b0111) == 0b111) { -@@ -4654,7 +4628,6 @@ void Simulator::DecodeAdvancedSIMDTwoOrThreeRegisters(Instruction* instr) { - break; - default: - UNIMPLEMENTED(); -- break; - } - } - } else if (opc1 == 0b10 && opc2 == 0b0001) { -@@ -4674,7 +4647,6 @@ void Simulator::DecodeAdvancedSIMDTwoOrThreeRegisters(Instruction* instr) { - break; - default: - UNREACHABLE(); -- break; - } - } else { - int Vd = instr->VFPDRegValue(kDoublePrecision); -@@ -4692,7 +4664,6 @@ void Simulator::DecodeAdvancedSIMDTwoOrThreeRegisters(Instruction* instr) { - break; - default: - UNREACHABLE(); -- break; - } - } - } else if (opc1 == 0b10 && (opc2 & 0b1110) == 0b0010) { -@@ -4714,7 +4685,6 @@ void Simulator::DecodeAdvancedSIMDTwoOrThreeRegisters(Instruction* instr) { - break; - default: - UNREACHABLE(); -- break; - } - } else { - // vuzp. Qd, Qm. -@@ -4730,7 +4700,6 @@ void Simulator::DecodeAdvancedSIMDTwoOrThreeRegisters(Instruction* instr) { - break; - default: - UNREACHABLE(); -- break; - } - } - } else { -@@ -4747,10 +4716,8 @@ void Simulator::DecodeAdvancedSIMDTwoOrThreeRegisters(Instruction* instr) { - break; - case Neon32: - UNIMPLEMENTED(); -- break; - default: - UNREACHABLE(); -- break; - } - } else { - // vuzp. Dd, Dm. -@@ -4763,10 +4730,8 @@ void Simulator::DecodeAdvancedSIMDTwoOrThreeRegisters(Instruction* instr) { - break; - case Neon32: - UNIMPLEMENTED(); -- break; - default: - UNREACHABLE(); -- break; - } - } - } -@@ -4811,7 +4776,6 @@ void Simulator::DecodeAdvancedSIMDTwoOrThreeRegisters(Instruction* instr) { - } - case Neon64: - UNREACHABLE(); -- break; - } - } else if (opc1 == 0b10 && instr->Bit(10) == 1) { - // vrint.
, -@@ -5078,7 +5042,6 @@ void Simulator::DecodeAdvancedSIMDDataProcessing(Instruction* instr) { - break; - default: - UNREACHABLE(); -- break; - } - } else if (!u && opc == 1 && sz == 2 && q && op1) { - // vmov Qd, Qm. -@@ -5134,7 +5097,6 @@ void Simulator::DecodeAdvancedSIMDDataProcessing(Instruction* instr) { - break; - default: - UNREACHABLE(); -- break; - } - } else if (!u && opc == 3) { - // vcge/vcgt.s Qd, Qm, Qn. -@@ -5152,7 +5114,6 @@ void Simulator::DecodeAdvancedSIMDDataProcessing(Instruction* instr) { - break; - default: - UNREACHABLE(); -- break; - } - } else if (!u && opc == 4 && !op1) { - // vshl s Qd, Qm, Qn. -@@ -5172,7 +5133,6 @@ void Simulator::DecodeAdvancedSIMDDataProcessing(Instruction* instr) { - break; - default: - UNREACHABLE(); -- break; - } - } else if (!u && opc == 6) { - // vmin/vmax.s Qd, Qm, Qn. -@@ -5190,7 +5150,6 @@ void Simulator::DecodeAdvancedSIMDDataProcessing(Instruction* instr) { - break; - default: - UNREACHABLE(); -- break; - } - } else if (!u && opc == 8 && op1) { - // vtst.i Qd, Qm, Qn. -@@ -5207,7 +5166,6 @@ void Simulator::DecodeAdvancedSIMDDataProcessing(Instruction* instr) { - break; - default: - UNREACHABLE(); -- break; - } - } else if (!u && opc == 8 && !op1) { - // vadd.i Qd, Qm, Qn. -@@ -5241,7 +5199,6 @@ void Simulator::DecodeAdvancedSIMDDataProcessing(Instruction* instr) { - break; - default: - UNREACHABLE(); -- break; - } - } else if (!u && opc == 0xA) { - // vpmin/vpmax.s Dd, Dm, Dn. -@@ -5259,7 +5216,6 @@ void Simulator::DecodeAdvancedSIMDDataProcessing(Instruction* instr) { - break; - default: - UNREACHABLE(); -- break; - } - } else if (!u && opc == 0xB) { - // vpadd.i Dd, Dm, Dn. -@@ -5276,7 +5232,6 @@ void Simulator::DecodeAdvancedSIMDDataProcessing(Instruction* instr) { - break; - default: - UNREACHABLE(); -- break; - } - } else if (!u && opc == 0xD && !op1) { - float src1[4], src2[4]; -@@ -5347,7 +5302,6 @@ void Simulator::DecodeAdvancedSIMDDataProcessing(Instruction* instr) { - break; - default: - UNREACHABLE(); -- break; - } - } else if (u && opc == 1 && sz == 1 && op1) { - // vbsl.size Qd, Qm, Qn. -@@ -5388,7 +5342,6 @@ void Simulator::DecodeAdvancedSIMDDataProcessing(Instruction* instr) { - break; - default: - UNREACHABLE(); -- break; - } - } else if (u && opc == 2 && op1) { - // vqsub.u Qd, Qm, Qn. -@@ -5405,7 +5358,6 @@ void Simulator::DecodeAdvancedSIMDDataProcessing(Instruction* instr) { - break; - default: - UNREACHABLE(); -- break; - } - } else if (u && opc == 3) { - // vcge/vcgt.u Qd, Qm, Qn. -@@ -5423,7 +5375,6 @@ void Simulator::DecodeAdvancedSIMDDataProcessing(Instruction* instr) { - break; - default: - UNREACHABLE(); -- break; - } - } else if (u && opc == 4 && !op1) { - // vshl u Qd, Qm, Qn. -@@ -5443,7 +5394,6 @@ void Simulator::DecodeAdvancedSIMDDataProcessing(Instruction* instr) { - break; - default: - UNREACHABLE(); -- break; - } - } else if (u && opc == 6) { - // vmin/vmax.u Qd, Qm, Qn. -@@ -5461,7 +5411,6 @@ void Simulator::DecodeAdvancedSIMDDataProcessing(Instruction* instr) { - break; - default: - UNREACHABLE(); -- break; - } - } else if (u && opc == 8 && !op1) { - // vsub.size Qd, Qm, Qn. -@@ -5495,7 +5444,6 @@ void Simulator::DecodeAdvancedSIMDDataProcessing(Instruction* instr) { - break; - default: - UNREACHABLE(); -- break; - } - } else if (u && opc == 0xA) { - // vpmin/vpmax.u Dd, Dm, Dn. -@@ -5513,7 +5461,6 @@ void Simulator::DecodeAdvancedSIMDDataProcessing(Instruction* instr) { - break; - default: - UNREACHABLE(); -- break; - } - } else if (u && opc == 0xD && sz == 0 && q && op1) { - // vmul.f32 Qd, Qn, Qm -@@ -5658,7 +5605,6 @@ void Simulator::DecodeAdvancedSIMDDataProcessing(Instruction* instr) { - break; - default: - UNIMPLEMENTED(); -- break; - } - } else { - // vmovl signed -@@ -5677,7 +5623,6 @@ void Simulator::DecodeAdvancedSIMDDataProcessing(Instruction* instr) { - break; - default: - UNIMPLEMENTED(); -- break; - } - } - } else if (!u && imm3H_L != 0 && opc == 0b0101) { -@@ -5721,7 +5666,6 @@ void Simulator::DecodeAdvancedSIMDDataProcessing(Instruction* instr) { - break; - default: - UNREACHABLE(); -- break; - } - } else if (u && imm3H_L != 0 && opc == 0b0101) { - // vsli. Dd, Dm, shift -@@ -5743,7 +5687,6 @@ void Simulator::DecodeAdvancedSIMDDataProcessing(Instruction* instr) { - break; - default: - UNREACHABLE(); -- break; - } - } - } -@@ -5807,7 +5750,6 @@ void Simulator::DecodeAdvancedSIMDLoadStoreMultipleStructures( - break; - default: - UNIMPLEMENTED(); -- break; - } - if (instr->Bit(21)) { - // vld1 -@@ -5993,7 +5935,6 @@ void Simulator::DecodeFloatingPointDataProcessing(Instruction* instr) { - break; - default: - UNREACHABLE(); // Case analysis is exhaustive. -- break; - } - dd_value = canonicalizeNaN(dd_value); - set_d_register_from_double(vd, dd_value); -@@ -6019,7 +5960,6 @@ void Simulator::DecodeFloatingPointDataProcessing(Instruction* instr) { - break; - default: - UNREACHABLE(); // Case analysis is exhaustive. -- break; - } - sd_value = canonicalizeNaN(sd_value); - set_s_register_from_float(d, sd_value); -@@ -6111,7 +6051,6 @@ void Simulator::DecodeFloatingPointDataProcessing(Instruction* instr) { - break; - default: - UNREACHABLE(); // Case analysis is exhaustive. -- break; - } - if (instr->SzValue() == 0x1) { - int n = instr->VFPNRegValue(kDoublePrecision); -@@ -6132,7 +6071,6 @@ void Simulator::DecodeFloatingPointDataProcessing(Instruction* instr) { - break; - default: - UNIMPLEMENTED(); -- break; - } - } - -@@ -6201,7 +6139,6 @@ void Simulator::InstructionDecode(Instruction* instr) { - } - default: { - UNIMPLEMENTED(); -- break; - } - } - } -diff --git a/src/execution/arm64/simulator-arm64.cc b/src/execution/arm64/simulator-arm64.cc -index 324bdd99a8d87c3e98b352dac99a1a8ccf8595ff..5669838006d3fd817275563a69f588d3b003598a 100644 ---- a/src/execution/arm64/simulator-arm64.cc -+++ b/src/execution/arm64/simulator-arm64.cc -@@ -1517,7 +1517,6 @@ void Simulator::VisitPCRelAddressing(Instruction* instr) { - break; - case ADRP: // Not implemented in the assembler. - UNIMPLEMENTED(); -- break; - default: - UNREACHABLE(); - } -@@ -2212,7 +2211,6 @@ Simulator::TransactionSize Simulator::get_transaction_size(unsigned size) { - default: - UNREACHABLE(); - } -- return TransactionSize::None; - } - - void Simulator::VisitLoadStoreAcquireRelease(Instruction* instr) { -@@ -5210,7 +5208,6 @@ void Simulator::VisitNEONScalar2RegMisc(Instruction* instr) { - break; - default: - UNIMPLEMENTED(); -- break; - } - } else { - VectorFormat fpf = nfd.GetVectorFormat(nfd.FPScalarFormatMap()); diff --git a/shell/browser/electron_browser_client.cc b/shell/browser/electron_browser_client.cc index 81958c0bef631..069c64c36104e 100644 --- a/shell/browser/electron_browser_client.cc +++ b/shell/browser/electron_browser_client.cc @@ -832,7 +832,7 @@ bool ElectronBrowserClient::ShouldUseProcessPerSite( bool ElectronBrowserClient::ArePersistentMediaDeviceIDsAllowed( content::BrowserContext* browser_context, const GURL& scope, - const GURL& site_for_cookies, + const net::SiteForCookies& site_for_cookies, const absl::optional& top_frame_origin) { return true; } diff --git a/shell/browser/electron_browser_client.h b/shell/browser/electron_browser_client.h index bf9de42746716..6b694d8796bca 100644 --- a/shell/browser/electron_browser_client.h +++ b/shell/browser/electron_browser_client.h @@ -268,7 +268,7 @@ class ElectronBrowserClient : public content::ContentBrowserClient, bool ArePersistentMediaDeviceIDsAllowed( content::BrowserContext* browser_context, const GURL& scope, - const GURL& site_for_cookies, + const net::SiteForCookies& site_for_cookies, const absl::optional& top_frame_origin) override; base::FilePath GetLoggingFileName(const base::CommandLine& cmd_line) override; diff --git a/shell/browser/extensions/api/cryptotoken_private/cryptotoken_private_api.cc b/shell/browser/extensions/api/cryptotoken_private/cryptotoken_private_api.cc index 2a21e0a4c986a..c2f486cccbe83 100644 --- a/shell/browser/extensions/api/cryptotoken_private/cryptotoken_private_api.cc +++ b/shell/browser/extensions/api/cryptotoken_private/cryptotoken_private_api.cc @@ -101,7 +101,7 @@ CryptotokenPrivateCanOriginAssertAppIdFunction:: ExtensionFunction::ResponseAction CryptotokenPrivateCanOriginAssertAppIdFunction::Run() { std::unique_ptr params = - cryptotoken_private::CanOriginAssertAppId::Params::Create(*args_); + cryptotoken_private::CanOriginAssertAppId::Params::Create(args()); EXTENSION_FUNCTION_VALIDATE(params); const GURL origin_url(params->security_origin); @@ -159,7 +159,7 @@ CryptotokenPrivateIsAppIdHashInEnterpriseContextFunction::Run() { std::unique_ptr params( cryptotoken_private::IsAppIdHashInEnterpriseContext::Params::Create( - *args_)); + args())); EXTENSION_FUNCTION_VALIDATE(params); #if 0 @@ -181,7 +181,7 @@ CryptotokenPrivateCanAppIdGetAttestationFunction:: ExtensionFunction::ResponseAction CryptotokenPrivateCanAppIdGetAttestationFunction::Run() { std::unique_ptr params = - cryptotoken_private::CanAppIdGetAttestation::Params::Create(*args_); + cryptotoken_private::CanAppIdGetAttestation::Params::Create(args()); EXTENSION_FUNCTION_VALIDATE(params); return RespondNow(Error("API not supported in Electron")); @@ -277,7 +277,7 @@ void CryptotokenPrivateCanAppIdGetAttestationFunction::Complete(bool result) { ExtensionFunction::ResponseAction CryptotokenPrivateRecordRegisterRequestFunction::Run() { auto params = - cryptotoken_private::RecordRegisterRequest::Params::Create(*args_); + cryptotoken_private::RecordRegisterRequest::Params::Create(args()); EXTENSION_FUNCTION_VALIDATE(params); content::RenderFrameHost* frame = RenderFrameHostForTabAndFrameId( @@ -293,7 +293,7 @@ CryptotokenPrivateRecordRegisterRequestFunction::Run() { ExtensionFunction::ResponseAction CryptotokenPrivateRecordSignRequestFunction::Run() { - auto params = cryptotoken_private::RecordSignRequest::Params::Create(*args_); + auto params = cryptotoken_private::RecordSignRequest::Params::Create(args()); EXTENSION_FUNCTION_VALIDATE(params); content::RenderFrameHost* frame = RenderFrameHostForTabAndFrameId( diff --git a/shell/browser/extensions/api/resources_private/resources_private_api.cc b/shell/browser/extensions/api/resources_private/resources_private_api.cc index f29837d6ca53b..48cb45dc2d0ac 100644 --- a/shell/browser/extensions/api/resources_private/resources_private_api.cc +++ b/shell/browser/extensions/api/resources_private/resources_private_api.cc @@ -81,7 +81,7 @@ ResourcesPrivateGetStringsFunction::~ResourcesPrivateGetStringsFunction() = ExtensionFunction::ResponseAction ResourcesPrivateGetStringsFunction::Run() { std::unique_ptr params( - get_strings::Params::Create(*args_)); + get_strings::Params::Create(args())); auto dict = std::make_unique(); api::resources_private::Component component = params->component; diff --git a/shell/browser/javascript_environment.cc b/shell/browser/javascript_environment.cc index f6034d4ee8192..da6f11397b651 100644 --- a/shell/browser/javascript_environment.cc +++ b/shell/browser/javascript_environment.cc @@ -75,7 +75,7 @@ class ArrayBufferAllocator : public v8::ArrayBuffer::Allocator { allocator_->init({base::PartitionOptions::AlignedAlloc::kDisallowed, base::PartitionOptions::ThreadCache::kDisabled, base::PartitionOptions::Quarantine::kAllowed, - base::PartitionOptions::Cookies::kAllowed, + base::PartitionOptions::Cookie::kAllowed, base::PartitionOptions::RefCount::kDisallowed}); } diff --git a/shell/browser/javascript_environment.h b/shell/browser/javascript_environment.h index 65fb113fd466a..100bdd87ac995 100644 --- a/shell/browser/javascript_environment.h +++ b/shell/browser/javascript_environment.h @@ -10,6 +10,7 @@ #include "base/macros.h" #include "gin/public/isolate_holder.h" #include "uv.h" // NOLINT(build/include_directory) +#include "v8/include/v8-locker.h" namespace node { class Environment; diff --git a/shell/browser/net/network_context_service.cc b/shell/browser/net/network_context_service.cc index 52bf91b354928..909f1ee68ae57 100644 --- a/shell/browser/net/network_context_service.cc +++ b/shell/browser/net/network_context_service.cc @@ -68,12 +68,17 @@ void NetworkContextService::ConfigureNetworkContextParams( network_context_params->http_cache_max_size = browser_context_->GetMaxCacheSize(); + network_context_params->file_paths = + network::mojom::NetworkContextFilePaths::New(); + network_context_params->file_paths->data_path = path; + // Currently this just contains HttpServerProperties - network_context_params->http_server_properties_path = - path.Append(chrome::kNetworkPersistentStateFilename); + network_context_params->file_paths->http_server_properties_file_name = + base::FilePath(chrome::kNetworkPersistentStateFilename); // Configure persistent cookie path. - network_context_params->cookie_path = path.Append(chrome::kCookieFilename); + network_context_params->file_paths->cookie_database_name = + base::FilePath(chrome::kCookieFilename); network_context_params->restore_old_session_cookies = false; network_context_params->persist_session_cookies = false; @@ -81,7 +86,8 @@ void NetworkContextService::ConfigureNetworkContextParams( network_context_params->enable_encrypted_cookies = electron::fuses::IsCookieEncryptionEnabled(); - network_context_params->transport_security_persister_file_path = path; + network_context_params->file_paths->transport_security_persister_file_name = + base::FilePath(chrome::kTransportSecurityPersisterFilename); } proxy_config_monitor_.AddToNetworkContextParams(network_context_params); diff --git a/shell/browser/osr/osr_render_widget_host_view.cc b/shell/browser/osr/osr_render_widget_host_view.cc index bd60514e5dc20..2583c2bd886b4 100644 --- a/shell/browser/osr/osr_render_widget_host_view.cc +++ b/shell/browser/osr/osr_render_widget_host_view.cc @@ -396,7 +396,8 @@ void OffScreenRenderWidgetHostView::ResetFallbackToFirstNavigationSurface() { void OffScreenRenderWidgetHostView::InitAsPopup( content::RenderWidgetHostView* parent_host_view, - const gfx::Rect& pos) { + const gfx::Rect& pos, + const gfx::Rect& anchor_rect) { DCHECK_EQ(parent_host_view_, parent_host_view); DCHECK_EQ(widget_type_, content::WidgetType::kPopup); diff --git a/shell/browser/osr/osr_render_widget_host_view.h b/shell/browser/osr/osr_render_widget_host_view.h index 477c304787048..ccc4ca4618abb 100644 --- a/shell/browser/osr/osr_render_widget_host_view.h +++ b/shell/browser/osr/osr_render_widget_host_view.h @@ -114,7 +114,8 @@ class OffScreenRenderWidgetHostView : public content::RenderWidgetHostViewBase, void ResetFallbackToFirstNavigationSurface() override; void InitAsPopup(content::RenderWidgetHostView* parent_host_view, - const gfx::Rect& rect) override; + const gfx::Rect& pos, + const gfx::Rect& anchor_rect) override; void UpdateCursor(const content::WebCursor&) override; void SetIsLoading(bool is_loading) override; void TextInputStateChanged(const ui::mojom::TextInputState& params) override; diff --git a/shell/browser/ui/gtk/status_icon.cc b/shell/browser/ui/gtk/status_icon.cc index b14b71de64e56..975f2a2ef89a6 100644 --- a/shell/browser/ui/gtk/status_icon.cc +++ b/shell/browser/ui/gtk/status_icon.cc @@ -52,7 +52,6 @@ std::unique_ptr CreateLinuxStatusIcon( } else { return std::make_unique(image, tool_tip); } - return nullptr; #endif } diff --git a/shell/browser/ui/webui/accessibility_ui.cc b/shell/browser/ui/webui/accessibility_ui.cc index 55dda5e70eee6..92b3d1e4a13bc 100644 --- a/shell/browser/ui/webui/accessibility_ui.cc +++ b/shell/browser/ui/webui/accessibility_ui.cc @@ -391,25 +391,25 @@ void ElectronAccessibilityUIMessageHandler::RequestNativeUITree( void ElectronAccessibilityUIMessageHandler::RegisterMessages() { DCHECK_CURRENTLY_ON(content::BrowserThread::UI); - web_ui()->RegisterMessageCallback( + web_ui()->RegisterDeprecatedMessageCallback( "toggleAccessibility", base::BindRepeating(&AccessibilityUIMessageHandler::ToggleAccessibility, base::Unretained(this))); - web_ui()->RegisterMessageCallback( + web_ui()->RegisterDeprecatedMessageCallback( "setGlobalFlag", base::BindRepeating(&AccessibilityUIMessageHandler::SetGlobalFlag, base::Unretained(this))); - web_ui()->RegisterMessageCallback( + web_ui()->RegisterDeprecatedMessageCallback( "requestWebContentsTree", base::BindRepeating( &AccessibilityUIMessageHandler::RequestWebContentsTree, base::Unretained(this))); - web_ui()->RegisterMessageCallback( + web_ui()->RegisterDeprecatedMessageCallback( "requestNativeUITree", base::BindRepeating( &ElectronAccessibilityUIMessageHandler::RequestNativeUITree, base::Unretained(this))); - web_ui()->RegisterMessageCallback( + web_ui()->RegisterDeprecatedMessageCallback( "requestAccessibilityEvents", base::BindRepeating( &AccessibilityUIMessageHandler::RequestAccessibilityEvents, diff --git a/shell/common/gin_converters/time_converter.cc b/shell/common/gin_converters/time_converter.cc index c4a9267b915b2..cc53c7f2a93a0 100644 --- a/shell/common/gin_converters/time_converter.cc +++ b/shell/common/gin_converters/time_converter.cc @@ -5,6 +5,7 @@ #include "shell/common/gin_converters/time_converter.h" #include "base/time/time.h" +#include "v8/include/v8-date.h" namespace gin { diff --git a/shell/common/gin_helper/arguments.cc b/shell/common/gin_helper/arguments.cc index ec97b875d6d10..4e82443ca8e7a 100644 --- a/shell/common/gin_helper/arguments.cc +++ b/shell/common/gin_helper/arguments.cc @@ -4,6 +4,7 @@ #include "shell/common/gin_helper/arguments.h" +#include "v8/include/v8-exception.h" namespace gin_helper { void Arguments::ThrowError() const { diff --git a/shell/renderer/renderer_client_base.cc b/shell/renderer/renderer_client_base.cc index 7366a7f3fef36..44084a826058a 100644 --- a/shell/renderer/renderer_client_base.cc +++ b/shell/renderer/renderer_client_base.cc @@ -82,7 +82,6 @@ #include "extensions/common/extensions_client.h" #include "extensions/renderer/dispatcher.h" #include "extensions/renderer/extension_frame_helper.h" -#include "extensions/renderer/guest_view/extensions_guest_view_container_dispatcher.h" #include "extensions/renderer/guest_view/mime_handler_view/mime_handler_view_container_manager.h" #include "shell/common/extensions/electron_extensions_client.h" #include "shell/renderer/extensions/electron_extensions_renderer_client.h" diff --git a/spec/api-clipboard-spec.js b/spec/api-clipboard-spec.js index d52e7c0aaf1f6..3a4e6426c346f 100644 --- a/spec/api-clipboard-spec.js +++ b/spec/api-clipboard-spec.js @@ -53,10 +53,12 @@ ifdescribe(process.platform !== 'win32' || process.arch !== 'arm64')('clipboard it('returns title and url', () => { clipboard.writeBookmark('a title', 'https://electronjs.org'); - expect(clipboard.readBookmark()).to.deep.equal({ - title: 'a title', - url: 'https://electronjs.org' - }); + + const readBookmark = clipboard.readBookmark(); + if (process.platform !== 'win32') { + expect(readBookmark.title).to.equal('a title'); + } + expect(clipboard.readBookmark().url).to.equal('https://electronjs.org'); clipboard.writeText('no bookmark'); expect(clipboard.readBookmark()).to.deep.equal({ @@ -89,7 +91,11 @@ ifdescribe(process.platform !== 'win32' || process.arch !== 'arm64')('clipboard expect(readImage.toDataURL()).to.equal(i.toDataURL()); if (process.platform !== 'linux') { - expect(clipboard.readBookmark()).to.deep.equal(bookmark); + if (process.platform !== 'win32') { + expect(clipboard.readBookmark()).to.deep.equal(bookmark); + } else { + expect(clipboard.readBookmark().url).to.equal(bookmark.url); + } } }); });