From 446acd317aed37c1e7f09036494258022457c09b Mon Sep 17 00:00:00 2001 From: Charles Kerr Date: Wed, 14 Oct 2020 22:56:02 -0500 Subject: [PATCH] perf: remove GC timer that fired once per minute. --- shell/browser/electron_browser_main_parts.cc | 5 ----- shell/browser/electron_browser_main_parts.h | 2 -- 2 files changed, 7 deletions(-) diff --git a/shell/browser/electron_browser_main_parts.cc b/shell/browser/electron_browser_main_parts.cc index a5f74d9bf34cb..33322d4a3d943 100644 --- a/shell/browser/electron_browser_main_parts.cc +++ b/shell/browser/electron_browser_main_parts.cc @@ -405,11 +405,6 @@ void ElectronBrowserMainParts::PreMainMessageLoopRun() { ui::TouchFactory::SetTouchDeviceListFromCommandLine(); #endif - // Start idle gc. - gc_timer_.Start(FROM_HERE, base::TimeDelta::FromMinutes(1), - base::BindRepeating(&v8::Isolate::LowMemoryNotification, - base::Unretained(js_env_->isolate()))); - content::WebUIControllerFactory::RegisterFactory( ElectronWebUIControllerFactory::GetInstance()); diff --git a/shell/browser/electron_browser_main_parts.h b/shell/browser/electron_browser_main_parts.h index 56733af33f60e..e5f86fec1b840 100644 --- a/shell/browser/electron_browser_main_parts.h +++ b/shell/browser/electron_browser_main_parts.h @@ -158,8 +158,6 @@ class ElectronBrowserMainParts : public content::BrowserMainParts { std::unique_ptr extensions_browser_client_; #endif - base::RepeatingTimer gc_timer_; - // List of callbacks should be executed before destroying JS env. std::list destructors_;