From 37c1df6ce111c1eb22481e7462592c962cdbbee3 Mon Sep 17 00:00:00 2001 From: "trop[bot]" <37223003+trop[bot]@users.noreply.github.com> Date: Mon, 4 Nov 2019 14:17:15 -0800 Subject: [PATCH] fix: don't copy tray image when it's set (#20935) --- shell/browser/ui/tray_icon_cocoa.mm | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/shell/browser/ui/tray_icon_cocoa.mm b/shell/browser/ui/tray_icon_cocoa.mm index b5d4edf84331b..88bffe8538b37 100644 --- a/shell/browser/ui/tray_icon_cocoa.mm +++ b/shell/browser/ui/tray_icon_cocoa.mm @@ -87,12 +87,12 @@ - (void)removeItem { } - (void)setImage:(NSImage*)image { - [[statusItem_ button] setImage:[image copy]]; + [[statusItem_ button] setImage:image]; [self updateDimensions]; } - (void)setAlternateImage:(NSImage*)image { - [[statusItem_ button] setAlternateImage:[image copy]]; + [[statusItem_ button] setAlternateImage:image]; } - (void)setIgnoreDoubleClickEvents:(BOOL)ignore { @@ -108,7 +108,7 @@ - (void)setTitle:(NSString*)title { [[statusItem_ button] setAttributedTitle:[title attributedStringParsingANSICodes]]; } else { - [[statusItem_ button] setTitle:[title copy]]; + [[statusItem_ button] setTitle:title]; } // Fix icon margins.