From 03852ddd507ce7ac0ade9df765d0b6d77aa75e8b Mon Sep 17 00:00:00 2001
From: Cezary Kulakowski <cezary@openfin.co>
Date: Thu, 12 Mar 2020 17:05:27 +0100
Subject: [PATCH] fix: don't assign NSAlert to window which is not visible

Without this change it's possible to create message box which can't
be dismissed on mac.
---
 shell/browser/ui/message_box_mac.mm | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/shell/browser/ui/message_box_mac.mm b/shell/browser/ui/message_box_mac.mm
index cdfc4797f9907..8a32b1858c2b2 100644
--- a/shell/browser/ui/message_box_mac.mm
+++ b/shell/browser/ui/message_box_mac.mm
@@ -93,12 +93,11 @@
 
 }  // namespace
 
-int ShowMessageBoxSync(const MessageBoxSettings& settings) {
   NSAlert* alert = CreateNSAlert(settings);
 
   // Use runModal for synchronous alert without parent, since we don't have a
   // window to wait for.
-  if (!settings.parent_window)
+  if (!settings.parent_window || !settings.parent_window->IsVisible())
     return [[alert autorelease] runModal];
 
   __block int ret_code = -1;