Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: properly import info logger #1405

Merged
merged 3 commits into from
Aug 23, 2022
Merged

Conversation

Karangoyal25892
Copy link
Contributor

@Karangoyal25892 Karangoyal25892 commented Aug 23, 2022

Fixes #1404

Common is not imported in the cli.js.
so builds are failing.

image

@welcome
Copy link

welcome bot commented Aug 23, 2022

Thanks for opening a pull request!

Here are some highlighted action items that will help get it across the finish line, from the
pull request guidelines:

  • Follow the JavaScript coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes in NEWS.md and other docs.
  • Include tests when adding/changing behavior.

Development and triage is community-driven, so please be patient and we will get back to you as soon as we can.

Removed Common and added info in the imports.
@codecov
Copy link

codecov bot commented Aug 23, 2022

Codecov Report

Merging #1405 (9a0ef76) into main (0d692d7) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1405   +/-   ##
=======================================
  Coverage   95.61%   95.61%           
=======================================
  Files          15       15           
  Lines         776      776           
=======================================
  Hits          742      742           
  Misses         34       34           
Impacted Files Coverage Δ
src/cli.js 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@erickzhao erickzhao changed the title 1404: Electron package build is failing after the latest release [15.5.2] fix: properly import info logger Aug 23, 2022
@erickzhao erickzhao self-requested a review August 23, 2022 17:47
@malept
Copy link
Member

malept commented Aug 23, 2022

It'd be nice if there was a end to end test which caught this in the future

@erickzhao erickzhao merged commit 5c0102a into electron:main Aug 23, 2022
@welcome
Copy link

welcome bot commented Aug 23, 2022

Thanks for your contribution! 🎉

@VerteDinde
Copy link
Member

@Karangoyal25892 This is fixed in 16.0.0 - the major bump is dropping Node 10 & 12 support, and adding Node 16 & 18. Thanks for reporting this!

@Karangoyal25892 Karangoyal25892 deleted the patch-1 branch August 25, 2022 05:31
@qingfeng14
Copy link

qingfeng14 commented Aug 26, 2022

@Karangoyal25892 This is fixed in 16.0.0 - the major bump is dropping Node 10 & 12 support, and adding Node 16 & 18. Thanks for reporting this!

@VerteDinde Whether it is possible to publish 15.5.3 with this fix, cause the bug in 15.5.2 will fail builds with "electron-packager": "^15.x.x" dependencies

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Electron package build is failing after the latest release [15.5.2]
5 participants