Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: upgrade Node.js to 14 LTS #1399

Merged
merged 2 commits into from
Aug 23, 2022
Merged

Conversation

VerteDinde
Copy link
Member

@VerteDinde VerteDinde commented Aug 11, 2022

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

Relands #1393 after cutting a new version of packager with a fix for Electron 20.

@codecov
Copy link

codecov bot commented Aug 11, 2022

Codecov Report

Merging #1399 (62c7006) into main (a723fa8) will decrease coverage by 0.64%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1399      +/-   ##
==========================================
- Coverage   95.61%   94.97%   -0.65%     
==========================================
  Files          15       15              
  Lines         776      776              
==========================================
- Hits          742      737       -5     
- Misses         34       39       +5     
Impacted Files Coverage Δ
src/mac.js 97.09% <0.00%> (-2.91%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@VerteDinde VerteDinde merged commit 0d692d7 into electron:main Aug 23, 2022
@VerteDinde VerteDinde deleted the reland-node-bump branch August 23, 2022 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants