Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: "feat!: upgrade Node.js to 14 LTS (#1393)" #1398

Merged
merged 2 commits into from
Aug 11, 2022

Conversation

VerteDinde
Copy link
Member

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:
This reverts commit c6b4c78, allowing us to release a new version of packager before a breaking change.

Copy link
Member

@malept malept left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: once tests pass

@codecov
Copy link

codecov bot commented Aug 11, 2022

Codecov Report

Merging #1398 (7b17d18) into main (7dcaf44) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1398   +/-   ##
=======================================
  Coverage   95.61%   95.61%           
=======================================
  Files          15       15           
  Lines         776      776           
=======================================
  Hits          742      742           
  Misses         34       34           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@erickzhao erickzhao merged commit 7c01d6f into electron:main Aug 11, 2022
@VerteDinde VerteDinde deleted the revert-node-14-bump branch August 11, 2022 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants