Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: automatically insert ElectronAsarIntegrity into Info.plist #1279

Merged
merged 2 commits into from
Sep 9, 2021

Conversation

MarshallOfSound
Copy link
Member

Refs electron/electron#30667

Small addition to automatically insert the new (currently optional) ElectronAsarIntegrity block into your Info.plist

@codecov
Copy link

codecov bot commented Sep 9, 2021

Codecov Report

Merging #1279 (488be55) into main (727a610) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main     #1279   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           14        14           
  Lines          726       733    +7     
=========================================
+ Hits           726       733    +7     
Impacted Files Coverage Δ
src/mac.js 100.00% <100.00%> (ø)
src/platform.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 727a610...488be55. Read the comment docs.

Copy link
Member

@malept malept left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks reasonable, but I'd like some tests added as well.

@MarshallOfSound
Copy link
Member Author

@malept Tests added 👍

Copy link
Member

@malept malept left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will try to make a new release tonight or tomorrow.

@malept malept merged commit 120f5b2 into main Sep 9, 2021
@malept malept deleted the asar-integrity branch September 9, 2021 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants