Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mac): compatibility with electron-notarize@^1.1.0 #1278

Merged
merged 5 commits into from
Sep 5, 2021

Conversation

malept
Copy link
Member

@malept malept commented Sep 4, 2021

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

electron-notarize 1.1.0 added a new mode (using the new notarytool binary) which caused validateAuthorizationArgs to break.

Update notarization support so that the tool: notarytool option works with TypeScript.

Since the module handles its own validation, I'm removing it from this module.

Fixes #1277.

@codecov
Copy link

codecov bot commented Sep 4, 2021

Codecov Report

Merging #1278 (80aba35) into main (bde6031) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main     #1278   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           14        14           
  Lines          729       726    -3     
=========================================
- Hits           729       726    -3     
Impacted Files Coverage Δ
src/mac.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bde6031...80aba35. Read the comment docs.

@malept malept merged commit 727a610 into main Sep 5, 2021
@malept malept deleted the malept/fix/electron-notarize-1.1.0-types branch September 5, 2021 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

validateAuthorizationArgs doesn't work when using keychain and keychainProfile
1 participant