Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mac): don't fail if the icon path given doesn't exist #1101

Merged
merged 1 commit into from
Jan 13, 2020

Conversation

malept
Copy link
Member

@malept malept commented Jan 13, 2020

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

Noticed in #1100. It generates a warning if the icon specified isn't found.

@codecov-io
Copy link

codecov-io commented Jan 13, 2020

Codecov Report

Merging #1101 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1101   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files          14      14           
  Lines         711     712    +1     
======================================
+ Hits          711     712    +1
Impacted Files Coverage Δ
src/platform.js 100% <ø> (ø) ⬆️
src/mac.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3090c4c...c866344. Read the comment docs.

@malept malept merged commit 291680b into master Jan 13, 2020
@malept malept deleted the fix-missing-mac-icon-path branch January 13, 2020 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants