Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for win32/arm64 official builds #1053

Merged
merged 1 commit into from
Oct 10, 2019
Merged

Conversation

malept
Copy link
Member

@malept malept commented Sep 25, 2019

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

Official win32/arm64 builds were added in Electron 6.0.8.

Fixes #1052.

@codecov-io
Copy link

codecov-io commented Sep 25, 2019

Codecov Report

Merging #1053 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1053   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files          14      14           
  Lines         695     695           
======================================
  Hits          695     695
Impacted Files Coverage Δ
src/targets.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3ad027...ac54c33. Read the comment docs.

@malept
Copy link
Member Author

malept commented Sep 25, 2019

I did a quick smoketest - rcedit doesn't crash when operating on the win32/arm64 binary.

@malept malept merged commit 5d48f3e into master Oct 10, 2019
@malept malept deleted the windows-arm64 branch October 10, 2019 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for official builds of Windows ARM64 binaries
2 participants