build: update docker images #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BlackHole1
approved these changes
May 21, 2022
MarshallOfSound
approved these changes
May 21, 2022
|
🎉 This PR is included in version 3.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Spacetech
pushed a commit
to Spacetech/asar
that referenced
this pull request
Aug 6, 2022
* build: upgrade docker images * VERSION NUMBERS * add apt-get update * tweaks * add xvfb * update nodejs versions * typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After making a trivial PR (#236), I realized that the CircleCI job for Linux was consistently failing.
I made a few upgrades and fixes:
sudo apt-get updatebeforesudo apt-get install.circleci/node:XXimages to the newercimg/node:XX.YY.ZZimages. Needed to also installxvfbhere because I think the newer images don't come with it installed.