From 53014ef882c0c8baca1345909a05e8896dc1996f Mon Sep 17 00:00:00 2001 From: Mikael Finstad Date: Fri, 26 Apr 2024 00:43:41 +0200 Subject: [PATCH 1/2] Treat cscLink empty same as absent I think this is expected with env variables that empty string means disabled. currently if set to empty string it crashes with: Error: Env WIN_CSC_LINK is not correct, cannot resolve: D:\a\path\to\project not a file --- packages/app-builder-lib/src/winPackager.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/app-builder-lib/src/winPackager.ts b/packages/app-builder-lib/src/winPackager.ts index 7b8a0efce9..b2ed8fa260 100644 --- a/packages/app-builder-lib/src/winPackager.ts +++ b/packages/app-builder-lib/src/winPackager.ts @@ -63,7 +63,7 @@ export class WinPackager extends PlatformPackager { } const cscLink = this.getCscLink("WIN_CSC_LINK") - if (cscLink == null) { + if (cscLink == null || cscLink === '') { return Promise.resolve(null) } From 3fb1d542466622bd9d334857c2e68c7e3afeda4d Mon Sep 17 00:00:00 2001 From: Mike Maietta Date: Fri, 26 Apr 2024 11:25:26 -0700 Subject: [PATCH 2/2] Create tame-balloons-walk.md --- .changeset/tame-balloons-walk.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/tame-balloons-walk.md diff --git a/.changeset/tame-balloons-walk.md b/.changeset/tame-balloons-walk.md new file mode 100644 index 0000000000..6dc6a929ef --- /dev/null +++ b/.changeset/tame-balloons-walk.md @@ -0,0 +1,5 @@ +--- +"app-builder-lib": patch +--- + +fix: Treat cscLink empty string same as null