On Windows, running app not quit when uninstalling the app but uninstallation just completed

[kafka-yu]

Hi team,

we find a strange issue: When uninstalling, the running app is not able to quit automatically. The uninstallation is completed fast. And the files are deleted except the files that are app running used.

The package below config to pack the app, and with a custom NSIS script to do "customInstall" and "customUninstall" steps.

  nsis: {
         include: "./scripts/nsis.custom.installer.nsh",
        uninstallDisplayName: "Test App",
        allowToChangeInstallationDirectory: true,
        createStartMenuShortcut: true,
        runAfterFinish: true,
        oneClick: false,
        warningsAsErrors: false, // delete registry key may show warning, ignore it
        differentialPackage: false,
      },
      win: {
        icon: "win.ico",
        certificateFile: certification.certificate,
        certificatePassword: certification.password,
        signingHashAlgorithms: [certification.algorithm],
        rfc3161TimeStampServer: certification.rfcTimestamp,
        protocols: appConfig.protocols,
      },

The installer.nsh file content:

!define SCHEMENAME "test-app-open-plugin" #URL Protocol

!macro customInstall
  DetailPrint "Register ${SCHEMENAME} URI Handler"
  DeleteRegKey HKCU "Software\Classes\${SCHEMENAME}"
  WriteRegStr HKCU "Software\Classes\${SCHEMENAME}" "" "${PRODUCT_NAME}"
  WriteRegStr HKCU "Software\Classes\${SCHEMENAME}" "URL Protocol" ""
  WriteRegStr HKCU "Software\Classes\${SCHEMENAME}\DefaultIcon" "" "$INSTDIR\${APP_EXECUTABLE_FILENAME}"
  WriteRegStr HKCU "Software\Classes\${SCHEMENAME}\shell" "" ""
  WriteRegStr HKCU "Software\Classes\${SCHEMENAME}\shell\Open" "" ""
  WriteRegStr HKCU "Software\Classes\${SCHEMENAME}\shell\Open\command" "" "$INSTDIR\${APP_EXECUTABLE_FILENAME} %1"
!macroend

!macro customUnInstall
  DeleteRegKey HKCU "Software\Classes\${SCHEMENAME}"
!macroend

Does anyone know the reason?

• Electron-Builder Version: 23.6.0

• Node Version:

• Electron Version: 20.0.0
• Electron Type (current, beta, nightly): current

• Target: nsis, Windows

[mmaietta]

What electron-updater version are you using? Was this working previously?

[kafka-yu]

What electron-updater version are you using? Was this working previously?

the version of electron-updater is at: ^5.3.0. Yeah it worked previously, Recently we add customUninstall nsh script to delete Registry Keys, but it doesn't work even this part is reverted.

[kafka-yu]

do you have any other insights?

[mmaietta]

I don't know enough about nsh scripting (or windows development) to be able to provide insights there.
My best advice is that this warningsAsErrors: false is hiding an issue with the new uninstaller script

[kafka-yu]

hmm,, I tried removing that customized nsis stuff, and test in a clean Windows VM, but still no luck.

Downgrade to electron-builder 23.3.0 is also not working.

I've another app uses 22.11.11, it works correctly.

UPDATE:
I downgrade to 22.11.11 with the above config, which is also working!! During uninstalling, it will ask to Close the running app.

[kafka-yu]

Is there any way to enable logs on windows? I checked some issues e.g. brimdata/zui#2713 but seems not solution.. Maybe I should upgrade to 24.1.2 to have a try?

24.1.2 still not working either.

[mmaietta]

You'll need to provide your own custom nsis binary that supports debug logging. (I tried to build it in directly to electron-builder, but 3.0.4.2 nsis was throwing off alerts from antivirus programs, so we are stuck with 3.0.4.1

https://github.com/electron-userland/electron-builder/blob/master/packages/app-builder-lib/src/targets/nsis/nsisOptions.ts#L55

/**
   * Allows you to provide your own `makensis`, such as one with support for debug logging via LogSet and LogText. (Logging also requires option `debugLogging = true`)
   */
  readonly customNsisBinary?: CustomNsisBinary | null

Quick link to the interface below:

electron-builder/packages/app-builder-lib/src/targets/nsis/nsisOptions.ts

Line 4 in ac9c33c

interface CustomNsisBinary {

[kafka-yu]

Thanks @mmaietta I got> "Error: LogSet specified, NSIS_CONFIG_LOG not defined." when I set

 {
 url: 'https://github.com/electron-userland/electron-builder-binaries/releases/download',
  debugLogging: true,
  checksum:
    'VKMiizYdmNdJOWpRGz4trl4lD++BvYP2irAXpMilheUP0pc93iKlWAoP843Vlraj8YG19CVn0j+dCo/hURz9+Q==',
  version: '3.0.4.1',
}

Tried "nsis-3.0.8-log", and now it can output logs. I saw it tries to remove the Exe file directly, but no logs say it is checking the app running or not.

Delete: DeleteFile failed("C:\Users**\AppData\Local\Programs\Test app plugin\Test app plugin.exe")

BTW, do you know why 22.11.11 works?

I checked the changes history between 22.11.11 ---> 23.6.0, only some MRs merged:

• fix(nsis): should close app when Silent and ONE_CLICK #6100
• feat: allow custom makensis and logging #6024
• fix(nsis): use atomic rmdir on update #6551

Those MRs changed the "uninstall.nsh", but not sure which one.

[mmaietta]

https://github.com/electron-userland/electron-builder/pull/6024/files
Uses 3.0.4.2 makensis which has debug compiler flag available, but the change had to be reverted due to the anti-virus issue mentioned earlier.
3.0.4.1 does not have the debug compiler flag

[kafka-yu]

Here is the log file, would you pls help a look? Thanks.

The error I saw is:

Delete: DeleteFile failed("C:\Users\test\AppData\Local\Programs\Test app plugin\Test app plugin.exe")

Looks like the app not quit before deleting..

install.log

[kafka-yu]

@mmaietta would you pls help check the above logs? thanks.

[mmaietta]

In all honesty, I have no idea how nsis works or am able to debug installers. I did take a look at the install.log file for you, but I don't know what I'm reading

[kafka-yu]

@mmaietta I found something that, If I changed the product name to another one, then it works.

E.g. If it is named "Desktop Plugin" it works, but if changed to name ("RingCentral Desktop Plugin"), it is not working. Is there a bug in the process name comparing? Since if I changed to electron-builder: 22.11.11, both work.

Those names work:

• Next Plugin
• Next for Plugin
• Desktop Plugin

Those names do not work:

• Centralize for Desktop Plugin
• Next for Desktop Plugin

[kafka-yu]

@indutny @lwintermelon do you have any idea about this issue? Would you please help check? Since I saw last last time you did some changes on uninstaller part. Appricated. Thanks!

[unzld]

@kafka-yu could you provide the customNsisBinary setting that you used to enable logging?

[lwintermelon]

@indutny @lwintermelon do you have any idea about this issue? Would you please help check? Since I saw last last time you did some changes on uninstaller part. Appricated. Thanks!

Sorry for the late reply. The issus is very similar to what I fixed on #6100, maybe you can check this PR and try to fix the issue.

[kafka-yu]

thanks for your reply! @lwintermelon I checked but have no idea about the fixing solution, could you pls give some hints about this part? Thank you!

[github-actions]

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

[github-actions]

This issue was closed because it has been stalled for 5 days with no activity.

[repl-minatee-p]

I am also facing the same issue after I changed the product name.
@kafka-yu Did you find any solution for this issue ?

Electron-Builder Version : 23.6.0
Electron-Updater Version: 5.3.0
Electron Version: 24.6.5

[Quincysacc]

I am having this issue. I uninstalled it, and i kept getting a popup saying, "electron.exe System error" something about dll, and how I had to reinstall the app to fix the issue. But seeing as I'd get this popup every time I turned on my PC. I knew it was running in the background causing the popups. For me what fixed it, I just opened task manager and found that electron was somehow still running in the background, I just selected it after closing the popup, and deleted it from the task manager menu. Hopefully this helps someone else.

[Quincysacc]

Hopefully you found the issue, did you try to open task manager to see if it was somehow running in the background?