Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is stagingPercentage: 0 supported? #6231

Open
aguynamedben opened this issue Sep 5, 2021 · 6 comments
Open

Is stagingPercentage: 0 supported? #6231

aguynamedben opened this issue Sep 5, 2021 · 6 comments

Comments

@aguynamedben
Copy link
Contributor

We used the "staged rollouts" feature and usually roll out to 10% of our users first.

We recently got bit by the mac port is null bug. In emergency situations I've been setting stagingPercentage: 1 to go to 1%. Is stagingPercentage: 0 supported? What happens if I do that? My guess is all users stay on the version they're currently on, but I'm not sure if it's supported.

@aguynamedben
Copy link
Contributor Author

Someone else on my team assumed that "0" might somehow go to undefined which means "go to 100%" which would be unexpected to me. So please don't guess, haha. :)

@ezekg
Copy link
Contributor

ezekg commented Sep 7, 2021

According to this line, if staging percentage is zero, then it looks like no user will receive an update. This is because the user's staging UUIDv5 will never equal a percentage less than 0, since negative numbers are not possible with unsigned ints.

stagingPercentage = 0
stagingPercentage / 100
// => 0

But then again, without a real test, I guess I'm breaking your 'no guessing' rule. 😅

@stale
Copy link

stale bot commented Apr 17, 2022

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the backlog label Apr 17, 2022
@aguynamedben
Copy link
Contributor Author

What would help resolve this:

  • Authors of the autoUpdater confirm that stagingPercentage = 0 is officially supported (we only have guesses here)
  • Add to documentation that it's officially supported?

@stale stale bot removed the backlog label Apr 18, 2022
@Nokel81
Copy link
Contributor

Nokel81 commented Jun 21, 2022

What would also be helpful is a way to inject a stagingPercentage through the configuration. At least there is no documentation about where you could put that

@Nantris
Copy link

Nantris commented Jul 26, 2022

I wanted to share that stagingPercentage = 0.1 rounded down to stagingPercentage = 0 and resulted in no users receiving updates, so I think you can assume it will operate as I have found: #3891

Also it would be great to have @Nokel81's suggestion addressed; regarding having a way to set stagingPercentage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants