feat: Adding Keygen as an official publisher/updater for electron-builder

[mmaietta]

CC @ezekg

[changeset-bot]

🦋 Changeset detected

Latest commit: 0880d1b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 12 packages

Name	Type
app-builder-lib	Minor
builder-util	Minor
builder-util-runtime	Minor
electron-publish	Minor
electron-updater	Minor
dmg-builder	Minor
electron-builder-squirrel-windows	Minor
electron-builder	Minor
electron-forge-maker-appimage	Minor
electron-forge-maker-nsis-web	Minor
electron-forge-maker-nsis	Minor
electron-forge-maker-snap	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[mmaietta]

@ezekg few quick notes 🙂

If you want to ignore 5xx errors, I'd suggest also checking for other common 500s: 500, 503 and 504.

I actually pulled this logic from Bintray, but I'm more than happy to scan for the other errors as well. Can just check for any status code that starts with 50?

electron-builder/packages/app-builder-lib/src/publish/BintrayPublisher.ts

Lines 86 to 88 in 331406a

	if (attemptNumber < 3 && ((e instanceof HttpError && e.statusCode === 502) || e.code === "EPIPE")) {
	continue
	}

The data and errors properties will never be returned at the same time. So on API error, this will be accessing undefined.id, which will throw.

I actually pulled this from the documentation that both would be returned. Would you be willing to update it? I found it confusing.
https://keygen.sh/docs/api/#releases-upsert
const { data, errors } = await response.json()

I'll update the logic accordingly in my PR

[ezekg]

I actually pulled this logic from Bintray, but I'm more than happy to scan for the other errors as well. Can just check for any status code that starts with 50?

Yep, generally, you can use statusCode >= 500 && statusCode <= 599 to test for a range of HTTP status codes.

I will update the API docs to make return values clearer when an error occurs, thanks for the feedback.

[mmaietta]

Hey @ezekg! Quick note for documentation: The end-user will need to know this detail of adding the "Bearer " prefix on their own. I think the function's name makes it self-explanatory that it's the Authorization header, but might still be worth noting in the docs.

[ezekg]

Overall, looks great. A couple notes/nits which can be safely ignored. Excited for this! 🙂