fix(electron-updater): null object error when MacUpdater logs server port before it is listening
#6149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Node's HTTP server `address()` method returns `null` until the server is listening for connections. This commit fixes a bug where `MacUpdater` attempts to log the server port before it is listening. The existing log event is still recorded, without the server address. When the server is listening, a new event is recorded that includes the server address.
🦋 Changeset detectedLatest commit: 5c7a24c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
tessro
changed the title
null object error in electron-updater on macOSnull object error in electron-updater on macOS
mmaietta
changed the title
null object error in electron-updater on macOSnull object error when MacUpdater logs server port before it is listening
|
This was a painful one for us. Luckily we caught it right after a deploy, but it would have broken autoupdates for all of our users. |
This was
linked to
issues
Sep 5, 2021
|
Unfortunately we shipped this to production and broke auto updates for all our mac users. |
csett86
added a commit
to jitsi/jitsi-meet-electron
that referenced
this pull request
Nov 5, 2021
Since release 2.9.1 autoupdate was broken (only!) on mac, due to electron-userland/electron-builder#6149 being part of the used version of electron-updater Revert back to stable electron-updater
csett86
added a commit
to jitsi/jitsi-meet-electron
that referenced
this pull request
Nov 5, 2021
Since release 2.9.1 autoupdate was broken (only!) on mac, due to electron-userland/electron-builder#6149 being part of the used version of electron-updater Revert back to stable electron-updater
csett86
added a commit
to jitsi/jitsi-meet-electron
that referenced
this pull request
Nov 5, 2021
Since release 2.9.1 autoupdate was broken (only!) on mac, due to electron-userland/electron-builder#6149 being part of the used version of electron-updater Revert back to stable electron-updater
csett86
added a commit
to jitsi/jitsi-meet-electron
that referenced
this pull request
Nov 6, 2021
Since release 2.9.1 autoupdate was broken (only!) on mac, due to electron-userland/electron-builder#6149 being part of the used version of electron-updater Revert back to stable electron-updater
d3473r
pushed a commit
to d3473r/jitsi-meet-electron
that referenced
this pull request
Sep 1, 2023
Since release 2.9.1 autoupdate was broken (only!) on mac, due to electron-userland/electron-builder#6149 being part of the used version of electron-updater Revert back to stable electron-updater
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue where macOS updates fail due to a
nullobject reference.Node's HTTP server
address()method returnsnulluntil the server is listening for connections.electron-updater4.4.4 and 4.4.5 contain a bug whereMacUpdaterattempts to log the server port before it is listening, which causes an error.To fix this while maintaining the completeness of the added logs, I removed the server address from the existing log event but otherwise kept it in place. When the server is listening, a new event is recorded that includes the server address.