Bug: default imports for built-in node modules in electron-updater

[thomb89]

• Electron-Builder Version: 22.11.11

• Node Version: 16.6.1

• Electron Version: 13.1.8
• Electron Type (current, beta, nightly): current

• Target: Windows

There is a bug in the electron-updater package in the file BaseUpdater.ts.

It was introduced recently with this commit: 45fc0a0.

The NodeJS Modules fs and path have no default imports

import fs from "fs"
import path from "path"

should be

import * as fs from "fs"
import * as path from "path"

or

import { writeFileSync, rmSync } from "fs"
import { join, dirname } from "path"

Because of this, it will always throw an error and set installPathRequiresElevation = true.
This is not needed, when installing in the %appdata% directory of the user.
For users without Admin-Rights, this will even install the update for the wrong user.

I think this slipped through because of the typescript compiler option "allowSyntheticDefaultImports".
With this flag

import path from "path"

path.join(...)

compiles to

const path = require('path')

path.default.join(...)

[burnhamup]

I just noticed this too, trying to test the fix for the silent updater. I submitted a pull request for the import fix.