New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use tag name instead of version when resolving GitHub files #6117
Conversation
|
Nice work! Thanks for contributing! |
Please double-check the GitHub-related tests when you can
|
Kinda took a guess as to whether y'all were rebase or merge folks and just rebased. Hope you don't mind! |
Oops, missed some tests. Fixing... |
Modify the GitHubProvider to provide the tag name of the latest release as apart of its UpdateInfo (which is now encapsulated in the GithubUpdateInfo interface) so that it uses that same tag name later when it resolves the files to download. fix electron-userland/issues/6076
Sorry for the fix-test-push loop here; I can't run all of the tests locally. 😭 |
Modify the GitHubProvider to provide the tag name of the latest
release as apart of its UpdateInfo (which is now encapsulated in the
GithubUpdateInfo interface) so that it uses that same tag name later
when it resolves the files to download.
fix /issues/6076