Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(portable): Adding support for unique dir on each portable app launch #6093

Merged

Conversation

mmaietta
Copy link
Collaborator

Enabling config for extract folder to be unique for each instance of a portable app to prevent deletion of extracted resources when closing other app instance(s).

  • Retains default of ksuid for unique extract dir per-build for empty strings and false
  • true sets to a unique temp dir $PLUGINSDIR/app per-app-launch

Implements: #5764

Copy link

@kobakou kobakou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM, and I have confirmed your new options work well as expected in my environment.
Thanks!

@mmaietta mmaietta merged commit f8e16db into electron-userland:master Jul 29, 2021
@mmaietta mmaietta deleted the feat/portable-app-extract-dir branch July 29, 2021 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants