Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release Notes Support for providers other than GitHub Releases #5895

Closed
hrueger opened this issue May 16, 2021 · 6 comments
Closed

Release Notes Support for providers other than GitHub Releases #5895

hrueger opened this issue May 16, 2021 · 6 comments
Labels

Comments

@hrueger
Copy link
Contributor

hrueger commented May 16, 2021

  • Version: 22.10.5
  • Electron Version: 12.0.7
  • Electron Type (current, beta, nightly): current
  • Target: Windows, MacOS, Linux

This is probably related to #5892. I'd like to also get release notes (in my case a changelog) for providers other than GitHub Releases. I'm using an S3 server. Maybe a .json or a .yml file could be uploaded there (like the latest.yml) to store the notes. This would also make it easier to get a full list of versions (see downgrading to specific versions in #5892)

What do you think?

@hrueger
Copy link
Contributor Author

hrueger commented Jun 23, 2021

Sorry for another ping. I'd be happy to work on this, I'd just be interested in your thoughts about how it should be accomplished.

@mmaietta
Copy link
Collaborator

Off the top of my head, I believe you can achieve this by creating the changeset yourself during an electron-builder hook, then implement a "custom" Publisher that defines its own uploader or HttpExecutor. That should allow you to customize the full configuration of files to be uploaded and could include your changeset file.

@hrueger
Copy link
Contributor Author

hrueger commented Jun 28, 2021

That's a great idea, I'll look into that, thanks.

So would you say that this is not something which other people would also like to see and you would accept a PR for? I don't think that this would be a breaking change.

@mmaietta
Copy link
Collaborator

mmaietta commented Aug 22, 2021

Sorry for leaving this hanging. Happy to accept contributions! I think it's a cool idea

It's relatively simple to get a local dev env set up: https://github.com/electron-userland/electron-builder/blob/master/CONTRIBUTING.md#to-setup-a-local-dev-environment

Where were you thinking of being able to pull the changelog from? The repo/project?

@hrueger
Copy link
Contributor Author

hrueger commented Aug 23, 2021

Sorry for leaving this hanging

No problem. The company I work for currently has set other priorities. That means I won't be able to work on that right now, but definitely in a couple weeks.

Where were you thinking of being able to pull the changelog from? The repo/project?

Yes, probably. I'll do some research if there's like a standardized changelog format which can be read programmatically.

@stale
Copy link

stale bot commented Apr 17, 2022

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the backlog label Apr 17, 2022
@stale stale bot closed this as completed Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants