Fix: Use -NoProfile Flag on getCertFromStoreInfo

[dapperdandev]

#5841

[mmaietta]

Thanks for your contribution!

Just looking to understand. Can you explain a bit further what's occurring with the addition of -NoProfile? Is it specific now due to using Write-Host?

[dapperdandev]

@mmaietta No problem!

Sorry if I explain stuff you already know.

The -NoProfile flag prevents PowerShell from loading user profile. Profiles usually include things like aliases, quick functions, and some modules. If you have a Windows machine, you can peek at yours by entering code $profile into your powershell terminal (assuming you have vs code installed).

A common use case for a dev to modify their profile is to load oh-my-posh (a fork of oh-my-zsh that works in powershell). I'm sure a lot of profiles start out looking something like mine

function Invoke-LoadModules() {
    Write-Host "Loading Modules..."
    Import-Module posh-git
    Import-Module oh-my-posh
    Set-Theme agnoster
    Write-Host "Loading Modules Complete!"
}

Invoke-LoadModules

So to answer your question, introducing -NoProfle could potentially improve performance since it will bypass loading this file. It should also prevent code signing from breaking if devs have imported any other modules that have output.

Note that it also seems to be the norm in this codebase everywhere else powershell.exe is used:

• https://github.com/electron-userland/electron-builder/blob/master/packages/electron-builder/src/cli/create-self-signed-cert.ts#L31
• https://github.com/electron-userland/electron-builder/blob/master/packages/electron-updater/src/windowsExecutableCodeSignatureVerifier.ts#L34-L42
• https://github.com/electron-userland/electron-builder/blob/master/packages/electron-updater/src/windowsExecutableCodeSignatureVerifier.ts#L104