Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Windows 7 or above is required" - Electron autoupdate fails on latest windows update. #5807

Closed
EdvinM opened this issue Apr 17, 2021 · 5 comments

Comments

@EdvinM
Copy link

EdvinM commented Apr 17, 2021

  • Version: 22.10.5
  • Electron Version: 11.4.2
  • Electron Type (current, beta, nightly): current
  • Target: Windows

Three days ago, I have updated my Windows machine to latest windows build: https://support.microsoft.com/en-us/topic/april-13-2021-kb5001330-os-builds-19041-928-and-19042-928-cead30cd-f284-4115-a42f-d67fec538490
and since then, I cannot use auto-updater anymore.

The classic error "Windows 7 or above is required" shows after I hit the update button.
At first I thought it was because I changed the windows nsis to be built only for x64, but then I realized that neither my older builds can update.

Any thoughts on this?

@EdvinM EdvinM changed the title "Windows 7 or above is required" - Electron autoupdate on latest windows update. "Windows 7 or above is required" - Electron autoupdate fails on latest windows update. Apr 17, 2021
@mmaietta
Copy link
Collaborator

😳
Would you mind pulling NSIS logs by trying this? #5119 (comment)

I found where your error is being thrown:

${If} ${IsWin2000}
${OrIf} ${IsWinME}
${OrIf} ${IsWinXP}
${OrIf} ${IsWinVista}
MessageBox MB_OK "$(win7Required)"
Quit
${EndIf}

@EdvinM
Copy link
Author

EdvinM commented Apr 27, 2021

@mmaietta I have tried to enable NSIS logging by going through the steps written on the link you referenced. The problem is that I am building my windows app on macOS, and I stumbled upon the same issue as mentioned in Issue #32. Any ideas on this?

@stale
Copy link

stale bot commented Jun 26, 2021

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the backlog label Jun 26, 2021
@mmaietta
Copy link
Collaborator

mmaietta commented Jul 4, 2021

@EdvinM yeah, I'm running into the same issue.
For nsis on mac, I researched that you'll need to use this approach https://github.com/NSIS-Dev/homebrew-makensis
(It didn't install for me though ¯\(ツ)/¯)

Once you're able to have that, you can override the makensis path via https://github.com/electron-userland/electron-builder/pull/6024/files#diff-8ad1d08aa2e58bd68d30240ff1f8390122d9a82ba65e7b57359629e03e246533R24

@stale stale bot removed the backlog label Jul 4, 2021
@stale
Copy link

stale bot commented Sep 7, 2021

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the backlog label Sep 7, 2021
@stale stale bot closed this as completed Sep 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants