New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change extract folder for each instance for portable app or preventing delete extracted resources when closing second instance? #5764
Comments
I found related reports. I think this use-case is to be considered. |
Here's a quick patch I whipped up. Please apply it to your project and report back on how it works 🙂 Use
|
@mmaietta Your patches work well, I hope your option will add to master branch! BTW, this behavior is the same as pre-v20.40 but the |
Glad to hear it worked! I'm not sure what to do with the temp folder being deleted after..., I just took a look at the git history to figure out that patch haha Any advice or ideas on where to put that in an nsis script? |
Yeah, that's where I backtracked to as well. I didn't immediately notice anything for cleaning up a portable app's resources on exit. |
@mmaietta
to
Do you have a plan to put the patch in the next build? Thanks, |
Hmmm, that doesn't make sense to me. That shouldn't have worked if your config value was false. |
… to each portable app launch) when set explicitly to false. Implements electron-userland#5764, electron-userland#5382, electron-userland#4105
@kobakou I think I may have determined the fix for cleaning up the install dir. Can you try this patch? Need confirmation for opening a PR.
Main part is changing it to use |
@mmaietta
Thanks. |
@mmaietta , I'm looking forward to opening your PR. If I can do your help, please ask me! |
@kobakou, sorry for the delayed reply here. Things got swamped on my side. |
@mmaietta thank you for coming back and sharing your status! It sounds good for me. |
I hope this issue will get high order on the list for the next release. |
Finally circling back on this ticket but I'm struggling to figure out where I left off 😅 I'll need to figure out how to create some unit tests around this to fix the behavior. Maybe I can stub the ksuid generator.
After that I'll probably post back and request you to run another test with a |
@mmaietta, thanks a lot for coming back! I expect XXX in nsXXX.tmp will be randomly generated for every launch. |
@kobakou could you please verify from your side all 3 flows with this patch file? You'll need to use v22.11.9
|
…' (or covers empty strings) (electron-userland#5764)
@mmaietta portable: {
requestExecutionLevel: 'user',
unpackDirName: true,
}, |
I've referred to this PR, and make changes in Thanks! |
So, just to confirm. The reason this occurred was due to the scheme.json not being up-to-date? After updating the scheme.json locally, it all worked as expected?
Please review my PR and mark as approved if it looks good to you |
@mmaietta |
Backgrounds:
Issues:
How can I resolve this issue, such as changing extract folder for each launch instance or preventing delete extracted resources when closing the second instance?
I found a similar post in the issues log, but I can not find a resolution.
#5382 (comment)
Thanks,
Kou
The text was updated successfully, but these errors were encountered: