feat: add Electron branding options #5727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmaietta
approved these changes
Mar 24, 2021
There was a problem hiding this comment.
I love this and had the exact same issue to work around, I also didn't realize that the BRANDING.json was available for changing exec names though. We had it manually patched in our fork. 😅
Approved.
Will wait a little before merging in case anyone else would like to chime in with feedback
|
@mmaietta sorry to bother, but is there any rough estimate on a schedule for publishing recent changes? |
|
Hi @samuelmaddock, apologies on the delay. I don't have the right access to publish builds, but we just did release one! Please try 22.11.3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Electron project contains a BRANDING.json file which will modify the resulting executable file names. A project I'm working on does exactly this in a fork of Electron.
Exposing these branding options allows Electron forks to build properly if branding has changed.