Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S3 acl:private net::ERR_INVALID_ARGUMENT error on electron-updater #4758

Closed
blgo opened this issue Mar 9, 2020 · 0 comments
Closed

S3 acl:private net::ERR_INVALID_ARGUMENT error on electron-updater #4758

blgo opened this issue Mar 9, 2020 · 0 comments

Comments

@blgo
Copy link

blgo commented Mar 9, 2020

Links to issue #4454

Builder version not relevant, only applies when checking for updates on the installed app

electron-updater: 4.2.4

I am using S3 with acl: private
target: nsis (windows 10)

I am setting the headers with aws4 signing and aws-sdk:
{Host: s3.region.amazonaws.com, 'X-Amx-Content-Sha256': XXXXXXXX, 'X-Amx-Date': 'YYYYMMDDTHHddmmZ', Authorization: 'AWS4-HMAC-SHA256 Credential=XXX, SignedHeareds=XXXX, Signature=XXXX'}

I have been doing some reading and everything points to changes introduced in how Electron implements net from version 7.

electron-updater using electron's net:

I guess some agument passed in "options" is not valid, and we get the error in auto-updater:
net::ERR_INVALID_ARGUMENT

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant