feat: manually control version strings in installers and uninstallers #4517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, each build has the current version string(s) embedded in various files - namely, the branded Electron executable and (in the case of NSIS) the uninstaller. This causes each installation package to differ considerably from the previous one, as especially compressing of the modified executable may well lead to megabytes of changed data.
With this feature, adding "shortVersion" and (optionally) "shortVersionWindows" in package.json embeds these values instead. Thus a build can be internally tagged as "1.x" or similarly (1.0.0.0 in the Windows format) and have consecutive branded executables or uninstallers identical to the previous ones (as long as the version strings don't change). The result is a significant decrease in update sizes.