fix(app-builder-lib): signing certificate selection by sha1

[torywheelwright]

Resolves #4291

[torywheelwright]

What can I do to help this PR get merged?

[Feverqwe]

Now it return true when certificateSha1 is null and set correct certificateSubjectName. I think it works incorrect.

(('b' != null && !'abc'.includes('b')) || 'some hash' !== null) // true

From here:
1f2865b#commitcomment-36999255

[Feverqwe]

Maybe should be something like that:

if (certificateSubjectName !== null && !certInfo.Subject.includes(certificateSubjectName)) {
  continue;
}

if (certificateSha1 !== null && certInfo.Thumbprint !== certificateSha1) {
  continue;
}

[kzimny]

Look at #4631 The output of powershell shows the thumprint is uppercase and you compare to original thumprint in lowercase.
The fix:

if ((certificateSubjectName != null && !certInfo.Subject.includes(certificateSubjectName))
    || certInfo.Thumbprint.toLowerCase() !== certificateSha1)

[pablocar80]

@kzimny that would make the code not work when the user types the thumbprint in uppercase. This can happen if they copy and paste from powershell.

Given that powershell returns already in uppercase, the code can convert what the user typed to uppercase and then compare.

Also, if the user did not specify any sha1, then any certificate that matches the subject should be allowed, according to documentation.