Prevent download notification queueing #2850
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caseywebdev
force-pushed
the
fix-download-notification
branch
from
d25771e
to
3a3e631
Compare
|
Thanks! Please try 2.21.9 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation using
this.signals.updateDownloadedis creating an event listener that is never removed. The problem with this is that if you callcheckForUpdatesAndNotify, no update is found, then callcheckForUpdatesAndNotifyagain an hour later and an update is found, the notification in this method is actually created twice. This PR updates the method to notify the user when an update is available and the download is successful instead of binding to theupdateDownloadedevent.