From 6fcd47767af8a95ab018fe0d8a07d2c53a72067d Mon Sep 17 00:00:00 2001 From: Mike Maietta Date: Sun, 27 Feb 2022 11:05:23 -0800 Subject: [PATCH] fix: Reactivating bitbucket integration test for nsis updater (#6680) --- .github/workflows/test.yaml | 2 +- packages/app-builder-lib/scheme.json | 2 +- .../snapshots/updater/nsisUpdaterTest.js.snap | 24 +++++++++++++++++++ 3 files changed, 26 insertions(+), 2 deletions(-) diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml index fbb36d631e..3c92f8d0df 100644 --- a/.github/workflows/test.yaml +++ b/.github/workflows/test.yaml @@ -85,7 +85,7 @@ jobs: env: TEST_FILES: nsisUpdaterTest KEYGEN_TOKEN: ${{ secrets.KEYGEN_TOKEN }} - # BITBUCKET_TOKEN: ${{ secrets.BITBUCKET_TOKEN }} + BITBUCKET_TOKEN: ${{ secrets.BITBUCKET_TOKEN }} GH_TOKEN: ${{ secrets.GH_TOKEN }} FORCE_COLOR: 1 diff --git a/packages/app-builder-lib/scheme.json b/packages/app-builder-lib/scheme.json index a9bcf6e2cb..39fcf51777 100644 --- a/packages/app-builder-lib/scheme.json +++ b/packages/app-builder-lib/scheme.json @@ -5647,7 +5647,7 @@ ] }, "certificateSubjectName": { - "description": "The name of the subject of the signing certificate. Required only for EV Code Signing and works only on Windows (or on macOS if [Parallels Desktop](https://www.parallels.com/products/desktop/) Windows 10 virtual machines exits).", + "description": "The name of the subject of the signing certificate, which is often labeled with the field name `issued to`. Required only for EV Code Signing and works only on Windows (or on macOS if [Parallels Desktop](https://www.parallels.com/products/desktop/) Windows 10 virtual machines exits).", "type": [ "null", "string" diff --git a/test/snapshots/updater/nsisUpdaterTest.js.snap b/test/snapshots/updater/nsisUpdaterTest.js.snap index e8954f1fb2..a6818a5064 100644 --- a/test/snapshots/updater/nsisUpdaterTest.js.snap +++ b/test/snapshots/updater/nsisUpdaterTest.js.snap @@ -112,6 +112,30 @@ Object { } `; +exports[`file url bitbucket 1`] = ` +Object { + "files": Array [ + Object { + "sha512": "jgS5EI08u/fsS9XfqpJtmV2ctAFQF+6BQjGUZmWq93Nyg+Z/aPxQT0zkCWPaCdIqJdEDHB91JjYquK/tS3fcDw==", + "size": 69549503, + "url": "electron-quick-start-typescript-1.0.0-x64.exe", + }, + ], + "path": "electron-quick-start-typescript-1.0.0-x64.exe", + "releaseDate": "2022-02-26T18:50:44.444Z", + "sha512": "jgS5EI08u/fsS9XfqpJtmV2ctAFQF+6BQjGUZmWq93Nyg+Z/aPxQT0zkCWPaCdIqJdEDHB91JjYquK/tS3fcDw==", + "version": "1.0.0", +} +`; + +exports[`file url bitbucket 2`] = ` +Array [ + "checking-for-update", + "update-available", + "update-downloaded", +] +`; + exports[`file url generic - manual download 1`] = ` Object { "files": Array [