Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated function warnings #185

Open
alejandroclaro opened this issue May 25, 2020 · 3 comments
Open

Deprecated function warnings #185

alejandroclaro opened this issue May 25, 2020 · 3 comments

Comments

@alejandroclaro
Copy link

alejandroclaro commented May 25, 2020

Some electron function that are being used by Devtron are now deprecated and will be removed:

(electron) 'BrowserWindow.getDevToolsExtensions' is deprecated and will be removed. Please use 'session.getAllExtensions' instead.
(electron) 'BrowserWindow.addDevToolsExtension' is deprecated and will be removed. Please use 'session.loadExtension' instead.\

Please prepare the project for these chages.

@cSarcasme
Copy link

i change what you said but it doest work same error with the new name changed

@SilvaQ
Copy link

SilvaQ commented Oct 20, 2020

same problem.

i use :

app.on("ready", async () => {
  await session.defaultSession.loadExtension(
    path.join(__dirname, "../extentions/devtron")
  );
  // .then(({ id }) => console.log("loaded", id));
  // Note that in order to use the React DevTools extension, you'll need to
  // download and unzip a copy of the extension.
});

the extention report manifest error, so i fix the menifest:

{
  "name": "devtron",
  "manifest_version": 2,
  "version": "2",
  "devtools_page": "static/devtron.html",
  "content_scripts": [
    {
      "matches": ["<all_urls>"],
      "js": ["out/browser-globals.js"]
    }
  ]
}

add manifest_version and matches field for it ,so now load the extention is successful but not work

image

@SilvaQ
Copy link

SilvaQ commented Oct 20, 2020

same problem.

i use :

app.on("ready", async () => {
  await session.defaultSession.loadExtension(
    path.join(__dirname, "../extentions/devtron")
  );
  // .then(({ id }) => console.log("loaded", id));
  // Note that in order to use the React DevTools extension, you'll need to
  // download and unzip a copy of the extension.
});

the extention report manifest error, so i fix the menifest:

{
  "name": "devtron",
  "manifest_version": 2,
  "version": "2",
  "devtools_page": "static/devtron.html",
  "content_scripts": [
    {
      "matches": ["<all_urls>"],
      "js": ["out/browser-globals.js"]
    }
  ]
}

add manifest_version and matches field for it ,so now load the extention is successful but not work

image

react dev tools extentions work is well with the same way:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants