Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

source location for journey files has incorrect filepath #520

Closed
vigneshshanmugam opened this issue Jun 3, 2022 · 1 comment · Fixed by #521
Closed

source location for journey files has incorrect filepath #520

vigneshshanmugam opened this issue Jun 3, 2022 · 1 comment · Fixed by #521
Labels
bug Something isn't working

Comments

@vigneshshanmugam
Copy link
Member

  • To extract the source location information for journeys, we rely on source-map library to extract the fileName and other stack related information. But there was a bug in the library that did not handle the absolute file paths correctly when extracting that info which lead to incorrect fileName and resulted in push command getting failed.
Error: Build failed with 1 error:
error: ENOENT: no such file or directory, open '/Users/vigneshh/elastic/synthetics/examples/todos/file:/Users/vigneshh/elastic/synthetics/examples/todos/basic.journey.ts'
    at failureErrorWithLog 
....
  errors: [
    {
      detail: [Error],
      location: null,
      notes: [Array],
      pluginName: 'esbuild-multiasset-plugin',
      text: "ENOENT: no such file or directory, open '/Users/vigneshh/elastic/synthetics/examples/todos/file:/Users/vigneshh/elastic/synthetics/examples/todos/basic.journey.ts'"
    }
  ],
  warnings: []
}

But there is a fix in the latest version that handles the file urls correctly and also has better ESM support - cspotcode/node-source-map-support#38

@shahzad31
Copy link
Contributor

Push command works now without the error !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants